feat(dashboard-limits): Add basic and edit flags into planFeature (#97773)

This forces the dashboards-edit and dashboards-basic feature flags to be
associated to business and team plans even if they aren't returned by
getsentry. This allows us to continue to indicate to the user what the
next lowest plan the user needs to upgrade to for the feature.

This is so we can migrate off of getsentry and move the flags into
Flagpole to more easily switch the flags on when releasing logs.

Builds off of #97148 which
accomplishes the same thing but for `global-views` on different plans.

Author: narsaynorath

static/gsApp/components/features/planFeature.spec.tsx

@@ -210,4 +210,52 @@ describe('PlanFeature', () => {
       });
     });
   });
+
+  it('returns dashboards-basic in team plan even if response does not include it', async function () {
+    const mockFn = jest.fn(() => null);
+
+    const sub = SubscriptionFixture({
+      organization,
+      planTier: PlanTier.MM2,
+      plan: 'mm2_f',
+    });
+    SubscriptionStore.set(organization.slug, sub);
+
+    render(
+      <PlanFeature organization={organization} features={['dashboards-basic']}>
+        {mockFn}
+      </PlanFeature>
+    );
+
+    await waitFor(() => {
+      expect(mockFn).toHaveBeenCalledWith({
+        plan: PlanDetailsLookupFixture('am2_team'),
+        tierChange: 'am2',
+      });
+    });
+  });
+
+  it('returns dashboards-edit in business plan even if response does not include it', async function () {
+    const mockFn = jest.fn(() => null);
+
+    const sub = SubscriptionFixture({
+      organization,
+      planTier: PlanTier.MM2,
+      plan: 'mm2_f',
+    });
+    SubscriptionStore.set(organization.slug, sub);
+
+    render(
+      <PlanFeature organization={organization} features={['dashboards-edit']}>
+        {mockFn}
+      </PlanFeature>
+    );
+
+    await waitFor(() => {
+      expect(mockFn).toHaveBeenCalledWith({
+        plan: PlanDetailsLookupFixture('am2_business'),
+        tierChange: 'am2',
+      });
+    });
+  });
 });

static/gsApp/components/features/planFeature.tsx

@@ -10,6 +10,7 @@ import {
   isAmEnterprisePlan,
   isBizPlanFamily,
   isDeveloperPlan,
+  isTeamPlanFamily,
 } from 'getsentry/utils/billing';
 
 type RenderProps = {
@@ -119,6 +120,16 @@ function PlanFeature({subscription, features, organization, children}: Props) {
         plan.features.push('global-views');
       }
     }
+    if (isBizPlanFamily(plan)) {
+      if (!plan.features.includes('dashboards-edit')) {
+        plan.features.push('dashboards-edit');
+      }
+    }
+    if (isTeamPlanFamily(plan) || isBizPlanFamily(plan)) {
+      if (!plan.features.includes('dashboards-basic')) {
+        plan.features.push('dashboards-basic');
+      }
+    }
   }
 
   // Locate the first plan that offers these features

tests/js/getsentry-test/fixtures/am1Plans.ts

@@ -57,7 +57,6 @@ const AM1_TEAM_FEATURES = [
   ...AM1_FREE_FEATURES,
   'codecov-integration',
   'crash-rate-alerts',
-  'dashboards-basic',
   'discover-basic',
   'incidents',
   'integrations-issue-basic',
@@ -79,7 +78,6 @@ const AM1_BUSINESS_FEATURES = [
   'change-alerts',
   'custom-inbound-filters',
   'custom-symbol-sources',
-  'dashboards-edit',
   'data-forwarding',
   'discard-groups',
   'discover-query',

tests/js/getsentry-test/fixtures/am2Plans.ts

@@ -68,7 +68,6 @@ const AM2_TEAM_FEATURES = [
   ...AM2_FREE_FEATURES,
   'codecov-integration',
   'crash-rate-alerts',
-  'dashboards-basic',
   'discover-basic',
   'incidents',
   'integrations-issue-basic',
@@ -90,7 +89,6 @@ const AM2_BUSINESS_FEATURES = [
   'change-alerts',
   'custom-inbound-filters',
   'custom-symbol-sources',
-  'dashboards-edit',
   'data-forwarding',
   'discard-groups',
   'discover-query',

tests/js/getsentry-test/fixtures/am3Plans.ts

@@ -90,7 +90,6 @@ const AM3_TEAM_FEATURES = [
   ...AM3_FREE_FEATURES,
   'codecov-integration',
   'crash-rate-alerts',
-  'dashboards-basic',
   'discover-basic',
   'incidents',
   'integrations-issue-basic',
@@ -111,7 +110,6 @@ const AM3_BUSINESS_FEATURES = [
   'change-alerts',
   'custom-inbound-filters',
   'custom-symbol-sources',
-  'dashboards-edit',
   'data-forwarding',
   'discard-groups',
   'discover-query',

tests/js/getsentry-test/fixtures/mm2Plans.ts

@@ -690,7 +690,6 @@ const MM2_PLANS: Record<string, Plan> = {
       'custom-symbol-sources',
       'data-forwarding',
       'discard-groups',
-      'dashboards-basic',
       'discover-query',
       'integrations-codeowners',
       'integrations-event-hooks',