bug(preprod): Fix incorrect URL being returned from assemble endpoint (#97811)

Resolves EME-214

Author: rbro112

src/sentry/preprod/api/endpoints/organization_preprod_artifact_assemble.py

@@ -12,6 +12,7 @@
 from sentry.api.bases.project import ProjectEndpoint, ProjectReleasePermission
 from sentry.debug_files.upload import find_missing_chunks
 from sentry.models.orgauthtoken import is_org_auth_token_auth, update_org_auth_token_last_used
+from sentry.models.project import Project
 from sentry.preprod.analytics import PreprodArtifactApiAssembleEvent
 from sentry.preprod.tasks import assemble_preprod_artifact, create_preprod_artifact
 from sentry.preprod.url_utils import get_preprod_artifact_url
@@ -96,7 +97,7 @@ class ProjectPreprodArtifactAssembleEndpoint(ProjectEndpoint):
         }
     }
 
-    def post(self, request: Request, project) -> Response:
+    def post(self, request: Request, project: Project) -> Response:
         """
         Assembles a preprod artifact (mobile build, etc.) and stores it in the database.
         """
@@ -175,7 +176,7 @@ def post(self, request: Request, project) -> Response:
             if is_org_auth_token_auth(request.auth):
                 update_org_auth_token_last_used(request.auth, [project.id])
 
-        artifact_url = get_preprod_artifact_url(project.organization_id, artifact_id)
+        artifact_url = get_preprod_artifact_url(project.organization_id, project.slug, artifact_id)
 
         return Response(
             {

src/sentry/preprod/url_utils.py

@@ -3,11 +3,11 @@
 from sentry.models.organization import Organization
 
 
-def get_preprod_artifact_url(organization_id: int, artifact_id: str) -> str:
+def get_preprod_artifact_url(organization_id: int, project_slug: str, artifact_id: str) -> str:
     """
     Build a region/customer-domain aware absolute URL for the preprod artifact UI.
     """
     organization: Organization = Organization.objects.get_from_cache(id=organization_id)
 
-    path = f"/organizations/{organization.slug}/preprod/internal/{artifact_id}"
+    path = f"/organizations/{organization.slug}/preprod/{project_slug}/{artifact_id}"
     return organization.absolute_url(path)

tests/sentry/preprod/api/endpoints/test_organization_preprod_artifact_assemble.py

@@ -362,7 +362,9 @@ def test_assemble_basic(
         assert response.status_code == 200, response.content
         assert response.data["state"] == ChunkFileState.CREATED
         assert set(response.data["missingChunks"]) == set()
-        expected_url = f"/organizations/{self.organization.slug}/preprod/internal/{artifact_id}"
+        expected_url = (
+            f"/organizations/{self.organization.slug}/preprod/{self.project.slug}/{artifact_id}"
+        )
         assert expected_url in response.data["artifactUrl"]
 
         mock_create_preprod_artifact.assert_called_once_with(
@@ -429,7 +431,9 @@ def test_assemble_with_metadata(
         assert response.status_code == 200, response.content
         assert response.data["state"] == ChunkFileState.CREATED
         assert set(response.data["missingChunks"]) == set()
-        expected_url = f"/organizations/{self.organization.slug}/preprod/internal/{artifact_id}"
+        expected_url = (
+            f"/organizations/{self.organization.slug}/preprod/{self.project.slug}/{artifact_id}"
+        )
         assert expected_url in response.data["artifactUrl"]
 
         mock_create_preprod_artifact.assert_called_once_with(