Skip to content

Commit b9a9d6b

Browse files
authored
feat(issues): Combine regression issue details layouts (#80433)
1 parent db5cbea commit b9a9d6b

File tree

8 files changed

+136
-146
lines changed

8 files changed

+136
-146
lines changed

static/app/utils/issueTypeConfig/index.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,17 @@ const BASE_CONFIG: IssueTypeConfig = {
3939
aiSuggestedSolution: false,
4040
events: {enabled: true},
4141
mergedIssues: {enabled: false},
42+
performanceDurationRegression: {enabled: false},
43+
profilingDurationRegression: {enabled: false},
4244
regression: {enabled: false},
4345
replays: {enabled: false},
4446
showFeedbackWidget: false,
45-
stats: {enabled: true},
4647
similarIssues: {enabled: false},
48+
spanEvidence: {enabled: false},
49+
stacktrace: {enabled: true},
50+
stats: {enabled: true},
4751
tags: {enabled: true},
52+
tagsTab: {enabled: true},
4853
userFeedback: {enabled: false},
4954
discover: {enabled: true},
5055
evidence: {title: t('Evidence')},

static/app/utils/issueTypeConfig/performanceConfig.tsx

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ const performanceConfig: IssueCategoryConfigMapping = {
2727
mergedIssues: {enabled: false},
2828
replays: {enabled: true},
2929
similarIssues: {enabled: false},
30+
stacktrace: {enabled: false},
31+
spanEvidence: {enabled: true},
3032
userFeedback: {enabled: false},
3133
// Performance issues render a custom SpanEvidence component
3234
evidence: null,
@@ -195,8 +197,12 @@ const performanceConfig: IssueCategoryConfigMapping = {
195197
discover: {enabled: false},
196198
regression: {enabled: true},
197199
replays: {enabled: false},
200+
performanceDurationRegression: {enabled: true},
198201
stats: {enabled: false},
199202
tags: {enabled: false},
203+
tagsTab: {enabled: false},
204+
// We show the regression summary instead
205+
spanEvidence: {enabled: false},
200206
},
201207
[IssueType.PERFORMANCE_ENDPOINT_REGRESSION]: {
202208
actions: {
@@ -225,9 +231,13 @@ const performanceConfig: IssueCategoryConfigMapping = {
225231
},
226232
discover: {enabled: false},
227233
regression: {enabled: true},
234+
performanceDurationRegression: {enabled: true},
228235
replays: {enabled: false},
229236
stats: {enabled: false},
230237
tags: {enabled: false},
238+
tagsTab: {enabled: false},
239+
// We show the regression summary instead
240+
spanEvidence: {enabled: false},
231241
},
232242
[IssueType.PROFILE_FILE_IO_MAIN_THREAD]: {
233243
resources: {
@@ -317,9 +327,13 @@ const performanceConfig: IssueCategoryConfigMapping = {
317327
discover: {enabled: false},
318328
events: {enabled: false},
319329
regression: {enabled: true},
330+
profilingDurationRegression: {enabled: true},
320331
replays: {enabled: false},
332+
// We show the regression summary instead
333+
spanEvidence: {enabled: false},
321334
stats: {enabled: false},
322335
tags: {enabled: false},
336+
tagsTab: {enabled: false},
323337
},
324338
[IssueType.PROFILE_FUNCTION_REGRESSION]: {
325339
actions: {
@@ -349,9 +363,13 @@ const performanceConfig: IssueCategoryConfigMapping = {
349363
discover: {enabled: false},
350364
events: {enabled: false},
351365
regression: {enabled: true},
366+
profilingDurationRegression: {enabled: true},
352367
replays: {enabled: false},
353368
stats: {enabled: false},
369+
// We show the regression summary instead
370+
spanEvidence: {enabled: false},
354371
tags: {enabled: false},
372+
tagsTab: {enabled: false},
355373
},
356374
};
357375

static/app/utils/issueTypeConfig/replayConfig.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ const replayConfig: IssueCategoryConfigMapping = {
2222
stats: {enabled: true},
2323
similarIssues: {enabled: false},
2424
showFeedbackWidget: true,
25-
tags: {enabled: true},
25+
tagsTab: {enabled: true},
2626
userFeedback: {enabled: true},
2727
discover: {enabled: true},
2828
evidence: {title: t('Evidence')},

static/app/utils/issueTypeConfig/types.tsx

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,14 @@ export type IssueTypeConfig = {
5959
* Is the Merged Issues tab shown for this issue
6060
*/
6161
mergedIssues: DisabledWithReasonConfig;
62+
/**
63+
* Shows performance duration regression components
64+
*/
65+
performanceDurationRegression: DisabledWithReasonConfig;
66+
/**
67+
* Shows profiling duration regression components
68+
*/
69+
profilingDurationRegression: DisabledWithReasonConfig;
6270
/**
6371
* Enables various regression related supporting data for an issue type.
6472
*/
@@ -90,14 +98,23 @@ export type IssueTypeConfig = {
9098
* Is the Similar Issues tab shown for this issue
9199
*/
92100
similarIssues: DisabledWithReasonConfig;
101+
spanEvidence: DisabledWithReasonConfig;
102+
/**
103+
* Is the Stacktrace shown for this issue
104+
*/
105+
stacktrace: DisabledWithReasonConfig;
93106
/**
94107
* Are group stats (counts/time series) shown for this issue.
95108
*/
96109
stats: DisabledWithReasonConfig;
97110
/**
98-
* Is the Tags tab show for this issue
111+
* Are event tags or highlights shown for this issue
99112
*/
100113
tags: DisabledWithReasonConfig;
114+
/**
115+
* Is the Tags tab show for this issue
116+
*/
117+
tagsTab: DisabledWithReasonConfig;
101118
/**
102119
* Is the User Feedback tab shown for this issue
103120
*/

static/app/utils/issueTypeConfig/uptimeConfig.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const uptimeConfig: IssueCategoryConfigMapping = {
2121
userFeedback: {enabled: false},
2222
usesIssuePlatform: true,
2323
stats: {enabled: false},
24-
tags: {enabled: false},
24+
tagsTab: {enabled: false},
2525
issueSummary: {enabled: false},
2626
},
2727
};

0 commit comments

Comments
 (0)