feat(cells) Add silo annotations to email, debug, and plugin views (#104034)

Add silo annotations to the debug views, and plugin views. While debug
email views are never run in production, having silo annotations on
these will allow silo completeness tests to have fewer exceptions.

Refs INFRENG-201

Author: markstory

src/sentry/charts/endpoints.py

@@ -5,12 +5,14 @@
 from django.views import static
 
 import sentry
+from sentry.web.frontend.base import all_silo_view
 
 CONFIG_DIR = os.path.abspath(
     os.path.join(os.path.dirname(sentry.__file__), "..", "..", "config", "chartcuterie")
 )
 
 
+@all_silo_view
 def serve_chartcuterie_config(
     request: HttpRequest,
 ) -> HttpResponseBase:

src/sentry/silo/base.py

@@ -3,7 +3,6 @@
 import abc
 import contextlib
 import functools
-import itertools
 import threading
 import typing
 from collections.abc import Callable, Generator, Iterable
@@ -158,10 +157,11 @@ def override(*args: P.args, **kwargs: P.kwargs) -> R:
             if is_available:
                 return original_method(*args, **kwargs)
             else:
+                modes = list(self.modes)
+                if SiloMode.MONOLITH not in self.modes:
+                    modes = modes + [SiloMode.MONOLITH]
                 handler = self.handle_when_unavailable(
-                    original_method,
-                    SiloMode.get_current_mode(),
-                    itertools.chain([SiloMode.MONOLITH], self.modes),
+                    original_method, SiloMode.get_current_mode(), modes
                 )
                 return handler(*args, **kwargs)
 

src/sentry/web/frontend/base.py

@@ -57,6 +57,12 @@
 
 
 class ViewSiloLimit(SiloLimit):
+    def __init__(self, modes: SiloMode | Iterable[SiloMode], internal: bool = False) -> None:
+        if isinstance(modes, SiloMode):
+            modes = [modes]
+        self.modes = frozenset(modes)
+        self.internal = internal
+
     def modify_endpoint_class(self, decorated_class: type[View]) -> type:
         dispatch_override = self.create_override(decorated_class.dispatch)
         new_class = type(
@@ -71,7 +77,10 @@ def modify_endpoint_class(self, decorated_class: type[View]) -> type:
         return new_class
 
     def modify_endpoint_method(self, decorated_method: Callable[..., Any]) -> Callable[..., Any]:
-        return self.create_override(decorated_method)
+        decorated = self.create_override(decorated_method)
+        setattr(decorated, "silo_limit", self)
+
+        return decorated
 
     def handle_when_unavailable(
         self,
@@ -115,25 +124,32 @@ def __call__(self, decorated_obj: Any) -> Any:
         raise TypeError("`@ViewSiloLimit` must decorate a class or method")
 
 
-control_silo_view = ViewSiloLimit(SiloMode.CONTROL)
+control_silo_view = ViewSiloLimit([SiloMode.CONTROL])
 """
 Apply to frontend views that exist in CONTROL Silo
 If a request is received and the application is not in CONTROL/MONOLITH
 mode a 404 will be returned.
 """
 
-region_silo_view = ViewSiloLimit(SiloMode.REGION)
+region_silo_view = ViewSiloLimit([SiloMode.REGION])
 """
 Apply to frontend views that exist in REGION Silo
 If a request is received and the application is not in REGION/MONOLITH
 mode a 404 will be returned.
 """
 
-all_silo_view = ViewSiloLimit(SiloMode.REGION, SiloMode.CONTROL, SiloMode.MONOLITH)
+all_silo_view = ViewSiloLimit([SiloMode.REGION, SiloMode.CONTROL, SiloMode.MONOLITH])
 """
 Apply to frontend views that respond in both CONTROL and REGION mode.
 """
 
+internal_region_silo_view = ViewSiloLimit([SiloMode.REGION], internal=True)
+"""
+Apply to frontend views that exist in REGION Silo
+and are not accessible via cell routing.
+This is generally for debug/development views.
+"""
+
 
 class _HasRespond(Protocol):
     active_organization: RpcUserOrganizationContext | None

src/sentry/web/frontend/debug/charts/debug_chart_renderer.py

@@ -3,6 +3,7 @@
 
 from sentry.charts import backend as charts
 from sentry.charts.types import ChartType
+from sentry.web.frontend.base import internal_region_silo_view
 from sentry.web.frontend.debug.mail import MailPreview
 
 discover_total_period = {
@@ -279,6 +280,7 @@
 }
 
 
+@internal_region_silo_view
 class DebugChartRendererView(View):
     def get(self, request: HttpRequest) -> HttpResponse:
         ret = []

src/sentry/web/frontend/debug/charts/metric_alert_charts.py

@@ -4,6 +4,7 @@
 from sentry.charts import backend as charts
 from sentry.charts.types import ChartType
 from sentry.seer.anomaly_detection.types import AnomalyType
+from sentry.web.frontend.base import internal_region_silo_view
 from sentry.web.frontend.debug.mail import MailPreview
 
 incident = {
@@ -510,6 +511,7 @@
 }
 
 
+@internal_region_silo_view
 class DebugMetricAlertChartRendererView(View):
     def get(self, request: HttpRequest) -> HttpResponse:
         ret = []

src/sentry/web/frontend/debug/debug_auth_views.py

@@ -2,9 +2,11 @@
 from django.views.generic import View
 
 from sentry.users.models.user import User
+from sentry.web.frontend.base import internal_region_silo_view
 from sentry.web.helpers import render_to_response
 
 
+@internal_region_silo_view
 class DebugAuthConfirmIdentity(View):
     def get(self, request: HttpRequest) -> HttpResponse:
         auth_identity = {"id": "[email protected]", "email": "[email protected]"}
@@ -21,6 +23,7 @@ def get(self, request: HttpRequest) -> HttpResponse:
         )
 
 
+@internal_region_silo_view
 class DebugAuthConfirmLink(View):
     def get(self, request: HttpRequest) -> HttpResponse:
         auth_identity = {"id": "[email protected]", "email": "[email protected]"}

src/sentry/web/frontend/debug/debug_codeowners_auto_sync_failure_email.py

@@ -6,10 +6,12 @@
 from sentry.models.project import Project
 from sentry.notifications.notifications.codeowners_auto_sync import AutoSyncNotification
 from sentry.users.models.user import User
+from sentry.web.frontend.base import internal_region_silo_view
 
 from .mail import render_preview_email_for_notification
 
 
+@internal_region_silo_view
 class DebugCodeOwnersAutoSyncFailureView(View):
     def get(self, request: HttpRequest) -> HttpResponse:
         org = Organization(id=1, slug="petal", name="Petal")

src/sentry/web/frontend/debug/debug_cron_broken_monitor_email.py

@@ -3,6 +3,8 @@
 from django.http import HttpRequest, HttpResponse
 from django.views.generic import View
 
+from sentry.web.frontend.base import internal_region_silo_view
+
 from .mail import MailPreview
 
 
@@ -17,6 +19,7 @@ def get_context():
     }
 
 
+@internal_region_silo_view
 class DebugCronBrokenMonitorEmailView(View):
     def get(self, request: HttpRequest) -> HttpResponse:
         context = get_context()

src/sentry/web/frontend/debug/debug_cron_muted_monitor_email.py

@@ -3,6 +3,8 @@
 from django.http import HttpRequest, HttpResponse
 from django.views.generic import View
 
+from sentry.web.frontend.base import internal_region_silo_view
+
 from .mail import MailPreview
 
 
@@ -17,6 +19,7 @@ def get_context():
     }
 
 
+@internal_region_silo_view
 class DebugCronMutedMonitorEmailView(View):
     def get(self, request: HttpRequest) -> HttpResponse:
         context = get_context()

src/sentry/web/frontend/debug/debug_error_embed.py

@@ -5,9 +5,11 @@
 from django.views.generic import View
 
 from sentry.models.projectkey import ProjectKey
+from sentry.web.frontend.base import internal_region_silo_view
 from sentry.web.helpers import render_to_response
 
 
+@internal_region_silo_view
 class DebugErrorPageEmbedView(View):
     def _get_project_key(self):
         return ProjectKey.objects.filter(project=settings.SENTRY_PROJECT)[0]