Skip to content

Commit bf80a1a

Browse files
authored
acceptance: bump runners to 10 (#104791)
1 parent 7c9ef8e commit bf80a1a

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

.github/workflows/acceptance.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,11 @@ jobs:
5757
# and reducing the risk that one of many runs would turn red again (read: intermittent tests)
5858
fail-fast: false
5959
matrix:
60-
# XXX: When updating this, make sure you also update MATRIX_INSTANCE_TOTAL.
61-
instance: [0, 1, 2, 3, 4]
60+
# XXX: Use 5 runners when backend changes are present, 10 runners for frontend-only changes
61+
instance: ${{ needs.files-changed.outputs.backend_all == 'true' && fromJSON('[0, 1, 2, 3, 4]') || fromJSON('[0, 1, 2, 3, 4, 5, 6, 7, 8, 9]') }}
6262
env:
63-
# XXX: MATRIX_INSTANCE_TOTAL must be hardcoded to the length of strategy.matrix.instance.
64-
MATRIX_INSTANCE_TOTAL: 5
63+
# XXX: MATRIX_INSTANCE_TOTAL must match the matrix size (5 for backend changes, 10 for frontend-only)
64+
MATRIX_INSTANCE_TOTAL: ${{ needs.files-changed.outputs.backend_all == 'true' && '5' || '10' }}
6565
TEST_GROUP_STRATEGY: roundrobin
6666

6767
steps:

codecov.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ flags:
8383
carryforward: true
8484
# Do not send any status checks until n coverage reports are uploaded.
8585
# NOTE: If you change this, make sure to change `comment.after_n_builds` below as well.
86-
# this should match MATRIX_INSTANCE_TOTAL in accpetance.yml
86+
# this should match MATRIX_INSTANCE_TOTAL in accpetance.yml when backend_all == true
8787
after_n_builds: 5
8888

8989
# https://docs.codecov.com/docs/flags#two-approaches-to-flag-management

0 commit comments

Comments
 (0)