Commit c3db7c1
authored
chore(cell-actions): use popper strategy fixed instead of portalling (#97593)
### Changes
Instead of portals, use the fixed strategy. Main reason is that
portalling the dropdown to document body does not work with tables in
modals due to stacking issues (e.g., planning to add cell actions to
viewer table modal in dashboards)
There should be no UI change to the dropdown. This change only applies
when `discover-cell-actions-v2` is enabled.1 parent e88f3bc commit c3db7c1
File tree
2 files changed
+7
-1
lines changed- static/app
- components/dropdownMenu
- views/discover/table
2 files changed
+7
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| 71 | + | |
71 | 72 | | |
72 | 73 | | |
73 | 74 | | |
| |||
129 | 130 | | |
130 | 131 | | |
131 | 132 | | |
| 133 | + | |
| 134 | + | |
132 | 135 | | |
133 | 136 | | |
134 | 137 | | |
| |||
163 | 166 | | |
164 | 167 | | |
165 | 168 | | |
| 169 | + | |
| 170 | + | |
166 | 171 | | |
167 | 172 | | |
168 | 173 | | |
| |||
188 | 193 | | |
189 | 194 | | |
190 | 195 | | |
| 196 | + | |
191 | 197 | | |
192 | 198 | | |
193 | 199 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
365 | 365 | | |
366 | 366 | | |
367 | 367 | | |
368 | | - | |
| 368 | + | |
369 | 369 | | |
370 | 370 | | |
371 | 371 | | |
| |||
0 commit comments