Skip to content

Commit c7de9ee

Browse files
evanpurkhisercleptric
authored andcommitted
fix(issues): Use Heading in sentry app external issue modal title (#114748)
The sentry-app external issue modal (used for Linear and other internal-integration "issue link" components) rendered the modal title as plain text, while the first-party external issue modal used for Jira/GitHub/etc. wraps its title in `<Heading as="h4">`. The modal `Header` CSS only applies the 20px title size to `h1`-`h6` elements, so the sentry-app variant rendered noticeably smaller than its first-party siblings. Wrap the title in `<Heading as="h4">` so all integration modals share the same title size.
1 parent 35b0ccd commit c7de9ee

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

static/app/components/group/sentryAppExternalIssueModal.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import {Fragment, useState} from 'react';
22
import styled from '@emotion/styled';
33

44
import {TabList, Tabs} from '@sentry/scraps/tabs';
5+
import {Heading} from '@sentry/scraps/text';
56

67
import {openModal, type ModalRenderProps} from 'sentry/actionCreators/modal';
78
import {SentryAppExternalIssueForm} from 'sentry/components/group/sentryAppExternalIssueForm';
@@ -78,7 +79,9 @@ function SentryAppExternalIssueModal(props: Props) {
7879

7980
return (
8081
<Fragment>
81-
<Header closeButton>{tct('[name] Issue', {name})}</Header>
82+
<Header closeButton>
83+
<Heading as="h4">{tct('[name] Issue', {name})}</Heading>
84+
</Header>
8285
<TabsContainer>
8386
<Tabs value={action} onChange={setAction}>
8487
<TabList>

0 commit comments

Comments
 (0)