stop hardcoding type

Author: wedamija

src/sentry/monitors/utils.py

@@ -392,6 +392,8 @@ def update_issue_alert_rule(
 
 
 def ensure_cron_detector(monitor: Monitor):
+    from sentry.issues.grouptype import MonitorCheckInFailure
+
     try:
         with atomic_transaction(using=router.db_for_write(DataSource)):
             data_source, created = DataSource.objects.get_or_create(
@@ -401,7 +403,7 @@ def ensure_cron_detector(monitor: Monitor):
             )
             if created:
                 detector = Detector.objects.create(
-                    type="monitor_check_in_failure",
+                    type=MonitorCheckInFailure.slug,
                     project_id=monitor.project_id,
                     name=monitor.name,
                     owner_user_id=monitor.owner_user_id,

tests/sentry/monitors/test_utils.py

@@ -2,6 +2,7 @@
 
 from django.db import IntegrityError
 
+from sentry.issues.grouptype import MonitorIncidentType
 from sentry.monitors.types import DATA_SOURCE_CRON_MONITOR
 from sentry.monitors.utils import ensure_cron_detector
 from sentry.testutils.cases import TestCase
@@ -28,7 +29,7 @@ def test_creates_data_source_and_detector_for_new_monitor(self):
         )
         assert data_source is not None
         detector = Detector.objects.get(
-            type="monitor_check_in_failure",
+            type=MonitorIncidentType.slug,
             project_id=self.monitor.project_id,
             name=self.monitor.name,
         )
@@ -48,7 +49,7 @@ def test_idempotent_for_existing_data_source(self):
             source_id=str(self.monitor.id),
         )
         detector = Detector.objects.get(
-            type="monitor_check_in_failure",
+            type=MonitorIncidentType.slug,
             project_id=self.monitor.project_id,
             name=self.monitor.name,
         )
@@ -63,7 +64,7 @@ def test_idempotent_for_existing_data_source(self):
             source_id=str(self.monitor.id),
         )
         detector_after = Detector.objects.get(
-            type="monitor_check_in_failure",
+            type=MonitorIncidentType.slug,
             project_id=self.monitor.project_id,
             name=self.monitor.name,
         )
@@ -80,7 +81,7 @@ def test_with_owner_user(self):
         self.monitor.save()
         ensure_cron_detector(self.monitor)
         detector = Detector.objects.get(
-            type="monitor_check_in_failure",
+            type=MonitorIncidentType.slug,
             project_id=self.monitor.project_id,
         )
         assert detector.owner_user_id == self.user.id
@@ -90,7 +91,7 @@ def test_with_no_owner(self):
         ensure_cron_detector(self.monitor)
 
         detector = Detector.objects.get(
-            type="monitor_check_in_failure",
+            type=MonitorIncidentType.slug,
             project_id=self.monitor.project_id,
         )
         assert detector.owner_user_id is None