ref: set useUnknownInCatchVariables to true in tsconfig (#97665)

Note: all changes here are on type-level only - there are no runtime
changes.

Most things have been addressed by setting error explicitly to `any`. In
some simple cases, a type assertion was done. Tests have been changed
from try/catch to the `.toThrow` assertion.

This change slightly increases type coverage, as there are many
situations where error is now `unknown` instead of `any`:


  | Total Symbols | Covered Symbols | Uncovered Symbols | Symbol
Diff | Coverage Percentage | % Diff
-- | -- | -- | -- | -- | -- | --
before | 1,454,893 | 1,394,217 | 60,676 |   | 95.82% |  
after | 1,454,922 | 1,394,596 | 60,326 | -350 | 95.85% | +0.03%

Author: TkDodo

config/tsconfig.base.json

@@ -40,20 +40,17 @@
     "noUncheckedIndexedAccess": true,
     "strict": true,
     "strictBindCallApply": false,
-    "useUnknownInCatchVariables": false,
-
+    "useUnknownInCatchVariables": true,
     // We do not configure these, but are left here for documentation purposes
     //
     // allowUnreachableCode
     // allowUnusedLabels
     // exactOptionalPropertyTypes
     // noImplicitOverride
     // noPropertyAccessFromIndexSignature
-    // noUncheckedIndexedAccess
     // strictFunctionTypes
     // strictNullChecks
     // strictPropertyInitialization
-    // anduseUnknownInCatchVariables
 
     // Emit configuration
     "declaration": false,

jest.config.ts

@@ -75,7 +75,7 @@ if (CI && !process.env.JEST_LIST_TESTS_INNER) {
       env: {...process.env, JEST_LIST_TESTS_INNER: '1'},
     });
     JEST_TESTS = JSON.parse(stdout);
-  } catch (err) {
+  } catch (err: any) {
     if (err.code) {
       throw new Error(`err code ${err.code} when spawning process`);
     } else {

static/app/actionCreators/dashboards.tsx

@@ -125,7 +125,7 @@ export async function updateDashboardFavorite(
       queryKey: getQueryKey(organization),
     });
     addSuccessMessage(isFavorited ? t('Added as favorite') : t('Removed as favorite'));
-  } catch (response) {
+  } catch (response: any) {
     const errorResponse = response?.responseJSON ?? null;
     if (errorResponse) {
       const errors = flattenErrors(errorResponse, {});

static/app/actionCreators/guides.tsx

@@ -23,7 +23,7 @@ export async function fetchGuides() {
     }
     const data = await api.requestPromise('/assistant/');
     GuideStore.fetchSucceeded(data);
-  } catch (err) {
+  } catch (err: any) {
     if (err.status !== 401 && err.status !== 403) {
       Sentry.captureException(err);
     }

static/app/actionCreators/monitors.tsx

@@ -64,7 +64,7 @@ export async function updateMonitor(
     );
     clearIndicators();
     return resp;
-  } catch (err) {
+  } catch (err: any) {
     const respError: RequestError = err;
     const updateKeys = Object.keys(data);
 
@@ -165,7 +165,7 @@ export async function deleteMonitorProcessingErrorByType(
       }
     );
     clearIndicators();
-  } catch (err) {
+  } catch (err: any) {
     Sentry.captureException(err);
     if (err.status === 403) {
       addErrorMessage(t('You do not have permission to dismiss these processing errors'));
@@ -189,7 +189,7 @@ export async function deleteProjectProcessingErrorByType(
       query: {errortype},
     });
     clearIndicators();
-  } catch (err) {
+  } catch (err: any) {
     Sentry.captureException(err);
     if (err.status === 403) {
       addErrorMessage(t('You do not have permission to dismiss these processing errors'));

static/app/actionCreators/organization.tsx

@@ -68,7 +68,7 @@ async function fetchProjectsAndTeams(
 
   try {
     return await Promise.all([projectsPromise, teamsPromise]);
-  } catch (err) {
+  } catch (err: any) {
     // It's possible these requests fail with a 403 if the user has a role with
     // insufficient access to projects and teams, but *can* access org details
     // (e.g. billing). An example of this is in org settings.
@@ -106,7 +106,7 @@ export async function fetchOrganizationDetails(api: Client, slug: string): Promi
     let org: Organization | undefined = undefined;
     try {
       org = await fetchOrg(api, slug);
-    } catch (err) {
+    } catch (err: any) {
       if (!err) {
         throw err;
       }

static/app/actionCreators/performance.tsx

@@ -58,7 +58,7 @@ export async function fetchTeamKeyTransactions(
       } else {
         hasMore = false;
       }
-    } catch (err) {
+    } catch (err: any) {
       addErrorMessage(
         err.responseJSON?.detail ?? t('Error fetching team key transactions')
       );

static/app/actionCreators/uptime.tsx

@@ -26,7 +26,7 @@ export async function updateUptimeRule(
     clearIndicators();
     return resp;
   } catch (err) {
-    const respError: RequestError = err;
+    const respError = err as RequestError;
     const updateKeys = Object.keys(data);
 
     // If we are updating a single value in the monitor we can read the

static/app/api.tsx

@@ -553,7 +553,7 @@ export class Client {
           // Try to get text out of the response no matter the status
           try {
             responseText = await response.text();
-          } catch (error) {
+          } catch (error: any) {
             twoHundredErrorReason = 'Failed awaiting response.text()';
             ok = false;
             if (error.name === 'AbortError') {
@@ -572,7 +572,7 @@ export class Client {
           if (status !== 204 && !isStatus3XX) {
             try {
               responseJSON = JSON.parse(responseText);
-            } catch (error) {
+            } catch (error: any) {
               twoHundredErrorReason = 'Failed trying to parse responseText';
               if (error.name === 'AbortError') {
                 ok = false;

static/app/bootstrap/index.tsx

@@ -69,7 +69,7 @@ async function promiseRequest(url: string) {
     }
     // eslint-disable-next-line no-throw-literal
     throw [response.status, response.statusText];
-  } catch (error) {
+  } catch (error: any) {
     // eslint-disable-next-line no-throw-literal
     throw [error.status, error.statusText];
   }