Skip to content

Commit cc3cf18

Browse files
authored
fix(aci): remove ff check before triggering actions task in delayed workflow (#97760)
1 parent b80f847 commit cc3cf18

File tree

3 files changed

+2
-5
lines changed

3 files changed

+2
-5
lines changed

src/sentry/workflow_engine/processors/delayed_workflow.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -748,8 +748,7 @@ def fire_actions_for_groups(
748748
)
749749
total_actions += len(filtered_actions)
750750

751-
if should_trigger_actions(group_event.group.type):
752-
fire_actions(filtered_actions, detector, workflow_event_data)
751+
fire_actions(filtered_actions, detector, workflow_event_data)
753752

754753
logger.info(
755754
"workflow_engine.delayed_workflow.triggered_actions_summary",

tests/sentry/workflow_engine/processors/test_delayed_workflow.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
from sentry.rules.processing.buffer_processing import process_in_batches
1717
from sentry.rules.processing.delayed_processing import fetch_project
1818
from sentry.services.eventstore.models import Event
19-
from sentry.testutils.helpers import override_options, with_feature
19+
from sentry.testutils.helpers import override_options
2020
from sentry.testutils.helpers.datetime import before_now, freeze_time
2121
from sentry.testutils.helpers.redis import mock_redis_buffer
2222
from sentry.utils import json
@@ -919,7 +919,6 @@ def test_get_group_to_groupevent(self) -> None:
919919
assert group_to_groupevent == self.group_to_groupevent
920920

921921
@patch("sentry.workflow_engine.tasks.actions.trigger_action.apply_async")
922-
@with_feature("organizations:workflow-engine-trigger-actions")
923922
def test_fire_actions_for_groups__fire_actions(self, mock_trigger: MagicMock) -> None:
924923
fire_actions_for_groups(
925924
self.project.organization,

tests/sentry/workflow_engine/processors/test_workflow.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,6 @@ def test_workflow_fire_history_with_action_deduping(
277277
self, mock_trigger_action: MagicMock
278278
) -> None:
279279
"""Fire a single action, but record that it was fired for multiple workflows"""
280-
281280
self.action_group, self.action = self.create_workflow_action(workflow=self.error_workflow)
282281

283282
error_workflow_2 = self.create_workflow(

0 commit comments

Comments
 (0)