ref(replay): only handle iso timestamps in summary trace-connected errrors (#97729)

Followup on
#97647 (comment).
Verified from a production query and search_issues snuba config, that
both timestamp columns only store ISO. As a result we can simplify this
code a bit

Author: aliu39

src/sentry/replays/lib/summarize.py

@@ -1,7 +1,7 @@
 import logging
 from collections.abc import Generator, Iterator
 from datetime import datetime
-from typing import Any, Literal, TypedDict
+from typing import Any, TypedDict
 from urllib.parse import urlparse
 
 import sentry_sdk
@@ -59,18 +59,18 @@ def fetch_error_details(project_id: int, error_ids: list[str]) -> list[EventDict
         return []
 
 
-def _parse_snuba_timestamp_to_ms(timestamp: str | float, input_unit: Literal["s", "ms"]) -> float:
+def _parse_iso_timestamp_to_ms(timestamp: str | None) -> float:
     """
-    Parse a numeric or ISO timestamp to float milliseconds. `input_unit` is only used for numeric inputs.
+    Parses a nullable ISO timestamp to float milliseconds. Errors default to 0.
     """
-    if isinstance(timestamp, str):
-        try:
-            dt = datetime.fromisoformat(timestamp.replace("Z", "+00:00"))
-            return dt.timestamp() * 1000
-        except (ValueError, AttributeError):
-            return 0.0
+    if not timestamp:
+        return 0.0
 
-    return float(timestamp) * 1000 if input_unit == "s" else float(timestamp)
+    try:
+        dt = datetime.fromisoformat(timestamp.replace("Z", "+00:00"))
+        return dt.timestamp() * 1000
+    except (ValueError, AttributeError):
+        return 0.0
 
 
 @sentry_sdk.trace
@@ -135,11 +135,9 @@ def fetch_trace_connected_errors(
             error_data = query.process_results(result)["data"]
 
             for event in error_data:
-                snuba_ts_ms = event.get("timestamp_ms", 0.0)
-                snuba_ts_s = event.get("timestamp", 0.0)
-                timestamp = _parse_snuba_timestamp_to_ms(
-                    snuba_ts_ms, "ms"
-                ) or _parse_snuba_timestamp_to_ms(snuba_ts_s, "s")
+                timestamp = _parse_iso_timestamp_to_ms(
+                    event.get("timestamp_ms")
+                ) or _parse_iso_timestamp_to_ms(event.get("timestamp"))
 
                 if timestamp:
                     error_events.append(

tests/sentry/replays/unit/lib/test_summarize.py

@@ -3,7 +3,7 @@
 from sentry.models.project import Project
 from sentry.replays.lib.summarize import (
     EventDict,
-    _parse_snuba_timestamp_to_ms,
+    _parse_iso_timestamp_to_ms,
     as_log_message,
     get_summary_logs,
 )
@@ -255,27 +255,20 @@ def test_as_log_message() -> None:
     assert as_log_message({}) is None
 
 
-def test_parse_snuba_timestamp() -> None:
-    # Test numeric input
-    assert _parse_snuba_timestamp_to_ms(123.456, "ms") == 123.456
-    assert _parse_snuba_timestamp_to_ms(123, "s") == 123000
+def test_parse_iso_timestamp_to_ms() -> None:
+    # Without timezone
+    assert _parse_iso_timestamp_to_ms("2023-01-01T12:00:00") == 1672574400000
+    assert _parse_iso_timestamp_to_ms("2023-01-01T12:00:00.123") == 1672574400123
 
-    # Note input unit is ignored for string inputs.
+    # With timezone offset
+    assert _parse_iso_timestamp_to_ms("2023-01-01T12:00:00+00:00") == 1672574400000
+    assert _parse_iso_timestamp_to_ms("2023-01-01T12:00:00.123+00:00") == 1672574400123
 
-    # Test string input with ISO format without timezone
-    assert _parse_snuba_timestamp_to_ms("2023-01-01T12:00:00", "ms") == 1672574400000
-    assert _parse_snuba_timestamp_to_ms("2023-01-01T12:00:00", "s") == 1672574400000
+    # With 'Z' timezone suffix
+    assert _parse_iso_timestamp_to_ms("2023-01-01T12:00:00Z") == 1672574400000
+    assert _parse_iso_timestamp_to_ms("2023-01-01T12:00:00.123Z") == 1672574400123
 
-    # Test string input with ISO format with timezone offset
-    assert _parse_snuba_timestamp_to_ms("2023-01-01T12:00:00+00:00", "ms") == 1672574400000
-    assert _parse_snuba_timestamp_to_ms("2023-01-01T12:00:00.123+00:00", "ms") == 1672574400123
-    assert _parse_snuba_timestamp_to_ms("2023-01-01T12:00:00+00:00", "s") == 1672574400000
-
-    # Test string input with ISO format with 'Z' timezone suffix
-    assert _parse_snuba_timestamp_to_ms("2023-01-01T12:00:00Z", "s") == 1672574400000
-    assert _parse_snuba_timestamp_to_ms("2023-01-01T12:00:00.123Z", "ms") == 1672574400123
-
-    # Test invalid input
-    assert _parse_snuba_timestamp_to_ms("invalid timestamp", "ms") == 0.0
-    assert _parse_snuba_timestamp_to_ms("", "ms") == 0.0
-    assert _parse_snuba_timestamp_to_ms("2023-13-01T12:00:00Z", "ms") == 0.0
+    # Invalid input
+    assert _parse_iso_timestamp_to_ms("invalid timestamp") == 0.0
+    assert _parse_iso_timestamp_to_ms("") == 0.0
+    assert _parse_iso_timestamp_to_ms("2023-13-01T12:00:00Z") == 0.0