Skip to content

Commit d354a68

Browse files
committed
fix merge
1 parent 751a88b commit d354a68

File tree

1 file changed

+14
-45
lines changed

1 file changed

+14
-45
lines changed

tests/sentry/workflow_engine/processors/test_workflow.py

Lines changed: 14 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import pytest
55
from django.utils import timezone
66

7-
from sentry.eventstore.models import GroupEvent
87
from sentry.eventstream.base import GroupState
98
from sentry.grouping.grouptype import ErrorGroupType
109
from sentry.models.activity import Activity
@@ -442,15 +441,10 @@ def test_enqueues_workflow_all_logic_type(self) -> None:
442441

443442
process_workflows(self.event_data)
444443

445-
<<<<<<< HEAD
446-
project_ids = buffer.backend.bulk_get_sorted_set(
444+
project_ids = workflow_buffer.get_backend().bulk_get_sorted_set(
447445
self.buffer_keys,
448446
min=0,
449447
max=self.buffer_timestamp,
450-
=======
451-
project_ids = workflow_buffer.get_backend().get_sorted_set(
452-
WORKFLOW_ENGINE_BUFFER_LIST_KEY, 0, self.buffer_timestamp
453-
>>>>>>> 72e32fd402c (fixup)
454448
)
455449
assert list(project_ids.keys()) == [self.project.id]
456450

@@ -479,15 +473,10 @@ def test_enqueues_workflow_any_logic_type(self) -> None:
479473

480474
process_workflows(self.event_data)
481475

482-
<<<<<<< HEAD
483-
project_ids = buffer.backend.bulk_get_sorted_set(
476+
project_ids = workflow_buffer.get_backend().bulk_get_sorted_set(
484477
self.buffer_keys,
485478
min=0,
486479
max=self.buffer_timestamp,
487-
=======
488-
project_ids = workflow_buffer.get_backend().get_sorted_set(
489-
WORKFLOW_ENGINE_BUFFER_LIST_KEY, 0, self.buffer_timestamp
490-
>>>>>>> 72e32fd402c (fixup)
491480
)
492481
assert list(project_ids.keys()) == [self.project.id]
493482

@@ -566,15 +555,10 @@ def test_enqueues_with_when_and_if_slow_conditions(self) -> None:
566555

567556
process_workflows(self.event_data)
568557

569-
<<<<<<< HEAD
570-
project_ids = buffer.backend.bulk_get_sorted_set(
558+
project_ids = workflow_buffer.get_backend().bulk_get_sorted_set(
571559
self.buffer_keys,
572560
min=0,
573561
max=self.buffer_timestamp,
574-
=======
575-
project_ids = workflow_buffer.get_backend().get_sorted_set(
576-
WORKFLOW_ENGINE_BUFFER_LIST_KEY, 0, self.buffer_timestamp
577-
>>>>>>> 72e32fd402c (fixup)
578562
)
579563
assert list(project_ids.keys()) == [self.project.id]
580564

@@ -600,15 +584,10 @@ def test_enqueues_event_if_meets_fast_conditions(self) -> None:
600584

601585
process_workflows(self.event_data)
602586

603-
<<<<<<< HEAD
604-
project_ids = buffer.backend.bulk_get_sorted_set(
587+
project_ids = workflow_buffer.get_backend().bulk_get_sorted_set(
605588
self.buffer_keys,
606589
min=0,
607590
max=self.buffer_timestamp,
608-
=======
609-
project_ids = workflow_buffer.get_backend().get_sorted_set(
610-
WORKFLOW_ENGINE_BUFFER_LIST_KEY, 0, self.buffer_timestamp
611-
>>>>>>> 72e32fd402c (fixup)
612591
)
613592
assert not project_ids
614593

@@ -617,15 +596,10 @@ def test_enqueues_event_if_meets_fast_conditions(self) -> None:
617596

618597
process_workflows(self.event_data)
619598

620-
<<<<<<< HEAD
621-
project_ids = buffer.backend.bulk_get_sorted_set(
599+
project_ids = workflow_buffer.get_backend().bulk_get_sorted_set(
622600
self.buffer_keys,
623601
min=0,
624602
max=self.buffer_timestamp,
625-
=======
626-
project_ids = workflow_buffer.get_backend().get_sorted_set(
627-
WORKFLOW_ENGINE_BUFFER_LIST_KEY, 0, self.buffer_timestamp
628-
>>>>>>> 72e32fd402c (fixup)
629603
)
630604
assert list(project_ids.keys()) == [self.project.id]
631605

@@ -775,15 +749,10 @@ def test_enqueues_when_slow_conditions(self):
775749

776750
enqueue_workflows(queue_items)
777751

778-
<<<<<<< HEAD
779-
project_ids = buffer.backend.bulk_get_sorted_set(
752+
project_ids = workflow_buffer.get_backend().bulk_get_sorted_set(
780753
self.buffer_keys,
781754
min=0,
782755
max=timezone.now().timestamp(),
783-
=======
784-
project_ids = workflow_buffer.get_backend().get_sorted_set(
785-
WORKFLOW_ENGINE_BUFFER_LIST_KEY, 0, timezone.now().timestamp()
786-
>>>>>>> 72e32fd402c (fixup)
787756
)
788757
assert list(project_ids.keys()) == [self.project.id]
789758

@@ -819,14 +788,11 @@ def setUp(self) -> None:
819788

820789
@patch("sentry.buffer.backend.push_to_sorted_set")
821790
@patch("sentry.buffer.backend.push_to_hash_bulk")
822-
<<<<<<< HEAD
823791
@patch("random.choice")
824-
=======
825792
@override_options({"workflow_engine.buffer.use_new_buffer": False})
826-
>>>>>>> 72e32fd402c (fixup)
827793
def test_enqueue_workflows__adds_to_workflow_engine_buffer(
828794
self, mock_randchoice, mock_push_to_hash_bulk, mock_push_to_sorted_set
829-
):
795+
) -> None:
830796
mock_randchoice.return_value = f"{DelayedWorkflow.buffer_key}:{5}"
831797
enqueue_workflows(
832798
{
@@ -848,10 +814,13 @@ def test_enqueue_workflows__adds_to_workflow_engine_buffer(
848814

849815
@patch("sentry.workflow_engine.buffer._backend.push_to_sorted_set")
850816
@patch("sentry.workflow_engine.buffer._backend.push_to_hash_bulk")
817+
@patch("random.choice")
851818
@override_options({"workflow_engine.buffer.use_new_buffer": True})
852819
def test_enqueue_workflows__adds_to_workflow_engine_buffer_new_buffer(
853-
self, mock_push_to_hash_bulk, mock_push_to_sorted_set
854-
):
820+
self, mock_randchoice, mock_push_to_hash_bulk, mock_push_to_sorted_set
821+
) -> None:
822+
key_choice = f"{DelayedWorkflow.buffer_key}:{5}"
823+
mock_randchoice.return_value = key_choice
855824
enqueue_workflows(
856825
{
857826
self.workflow: DelayedWorkflowItem(
@@ -866,7 +835,7 @@ def test_enqueue_workflows__adds_to_workflow_engine_buffer_new_buffer(
866835
)
867836

868837
mock_push_to_sorted_set.assert_called_once_with(
869-
key=WORKFLOW_ENGINE_BUFFER_LIST_KEY,
838+
key=key_choice,
870839
value=[self.group_event.project_id],
871840
)
872841

@@ -875,7 +844,7 @@ def test_enqueue_workflows__adds_to_workflow_engine_buffer_new_buffer(
875844
@override_options({"workflow_engine.buffer.use_new_buffer": False})
876845
def test_enqueue_workflow__adds_to_workflow_engine_set(
877846
self, mock_push_to_hash_bulk, mock_push_to_sorted_set
878-
):
847+
) -> None:
879848
current_time = timezone.now()
880849
workflow_filter_group_2 = self.create_data_condition_group()
881850
self.create_workflow_data_condition_group(

0 commit comments

Comments
 (0)