feat(snql): Enable snql on facets performance endpoints (#30557)

* feat(snql): Enable snql on facets performance endpoints

- Histogram enabled in the histogram specific PR
- Had to remove an orderby, but it wasn't actually doing anything since
  we dropped orderbys when there are only aggregates in the selected
  columns

* fix: Need to allow additional conditions on discover.query

- This is cause there's a hardcoded condition on tags_key, and we don't
  want to allow that to be used at will by customers in our search
  syntax, otherwise this could just be appended to our query string

Author: wmak

src/sentry/api/endpoints/organization_events_facets_performance.py

@@ -73,13 +73,18 @@ def get(self, request, organization):
         if tag_key in TAG_ALIASES:
             tag_key = TAG_ALIASES.get(tag_key)
 
+        use_snql = features.has(
+            "organizations:performance-use-snql", organization, actor=request.user
+        )
+
         def data_fn(offset, limit):
             with sentry_sdk.start_span(op="discover.endpoint", description="discover_query"):
                 referrer = "api.organization-events-facets-performance.top-tags"
                 tag_data = query_tag_data(
                     filter_query=filter_query,
                     aggregate_column=aggregate_column,
                     referrer=referrer,
+                    use_snql=use_snql,
                     params=params,
                 )
 
@@ -156,6 +161,10 @@ def get(self, request, organization):
         if tag_key in TAG_ALIASES:
             tag_key = TAG_ALIASES.get(tag_key)
 
+        use_snql = features.has(
+            "organizations:performance-use-snql", organization, actor=request.user
+        )
+
         def data_fn(offset, limit, raw_limit):
             with sentry_sdk.start_span(op="discover.endpoint", description="discover_query"):
                 referrer = "api.organization-events-facets-performance-histogram"
@@ -168,6 +177,7 @@ def data_fn(offset, limit, raw_limit):
                     orderby=self.get_orderby(request),
                     offset=offset,
                     referrer=referrer,
+                    use_snql=use_snql,
                 )
 
                 if not top_tags:
@@ -182,9 +192,7 @@ def data_fn(offset, limit, raw_limit):
                     filter_query=filter_query,
                     aggregate_column=aggregate_column,
                     referrer=referrer,
-                    use_snql=features.has(
-                        "organizations:performance-use-snql", organization, actor=request.user
-                    ),
+                    use_snql=use_snql,
                     params=params,
                     limit=raw_limit,
                     num_buckets_per_key=num_buckets_per_key,
@@ -243,6 +251,7 @@ def get_result(self, limit, cursor=None):
 def query_tag_data(
     params: Mapping[str, str],
     referrer: str,
+    use_snql: bool,
     filter_query: Optional[str] = None,
     aggregate_column: Optional[str] = None,
 ) -> Optional[Dict]:
@@ -276,8 +285,8 @@ def query_tag_data(
             ],
             query=filter_query,
             params=params,
-            orderby=["-count", "tags_value"],
             referrer=f"{referrer}.all_transactions",
+            use_snql=use_snql,
             limit=1,
         )
 
@@ -300,6 +309,7 @@ def query_top_tags(
     tag_key: str,
     limit: int,
     referrer: str,
+    use_snql: bool,
     orderby: Optional[List[str]],
     offset: Optional[int] = None,
     aggregate_column: Optional[str] = None,
@@ -348,8 +358,13 @@ def query_top_tags(
                 [translated_aggregate_column, "IS NOT NULL", None],
                 ["tags_key", "IN", [tag_key]],
             ],
+            extra_snql_condition=[
+                Condition(Column(translated_aggregate_column), Op.IS_NOT_NULL),
+                Condition(Column("tags_key"), Op.EQ, tag_key),
+            ],
             functions_acl=["array_join"],
             referrer=f"{referrer}.top_tags",
+            use_snql=use_snql,
             limit=limit,
             offset=offset,
         )

src/sentry/snuba/discover.py

@@ -212,6 +212,7 @@ def query(
     auto_aggregations=False,
     use_aggregate_conditions=False,
     conditions=None,
+    extra_snql_condition=None,
     functions_acl=None,
     use_snql=False,
 ):
@@ -239,6 +240,7 @@ def query(
     use_aggregate_conditions (bool) Set to true if aggregates conditions should be used at all.
     conditions (Sequence[any]) List of conditions that are passed directly to snuba without
                     any additional processing.
+    extra_snql_condition (Sequence[Condition]) Replacement for conditions while migrating to snql
     use_snql (bool) Whether to directly build the query in snql, instead of using the older
                     json construction
     """
@@ -263,6 +265,8 @@ def query(
             limit=limit,
             offset=offset,
         )
+        if extra_snql_condition is not None:
+            builder.add_conditions(extra_snql_condition)
         snql_query = builder.get_snql_query()
 
         result = raw_snql_query(snql_query, referrer)

tests/snuba/api/endpoints/test_organization_events_facets_performance.py

@@ -263,3 +263,14 @@ def test_aggregate_zero(self):
         assert data[0]["comparison"] == 0
         assert data[0]["tags_key"] == "color"
         assert data[0]["tags_value"] == "purple"
+
+
+class OrganizationEventsFacetsPerformanceEndpointTestWithSnql(
+    OrganizationEventsFacetsPerformanceEndpointTest
+):
+    feature_list = (
+        "organizations:discover-basic",
+        "organizations:global-views",
+        "organizations:performance-view",
+        "organizations:performance-use-snql",
+    )