feat(aci): default to the error detector for grouptypes without detector (#97810)

Author: cathteng

src/sentry/workflow_engine/processors/detector.py

@@ -23,6 +23,8 @@
 
 
 def get_detector_by_event(event_data: WorkflowEventData) -> Detector:
+    from sentry.grouping.grouptype import ErrorGroupType
+
     evt = event_data.event
 
     if not isinstance(evt, GroupEvent):
@@ -33,11 +35,9 @@ def get_detector_by_event(event_data: WorkflowEventData) -> Detector:
     issue_occurrence = evt.occurrence
 
     try:
-        if issue_occurrence is None:
-            # TODO - @saponifi3d - check to see if there's a way to confirm these are for the error detector
-            detector = Detector.objects.get(
-                project_id=evt.project_id, type=evt.group.issue_type.slug
-            )
+        if issue_occurrence is None or evt.group.issue_type.detector_settings is None:
+            # if there are no detector settings, default to the error detector
+            detector = Detector.objects.get(project_id=evt.project_id, type=ErrorGroupType.slug)
         else:
             detector = Detector.objects.get(
                 id=issue_occurrence.evidence_data.get("detector_id", None)

tests/sentry/workflow_engine/processors/test_detector.py

@@ -8,6 +8,7 @@
 from django.utils import timezone
 
 from sentry.incidents.grouptype import MetricIssue
+from sentry.issues.grouptype import PerformanceNPlusOneAPICallsGroupType
 from sentry.issues.issue_occurrence import IssueOccurrence
 from sentry.issues.producer import PayloadType
 from sentry.issues.status_change_message import StatusChangeMessage
@@ -920,6 +921,33 @@ def test_no_detector_id(self) -> None:
         with pytest.raises(Detector.DoesNotExist):
             get_detector_by_event(event_data)
 
+    def test_defaults_to_error_detector(self) -> None:
+        occurrence = IssueOccurrence(
+            id=uuid.uuid4().hex,
+            project_id=self.project.id,
+            event_id="asdf",
+            fingerprint=["asdf"],
+            issue_title="title",
+            subtitle="subtitle",
+            resource_id=None,
+            evidence_data={},
+            evidence_display=[],
+            type=PerformanceNPlusOneAPICallsGroupType,
+            detection_time=timezone.now(),
+            level="error",
+            culprit="",
+        )
+
+        group_event = GroupEvent.from_event(self.event, self.group)
+        self.group.update(type=PerformanceNPlusOneAPICallsGroupType.type_id)
+        group_event.occurrence = occurrence
+
+        event_data = WorkflowEventData(event=group_event, group=self.group)
+
+        result = get_detector_by_event(event_data)
+
+        assert result == self.error_detector
+
 
 class TestGetDetectorsByGroupEventsBulk(TestCase):
     def setUp(self) -> None:

tests/sentry/workflow_engine/processors/test_workflow.py

@@ -305,6 +305,14 @@ def test_workflow_fire_history_with_action_deduping(
         assert WorkflowFireHistory.objects.count() == 3
         assert mock_trigger_action.call_count == 3
 
+    def test_defaults_to_error_workflows(self) -> None:
+        issue_occurrence = self.build_occurrence()
+        self.group_event.occurrence = issue_occurrence
+        self.group.update(type=issue_occurrence.type.type_id)
+
+        triggered_workflows = process_workflows(self.event_data)
+        assert triggered_workflows == {self.error_workflow}
+
 
 @mock_redis_buffer()
 class TestEvaluateWorkflowTriggers(BaseWorkflowTest):