Skip to content

Commit d4f8252

Browse files
asottile-sentryasottile-sentry
authored
ref: replace import_submodules with explicit * imports (#35677)
* ref: replace `import_submodules` with explicit `*` imports * re-add rules import-time side-effects for integrations
1 parent 8894343 commit d4f8252

File tree

33 files changed

+342
-122
lines changed

33 files changed

+342
-122
lines changed

‎src/sentry/analytics/events/__init__.py‎

Lines changed: 63 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,63 @@
1-
from sentry.utils.imports import import_submodules
2-
3-
import_submodules(globals(), __name__, __path__) # type: ignore
1+
from .advanced_search_feature_gated import * # noqa: F401,F403
2+
from .alert_created import * # noqa: F401,F403
3+
from .alert_edited import * # noqa: F401,F403
4+
from .alert_rule_ui_component_webhook_sent import * # noqa: F401,F403
5+
from .codeowners_assignment import * # noqa: F401,F403
6+
from .codeowners_created import * # noqa: F401,F403
7+
from .codeowners_updated import * # noqa: F401,F403
8+
from .comment_webhooks import * # noqa: F401,F403
9+
from .first_event_sent import * # noqa: F401,F403
10+
from .first_release_tag_sent import * # noqa: F401,F403
11+
from .first_sourcemaps_sent import * # noqa: F401,F403
12+
from .first_transaction_sent import * # noqa: F401,F403
13+
from .first_user_context_sent import * # noqa: F401,F403
14+
from .inapp_request import * # noqa: F401,F403
15+
from .inbox_in import * # noqa: F401,F403
16+
from .inbox_out import * # noqa: F401,F403
17+
from .integration_pipeline_step import * # noqa: F401,F403
18+
from .integration_serverless_setup import * # noqa: F401,F403
19+
from .internal_integration_created import * # noqa: F401,F403
20+
from .issue_alert_fired import * # noqa: F401,F403
21+
from .issue_assigned import * # noqa: F401,F403
22+
from .issue_deleted import * # noqa: F401,F403
23+
from .issue_ignored import * # noqa: F401,F403
24+
from .issue_mark_reviewed import * # noqa: F401,F403
25+
from .issue_resolved import * # noqa: F401,F403
26+
from .issue_tracker_used import * # noqa: F401,F403
27+
from .issue_unignored import * # noqa: F401,F403
28+
from .issue_unresolved import * # noqa: F401,F403
29+
from .issueowners_assignment import * # noqa: F401,F403
30+
from .join_request_created import * # noqa: F401,F403
31+
from .join_request_link_viewed import * # noqa: F401,F403
32+
from .manual_issue_assignment import * # noqa: F401,F403
33+
from .member_invited import * # noqa: F401,F403
34+
from .metric_alert_with_ui_component_created import * # noqa: F401,F403
35+
from .notifications_settings_updated import * # noqa: F401,F403
36+
from .onboarding_continuation_sent import * # noqa: F401,F403
37+
from .organization_created import * # noqa: F401,F403
38+
from .organization_joined import * # noqa: F401,F403
39+
from .plugin_enabled import * # noqa: F401,F403
40+
from .project_created import * # noqa: F401,F403
41+
from .project_issue_searched import * # noqa: F401,F403
42+
from .quick_trace_connected_services import * # noqa: F401,F403
43+
from .release_created import * # noqa: F401,F403
44+
from .release_get_previous_commits import * # noqa: F401,F403
45+
from .release_set_commits import * # noqa: F401,F403
46+
from .repo_linked import * # noqa: F401,F403
47+
from .search_saved import * # noqa: F401,F403
48+
from .second_platform_added import * # noqa: F401,F403
49+
from .sentry_app_created import * # noqa: F401,F403
50+
from .sentry_app_deleted import * # noqa: F401,F403
51+
from .sentry_app_installation_token_created import * # noqa: F401,F403
52+
from .sentry_app_installation_token_deleted import * # noqa: F401,F403
53+
from .sentry_app_installation_updated import * # noqa: F401,F403
54+
from .sentry_app_installed import * # noqa: F401,F403
55+
from .sentry_app_schema_validation_error import * # noqa: F401,F403
56+
from .sentry_app_token_exchanged import * # noqa: F401,F403
57+
from .sentry_app_uninstalled import * # noqa: F401,F403
58+
from .sentry_app_updated import * # noqa: F401,F403
59+
from .sentryapp_issue_webhooks import * # noqa: F401,F403
60+
from .sso_enabled import * # noqa: F401,F403
61+
from .team_created import * # noqa: F401,F403
62+
from .user_created import * # noqa: F401,F403
63+
from .user_signup import * # noqa: F401,F403

‎src/sentry/api/fields/__init__.py‎

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1-
from sentry.utils.imports import import_submodules
2-
3-
import_submodules(globals(), __name__, __path__)
1+
from .actor import * # noqa: F401,F403
2+
from .avatar import * # noqa: F401,F403
3+
from .empty_decimal import * # noqa: F401,F403
4+
from .empty_integer import * # noqa: F401,F403
5+
from .multiplechoice import * # noqa: F401,F403
6+
from .secret import * # noqa: F401,F403
7+
from .serializedfile import * # noqa: F401,F403
8+
from .user import * # noqa: F401,F403

‎src/sentry/api/serializers/models/__init__.py‎

Lines changed: 87 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,87 @@
1-
from sentry.utils.imports import import_submodules
2-
3-
import_submodules(globals(), __name__, __path__)
1+
from .activity import * # noqa: F401,F403
2+
from .actor import * # noqa: F401,F403
3+
from .alert_rule import * # noqa: F401,F403
4+
from .alert_rule_trigger import * # noqa: F401,F403
5+
from .alert_rule_trigger_action import * # noqa: F401,F403
6+
from .apiapplication import * # noqa: F401,F403
7+
from .apiauthorization import * # noqa: F401,F403
8+
from .apikey import * # noqa: F401,F403
9+
from .apitoken import * # noqa: F401,F403
10+
from .app_platform_event import * # noqa: F401,F403
11+
from .auditlogentry import * # noqa: F401,F403
12+
from .auth_provider import * # noqa: F401,F403
13+
from .authenticator import * # noqa: F401,F403
14+
from .broadcast import * # noqa: F401,F403
15+
from .commit import * # noqa: F401,F403
16+
from .dashboard import * # noqa: F401,F403
17+
from .debug_file import * # noqa: F401,F403
18+
from .deploy import * # noqa: F401,F403
19+
from .discoversavedquery import * # noqa: F401,F403
20+
from .doc_integration import * # noqa: F401,F403
21+
from .doc_integration_avatar import * # noqa: F401,F403
22+
from .environment import * # noqa: F401,F403
23+
from .event import * # noqa: F401,F403
24+
from .eventattachment import * # noqa: F401,F403
25+
from .eventuser import * # noqa: F401,F403
26+
from .exporteddata import * # noqa: F401,F403
27+
from .external_actor import * # noqa: F401,F403
28+
from .filechange import * # noqa: F401,F403
29+
from .group import * # noqa: F401,F403
30+
from .grouprelease import * # noqa: F401,F403
31+
from .groupseen import * # noqa: F401,F403
32+
from .grouptombstone import * # noqa: F401,F403
33+
from .identity import * # noqa: F401,F403
34+
from .identityprovider import * # noqa: F401,F403
35+
from .incident import * # noqa: F401,F403
36+
from .incidentactivity import * # noqa: F401,F403
37+
from .incidentseen import * # noqa: F401,F403
38+
from .integration import * # noqa: F401,F403
39+
from .integration_feature import * # noqa: F401,F403
40+
from .monitor import * # noqa: F401,F403
41+
from .monitorcheckin import * # noqa: F401,F403
42+
from .notification_setting import * # noqa: F401,F403
43+
from .organization import * # noqa: F401,F403
44+
from .organization_access_request import * # noqa: F401,F403
45+
from .organization_member.base import * # noqa: F401,F403
46+
from .organization_member.expand.projects import * # noqa: F401,F403
47+
from .organization_member.expand.roles import * # noqa: F401,F403
48+
from .organization_member.expand.teams import * # noqa: F401,F403
49+
from .organization_member.response import * # noqa: F401,F403
50+
from .organization_member.scim import * # noqa: F401,F403
51+
from .organization_member.utils import * # noqa: F401,F403
52+
from .organization_plugin import * # noqa: F401,F403
53+
from .platformexternalissue import * # noqa: F401,F403
54+
from .plugin import * # noqa: F401,F403
55+
from .processingissue import * # noqa: F401,F403
56+
from .project import * # noqa: F401,F403
57+
from .project_key import * # noqa: F401,F403
58+
from .project_platform import * # noqa: F401,F403
59+
from .project_transaction_threshold import * # noqa: F401,F403
60+
from .projectcodeowners import * # noqa: F401,F403
61+
from .projectownership import * # noqa: F401,F403
62+
from .pullrequest import * # noqa: F401,F403
63+
from .recentsearch import * # noqa: F401,F403
64+
from .relay import * # noqa: F401,F403
65+
from .relayusage import * # noqa: F401,F403
66+
from .release import * # noqa: F401,F403
67+
from .release_file import * # noqa: F401,F403
68+
from .repository import * # noqa: F401,F403
69+
from .repository_project_path_config import * # noqa: F401,F403
70+
from .role import * # noqa: F401,F403
71+
from .rule import * # noqa: F401,F403
72+
from .savedsearch import * # noqa: F401,F403
73+
from .sentry_app import * # noqa: F401,F403
74+
from .sentry_app_avatar import * # noqa: F401,F403
75+
from .sentry_app_component import * # noqa: F401,F403
76+
from .sentry_app_installation import * # noqa: F401,F403
77+
from .servicehook import * # noqa: F401,F403
78+
from .tagvalue import * # noqa: F401,F403
79+
from .team import * # noqa: F401,F403
80+
from .user import * # noqa: F401,F403
81+
from .user_identity_config import * # noqa: F401,F403
82+
from .user_notifications import * # noqa: F401,F403
83+
from .user_social_auth import * # noqa: F401,F403
84+
from .useremail import * # noqa: F401,F403
85+
from .userip import * # noqa: F401,F403
86+
from .userreport import * # noqa: F401,F403
87+
from .userrole import * # noqa: F401,F403

‎src/sentry/api/serializers/rest_framework/__init__.py‎

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1-
from sentry.utils.imports import import_submodules
2-
3-
import_submodules(globals(), __name__, __path__)
1+
from .base import * # noqa: F401,F403
2+
from .commit import * # noqa: F401,F403
3+
from .dashboard import * # noqa: F401,F403
4+
from .doc_integration import * # noqa: F401,F403
5+
from .environment import * # noqa: F401,F403
6+
from .group_notes import * # noqa: F401,F403
7+
from .json import * # noqa: F401,F403
8+
from .list import * # noqa: F401,F403
9+
from .mentions import * # noqa: F401,F403
10+
from .origin import * # noqa: F401,F403
11+
from .project import * # noqa: F401,F403
12+
from .project_key import * # noqa: F401,F403
13+
from .release import * # noqa: F401,F403
14+
from .rule import * # noqa: F401,F403
15+
from .sentry_app import * # noqa: F401,F403
16+
from .sentry_app_installation import * # noqa: F401,F403
17+
from .sentry_app_request import * # noqa: F401,F403

‎src/sentry/api/validators/__init__.py‎

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
1-
# XXX(dcramer): we don't use rest framework's serializers module for actual serialization,
2-
# but rather we use it for validation. Consider this the appropriate place to put these
3-
# components going forward, though many live in sentry/api/serializers/rest_framework for
4-
# legacy reasons.
5-
6-
from sentry.utils.imports import import_submodules
7-
8-
import_submodules(globals(), __name__, __path__)
1+
from .auth import * # noqa: F401,F403
2+
from .broadcast import * # noqa: F401,F403
3+
from .doc_integration import * # noqa: F401,F403
4+
from .email import * # noqa: F401,F403
5+
from .external_actor import * # noqa: F401,F403
6+
from .integrations import * # noqa: F401,F403
7+
from .monitor import * # noqa: F401,F403
8+
from .notifications import * # noqa: F401,F403
9+
from .project_codeowners import * # noqa: F401,F403
10+
from .sentry_apps.schema import * # noqa: F401,F403
11+
from .servicehook import * # noqa: F401,F403
12+
from .userrole import * # noqa: F401,F403

‎src/sentry/deletions/defaults/__init__.py‎

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
1-
from sentry.utils.imports import import_submodules
2-
3-
import_submodules(globals(), __name__, __path__)
1+
from .alertrule import * # noqa: F401,F403
2+
from .apiapplication import * # noqa: F401,F403
3+
from .commit import * # noqa: F401,F403
4+
from .commitauthor import * # noqa: F401,F403
5+
from .discoversavedquery import * # noqa: F401,F403
6+
from .group import * # noqa: F401,F403
7+
from .organization import * # noqa: F401,F403
8+
from .organizationintegration import * # noqa: F401,F403
9+
from .project import * # noqa: F401,F403
10+
from .release import * # noqa: F401,F403
11+
from .repository import * # noqa: F401,F403
12+
from .repositoryprojectpathconfig import * # noqa: F401,F403
13+
from .team import * # noqa: F401,F403

‎src/sentry/identity/bitbucket/__init__.py‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
1-
from sentry.utils.imports import import_submodules
2-
3-
import_submodules(globals(), __name__, __path__)
1+
from .provider import * # noqa: F401,F403

‎src/sentry/identity/github/__init__.py‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
1-
from sentry.utils.imports import import_submodules
2-
3-
import_submodules(globals(), __name__, __path__)
1+
from .provider import * # noqa: F401,F403

‎src/sentry/identity/github_enterprise/__init__.py‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
1-
from sentry.utils.imports import import_submodules
2-
3-
import_submodules(globals(), __name__, __path__)
1+
from .provider import * # noqa: F401,F403

‎src/sentry/identity/gitlab/__init__.py‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
1-
from sentry.utils.imports import import_submodules
2-
3-
import_submodules(globals(), __name__, __path__)
1+
from .provider import * # noqa: F401,F403

0 commit comments

Comments
 (0)