Skip to content

Commit d64f477

Browse files
authored
feat(ui): Add empty state for for review tab (#31782)
1 parent 7d55665 commit d64f477

File tree

2 files changed

+35
-8
lines changed

2 files changed

+35
-8
lines changed

static/app/views/issueList/noGroupsHandler/index.tsx

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import Placeholder from 'sentry/components/placeholder';
77
import {DEFAULT_QUERY} from 'sentry/constants';
88
import {t} from 'sentry/locale';
99
import {Organization, Project} from 'sentry/types';
10+
import {Query} from 'sentry/views/issueList/utils';
1011

1112
import NoUnresolvedIssues from './noUnresolvedIssues';
1213

@@ -150,7 +151,23 @@ class NoGroupsHandler extends React.Component<Props, State> {
150151
return this.renderAwaitingEvents(firstEventProjects);
151152
}
152153
if (query === DEFAULT_QUERY) {
153-
return <NoUnresolvedIssues />;
154+
return (
155+
<NoUnresolvedIssues
156+
title={t("We couldn't find any issues that matched your filters.")}
157+
subtitle={t('Get out there and write some broken code!')}
158+
/>
159+
);
160+
}
161+
162+
if (query === Query.FOR_REVIEW) {
163+
return (
164+
<NoUnresolvedIssues
165+
title={t('Well, would you look at that.')}
166+
subtitle={t(
167+
'No more issues to review. Better get back out there and write some broken code.'
168+
)}
169+
/>
170+
);
154171
}
155172

156173
return this.renderEmpty();

static/app/views/issueList/noGroupsHandler/noUnresolvedIssues.tsx

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,16 @@ const Placeholder = () => (
1313
/>
1414
);
1515

16-
const Message = () => (
16+
const Message = ({
17+
title,
18+
subtitle,
19+
}: {
20+
subtitle: React.ReactNode;
21+
title: React.ReactNode;
22+
}) => (
1723
<React.Fragment>
18-
<EmptyMessage>
19-
{t("We couldn't find any issues that matched your filters.")}
20-
</EmptyMessage>
21-
<p>{t('Get out there and write some broken code!')}</p>
24+
<EmptyMessage>{title}</EmptyMessage>
25+
<p>{subtitle}</p>
2226
</React.Fragment>
2327
);
2428

@@ -53,14 +57,20 @@ class ErrorBoundary extends React.Component<{children: React.ReactNode}, State>
5357
}
5458
}
5559

56-
const NoUnresolvedIssues = () => (
60+
const NoUnresolvedIssues = ({
61+
title,
62+
subtitle,
63+
}: {
64+
subtitle: React.ReactNode;
65+
title: React.ReactNode;
66+
}) => (
5767
<Wrapper>
5868
<ErrorBoundary>
5969
<React.Suspense fallback={<Placeholder />}>
6070
<CongratsRobotsVideo />
6171
</React.Suspense>
6272
</ErrorBoundary>
63-
<Message />
73+
<Message title={title} subtitle={subtitle} />
6474
</Wrapper>
6575
);
6676

0 commit comments

Comments
 (0)