Skip to content

Commit d8848b3

Browse files
shayna-chpriscilawebdev
authored andcommitted
ref(groupingInfo): Hide client fingerprint in Contributing Values view if it doesn't contribute (#97904)
1 parent ef4887b commit d8848b3

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

static/app/components/events/groupingInfo/groupingVariant.tsx

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,11 @@ interface GroupingVariantProps {
2626

2727
type VariantData = Array<[string, React.ReactNode]>;
2828

29-
function addFingerprintInfo(data: VariantData, variant: EventGroupVariant) {
29+
function addFingerprintInfo(
30+
data: VariantData,
31+
variant: EventGroupVariant,
32+
showNonContributing: boolean
33+
) {
3034
if ('matched_rule' in variant) {
3135
data.push([
3236
t('Fingerprint rule'),
@@ -48,7 +52,10 @@ function addFingerprintInfo(data: VariantData, variant: EventGroupVariant) {
4852
</TextWithQuestionTooltip>,
4953
]);
5054
}
51-
if ('client_values' in variant) {
55+
if (
56+
'client_values' in variant &&
57+
(showNonContributing || !('matched_rule' in variant))
58+
) {
5259
data.push([
5360
t('Client fingerprint values'),
5461
<TextWithQuestionTooltip key="type">
@@ -102,14 +109,14 @@ function GroupingVariant({event, variant, showNonContributing}: GroupingVariantP
102109
component = variant.component;
103110
break;
104111
case EventGroupVariantType.CUSTOM_FINGERPRINT:
105-
addFingerprintInfo(data, variant);
112+
addFingerprintInfo(data, variant, showNonContributing);
106113
break;
107114
case EventGroupVariantType.BUILT_IN_FINGERPRINT:
108-
addFingerprintInfo(data, variant);
115+
addFingerprintInfo(data, variant, showNonContributing);
109116
break;
110117
case EventGroupVariantType.SALTED_COMPONENT:
111118
component = variant.component;
112-
addFingerprintInfo(data, variant);
119+
addFingerprintInfo(data, variant, showNonContributing);
113120
break;
114121
case EventGroupVariantType.PERFORMANCE_PROBLEM: {
115122
const spansToHashes = Object.fromEntries(

0 commit comments

Comments
 (0)