Skip to content

Commit d924ee6

Browse files
authored
feat(insights): set sampling mode widget queries (#90821)
set sampling mode to normal in eap widgets
1 parent 607a32b commit d924ee6

File tree

4 files changed

+17
-5
lines changed

4 files changed

+17
-5
lines changed

static/app/views/performance/landing/widgets/widgets/lineChartListWidget.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ import {
6666
TOTAL_EXPANDABLE_ROWS_HEIGHT,
6767
} from 'sentry/views/performance/landing/widgets/utils';
6868
import {PerformanceWidgetSetting} from 'sentry/views/performance/landing/widgets/widgetDefinitions';
69+
import {EAP_QUERY_PARAMS} from 'sentry/views/performance/landing/widgets/widgets/settings';
6970
import {transactionSummaryRouteWithQuery} from 'sentry/views/performance/transactionSummary/utils';
7071
import {
7172
createUnnamedTransactionsDiscoverTarget,
@@ -117,11 +118,11 @@ export function LineChartListWidget(props: PerformanceWidgetProps) {
117118
const metricsDataset = useEap ? DiscoverDatasets.SPANS_EAP : DiscoverDatasets.METRICS;
118119

119120
const spanQueryParams: Record<string, string> = useEap
120-
? {useRpc: '1', dataset: DiscoverDatasets.SPANS_EAP}
121+
? {...EAP_QUERY_PARAMS}
121122
: {dataset: DiscoverDatasets.SPANS_METRICS};
122123

123124
const metricsQueryParams: Record<string, string> = useEap
124-
? {useRpc: '1', dataset: DiscoverDatasets.SPANS_EAP}
125+
? {...EAP_QUERY_PARAMS}
125126
: {dataset: DiscoverDatasets.METRICS};
126127

127128
let emptyComponent: any;

static/app/views/performance/landing/widgets/widgets/mobileReleaseComparisonListWidget.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ import {
5656
TOTAL_EXPANDABLE_ROWS_HEIGHT,
5757
} from 'sentry/views/performance/landing/widgets/utils';
5858
import {PerformanceWidgetSetting} from 'sentry/views/performance/landing/widgets/widgetDefinitions';
59+
import {EAP_QUERY_PARAMS} from 'sentry/views/performance/landing/widgets/widgets/settings';
5960
import {Subtitle} from 'sentry/views/profiling/landing/styles';
6061
import {RightAlignedCell} from 'sentry/views/replays/deadRageClick/deadRageSelectorCards';
6162

@@ -119,7 +120,7 @@ function MobileReleaseComparisonListWidget(props: PerformanceWidgetProps) {
119120
: DiscoverDatasets.SPANS_METRICS;
120121

121122
const queryParams: Record<string, string> = useEap
122-
? {useRpc: '1', dataset: DiscoverDatasets.SPANS_EAP}
123+
? {...EAP_QUERY_PARAMS}
123124
: {dataset: DiscoverDatasets.SPANS_METRICS};
124125

125126
const segmentOp = useEap ? 'span.op' : 'transaction.op';
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
import {DiscoverDatasets} from 'sentry/utils/discover/types';
2+
import {DEFAULT_SAMPLING_MODE} from 'sentry/views/insights/common/queries/useDiscover';
3+
4+
export const EAP_QUERY_PARAMS = {
5+
dataset: DiscoverDatasets.SPANS_EAP,
6+
sampling: DEFAULT_SAMPLING_MODE,
7+
};

static/app/views/performance/landing/widgets/widgets/singleFieldAreaWidget.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import {t} from 'sentry/locale';
88
import {axisLabelFormatter} from 'sentry/utils/discover/charts';
99
import DiscoverQuery from 'sentry/utils/discover/discoverQuery';
1010
import {aggregateOutputType} from 'sentry/utils/discover/fields';
11-
import {DiscoverDatasets} from 'sentry/utils/discover/types';
1211
import type {Transform} from 'sentry/utils/performance/contexts/genericQueryBatcher';
1312
import {QueryBatchNode} from 'sentry/utils/performance/contexts/genericQueryBatcher';
1413
import {useMEPSettingContext} from 'sentry/utils/performance/contexts/metricsEnhancedSetting';
@@ -30,6 +29,7 @@ import {
3029
getMEPQueryParams,
3130
QUERY_LIMIT_PARAM,
3231
} from 'sentry/views/performance/landing/widgets/utils';
32+
import {EAP_QUERY_PARAMS} from 'sentry/views/performance/landing/widgets/widgets/settings';
3333

3434
type DataType = {
3535
chart: WidgetDataResult & ReturnType<typeof transformEventsRequestToArea>;
@@ -45,7 +45,10 @@ export function SingleFieldAreaWidget(props: PerformanceWidgetProps) {
4545
const useEap = useInsightsEap();
4646

4747
const queryExtras = useEap
48-
? {...getMEPQueryParams(mepSetting), useRpc: '1', dataset: DiscoverDatasets.SPANS_EAP}
48+
? {
49+
...getMEPQueryParams(mepSetting),
50+
...EAP_QUERY_PARAMS,
51+
}
4952
: getMEPQueryParams(mepSetting);
5053

5154
if (props.fields.length !== 1) {

0 commit comments

Comments
 (0)