de-dupe type definitions

Author: ryan953

static/app/components/replays/breadcrumbs/errorTitle.tsx

@@ -16,7 +16,7 @@ export default function CrumbErrorTitle({frame}: {frame: ErrorFrame}) {
 
   return (
     <Fragment>
-      {frame.data.level ?? 'Error'}:{' '}
+      {frame.data.level || 'Error'}:{' '}
       <Link
         to={`/organizations/${organization.slug}/issues/${frame.data.groupId}/events/${frame.data.eventId}/#replay`}
       >

static/app/utils/replays/hooks/useReplayData.tsx

@@ -11,8 +11,9 @@ import {useApiQuery, useQueryClient} from 'sentry/utils/queryClient';
 import useFeedbackEvents from 'sentry/utils/replays/hooks/useFeedbackEvents';
 import {useReplayProjectSlug} from 'sentry/utils/replays/hooks/useReplayProjectSlug';
 import {mapResponseToReplayRecord} from 'sentry/utils/replays/replayDataUtils';
+import type {RawReplayError} from 'sentry/utils/replays/types';
 import type RequestError from 'sentry/utils/requestError/requestError';
-import type {ReplayError, ReplayRecord} from 'sentry/views/replays/types';
+import type {ReplayRecord} from 'sentry/views/replays/types';
 
 type Options = {
   /**
@@ -41,7 +42,7 @@ type Options = {
 interface Result {
   attachmentError: undefined | RequestError[];
   attachments: unknown[];
-  errors: ReplayError[];
+  errors: RawReplayError[];
   fetchError: undefined | RequestError;
   isError: boolean;
   isPending: boolean;
@@ -200,7 +201,7 @@ function useReplayData({
     pages: errorPages,
     status: fetchErrorsStatus,
     getLastResponseHeader: lastErrorsResponseHeader,
-  } = useFetchParallelPages<{data: ReplayError[]}>({
+  } = useFetchParallelPages<{data: RawReplayError[]}>({
     enabled: enableErrors,
     hits: replayRecord?.count_errors ?? 0,
     getQueryKey: getErrorsQueryKey,
@@ -214,15 +215,15 @@ function useReplayData({
     (!replayRecord?.count_errors || Boolean(links.next?.results)) &&
     fetchErrorsStatus === 'success';
   const {pages: extraErrorPages, status: fetchExtraErrorsStatus} =
-    useFetchSequentialPages<{data: ReplayError[]}>({
+    useFetchSequentialPages<{data: RawReplayError[]}>({
       enabled: enableExtraErrors,
       initialCursor: links.next?.cursor,
       getQueryKey: getErrorsQueryKey,
       perPage: errorsPerPage,
     });
 
   const {pages: platformErrorPages, status: fetchPlatformErrorsStatus} =
-    useFetchSequentialPages<{data: ReplayError[]}>({
+    useFetchSequentialPages<{data: RawReplayError[]}>({
       enabled: true,
       getQueryKey: getPlatformErrorsQueryKey,
       perPage: errorsPerPage,

static/app/utils/replays/replayReader.tsx

@@ -30,6 +30,7 @@ import type {
   incrementalSnapshotEvent,
   MemoryFrame,
   OptionFrame,
+  RawReplayError,
   RecordingFrame,
   ReplayFrame,
   serializedNodeWithId,
@@ -54,7 +55,7 @@ import {
   isWebVitalFrame,
   NodeType,
 } from 'sentry/utils/replays/types';
-import type {HydratedReplayRecord, ReplayError} from 'sentry/views/replays/types';
+import type {HydratedReplayRecord} from 'sentry/views/replays/types';
 
 interface ReplayReaderParams {
   /**
@@ -71,7 +72,7 @@ interface ReplayReaderParams {
    * Error instances could be frontend, backend, or come from the error platform
    * like performance-errors or replay-errors
    */
-  errors: ReplayError[] | undefined;
+  errors: RawReplayError[] | undefined;
 
   /**
    * Is replay data still fetching?

static/app/views/replays/types.tsx

@@ -299,20 +299,6 @@ export type ReplayListRecord = Pick<
   | 'warning_ids'
 >;
 
-/**
- * This is a result of a custom discover query
- */
-export interface ReplayError {
-  ['error.type']: string[];
-  ['error.value']: string[]; // deprecated, use title instead. See organization_replay_events_meta.py
-  id: string;
-  issue: string;
-  ['issue.id']: number;
-  ['project.name']: string;
-  timestamp: string;
-  title: string;
-}
-
 export type DeadRageSelectorItem = {
   aria_label: string;
   dom_element: {