Skip to content

Commit dfbfcd7

Browse files
authored
feat(eap): Always log the rpc query instead of only at debug (#103922)
- Gonna just try this out, we'll keep an eye on how much we're sending and tune it accordingly
1 parent 26ae7c5 commit dfbfcd7

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

src/sentry/snuba/rpc_dataset_common.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -334,8 +334,7 @@ def _run_table_query(
334334
"""Run the query"""
335335
table_request = cls.get_table_rpc_request(query)
336336
rpc_request = table_request.rpc_request
337-
if debug:
338-
log_rpc_request("Running a table query with debug on", rpc_request)
337+
log_rpc_request("Running a table query with debug on", rpc_request)
339338
try:
340339
rpc_response = snuba_rpc.table_rpc([rpc_request])[0]
341340
except Exception as e:
@@ -545,8 +544,7 @@ def update_timestamps(
545544
def _run_timeseries_rpc(
546545
self, debug: bool, rpc_request: TimeSeriesRequest
547546
) -> TimeSeriesResponse:
548-
if debug:
549-
log_rpc_request("Running a timeseries query with debug on", rpc_request)
547+
log_rpc_request("Running a timeseries query with debug on", rpc_request)
550548
try:
551549
return snuba_rpc.timeseries_rpc([rpc_request])[0]
552550
except Exception as e:
@@ -809,9 +807,8 @@ def run_top_events_timeseries_query(
809807
requests.append(other_request)
810808

811809
"""Run the query"""
812-
if params.debug:
813-
for rpc_request in requests:
814-
log_rpc_request("Running a top events query with debug on", rpc_request)
810+
for rpc_request in requests:
811+
log_rpc_request("Running a top events query with debug on", rpc_request)
815812
try:
816813
timeseries_rpc_response = snuba_rpc.timeseries_rpc(requests)
817814
rpc_response = timeseries_rpc_response[0]

0 commit comments

Comments
 (0)