Skip to content

Commit e3bac2c

Browse files
authored
feat(workflow): Enable issue-percent-filters flag by default (#29325)
1 parent 7997cb9 commit e3bac2c

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

src/sentry/conf/server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1076,7 +1076,7 @@ def create_partitioned_queues(name):
10761076
# Return unhandled information on the issue level
10771077
"organizations:unhandled-issue-flag": True,
10781078
# Enable percent-based conditions on issue rules
1079-
"organizations:issue-percent-filters": False,
1079+
"organizations:issue-percent-filters": True,
10801080
# Enable the new alert details ux design
10811081
"organizations:alert-details-redesign": True,
10821082
# Enable the new images loaded design and features

tests/sentry/api/endpoints/test_project_agnostic_rule_conditions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ def test_simple(self):
1111
response = self.client.get(url, format="json")
1212

1313
assert response.status_code == 200, response.content
14-
assert len(response.data) == 9
14+
assert len(response.data) == 10
1515

1616
def test_percent_condition_flag(self):
1717
self.login_as(user=self.user)

tests/sentry/api/endpoints/test_project_rules_configuration.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def test_simple(self):
2222

2323
response = self.get_valid_response(self.organization.slug, project1.slug)
2424
assert len(response.data["actions"]) == 7
25-
assert len(response.data["conditions"]) == 6
25+
assert len(response.data["conditions"]) == 7
2626
assert len(response.data["filters"]) == 7
2727

2828
@property
@@ -159,7 +159,7 @@ def test_sentry_app_alertable_webhook(self):
159159
"service": {"type": "choice", "choices": [[sentry_app.slug, sentry_app.name]]}
160160
},
161161
} in response.data["actions"]
162-
assert len(response.data["conditions"]) == 6
162+
assert len(response.data["conditions"]) == 7
163163
assert len(response.data["filters"]) == 7
164164

165165
@patch("sentry.mediators.sentry_app_components.Preparer.run")
@@ -190,5 +190,5 @@ def test_sentry_app_alert_rules(self, mock_sentry_app_components_preparer):
190190
"formFields": settings_schema["settings"],
191191
"sentryAppInstallationUuid": str(install.uuid),
192192
} in response.data["actions"]
193-
assert len(response.data["conditions"]) == 6
193+
assert len(response.data["conditions"]) == 7
194194
assert len(response.data["filters"]) == 7

tests/sentry/api/serializers/test_organization.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ def test_simple(self):
3838
"integrations-ticket-rules",
3939
"invite-members",
4040
"invite-members-rate-limits",
41+
"issue-percent-filters",
4142
"open-membership",
4243
"performance-tag-page",
4344
"performance-tag-explorer",

0 commit comments

Comments
 (0)