chore(attr breakdowns): Clean up calling the RRF function (#106118)

- Stop calling the RRF scorer
- Requires followup with the frontend and then a backend PR to make sure
RRR changes are still being used properly without breaking anything else
in the cleanup

Author: aayush-se

src/sentry/api/endpoints/organization_trace_item_attributes_ranked.py

@@ -30,7 +30,6 @@
 from sentry.search.eap.utils import can_expose_attribute, translate_internal_to_public_alias
 from sentry.search.events import fields
 from sentry.seer.endpoints.compare import compare_distributions
-from sentry.seer.workflows.compare import keyed_rrf_score
 from sentry.snuba.referrer import Referrer
 from sentry.snuba.spans_rpc import Spans
 from sentry.utils import snuba_rpc
@@ -306,13 +305,6 @@ def run_table_query_with_error_handling(query_string):
         )
         total_baseline = total_spans - total_outliers
 
-        scored_attrs_rrf = keyed_rrf_score(
-            baseline=cohort_2_distribution,
-            outliers=cohort_1_distribution,
-            total_outliers=total_outliers,
-            total_baseline=total_baseline,
-        )
-
         logger.info(
             "compare_distributions params: baseline=%s, outliers=%s, total_outliers=%s, total_baseline=%s, config=%s, meta=%s",
             cohort_2_distribution,
@@ -338,10 +330,7 @@ def run_table_query_with_error_handling(query_string):
         )
         logger.info("scored_attrs_rrr: %s", scored_attrs_rrr)
 
-        # Create RRR order mapping from compare_distributions results
-        # scored_attrs_rrr returns a dict with 'results' key containing list of [attribute_name, score] pairs
         rrr_results = scored_attrs_rrr.get("results", [])
-        rrr_order_map = {attr_name: i for i, (attr_name, _) in enumerate(rrr_results)}
 
         ranked_distribution: dict[str, Any] = {
             "rankedAttributes": [],
@@ -354,9 +343,7 @@ def run_table_query_with_error_handling(query_string):
             "cohort2Total": total_baseline,
         }
 
-        for i, scored_attr_tuple in enumerate(scored_attrs_rrf):
-            attr = scored_attr_tuple[0]
-
+        for i, (attr, _) in enumerate(rrr_results):
             public_alias, _, _ = translate_internal_to_public_alias(
                 attr, "string", SupportedTraceItemType.SPANS
             )
@@ -371,10 +358,8 @@ def run_table_query_with_error_handling(query_string):
                     "attributeName": public_alias,
                     "cohort1": cohort_1_distribution_map.get(attr),
                     "cohort2": cohort_2_distribution_map.get(attr),
-                    "order": {  # TODO: aayush-se remove this once we have selected a single ranking method
-                        "rrf": i,
-                        "rrr": rrr_order_map.get(attr),
-                    },
+                    # TODO(aayush-se): Remove order field once frontend stops using it
+                    "order": {"rrr": i},
                 }
                 ranked_distribution["rankedAttributes"].append(distribution)
 

tests/snuba/api/endpoints/test_organization_trace_item_attributes_ranked.py

@@ -160,29 +160,23 @@ def test_function_with_multiple_arguments(self, mock_compare_distributions) -> N
         assert "rankedAttributes" in response.data
 
     @patch("sentry.api.endpoints.organization_trace_item_attributes_ranked.compare_distributions")
-    @patch("sentry.api.endpoints.organization_trace_item_attributes_ranked.keyed_rrf_score")
     def test_baseline_distribution_includes_baseline_only_buckets(
-        self, mock_keyed_rrf_score, mock_compare_distributions
+        self, mock_compare_distributions
     ) -> None:
         """Test that buckets existing only in baseline (not in suspect) are included in scoring.
 
         This specifically tests the fix for the bug where attribute values that exist
         in all spans but NOT in the suspect cohort were missing from the baseline
         distribution passed to scoring algorithms.
         """
-        # Capture what's passed to the scoring functions
+        # Capture what's passed to compare_distributions
         captured_baseline = None
 
-        def capture_baseline(*args, **kwargs):
+        def capture_compare(*args, **kwargs):
             nonlocal captured_baseline
             captured_baseline = kwargs.get("baseline")
-            # Return results matching the actual internal attribute names
-            return [("sentry.browser", 1.0), ("sentry.device", 0.8)]
-
-        def capture_compare(*args, **kwargs):
             return {"results": [("sentry.browser", 0.9), ("sentry.device", 0.7)]}
 
-        mock_keyed_rrf_score.side_effect = capture_baseline
         mock_compare_distributions.side_effect = capture_compare
 
         tags = [
@@ -292,12 +286,11 @@ def test_filters_out_internal_and_private_attributes(self, mock_compare_distribu
             ), f"Attribute '{attr_name}' should be filtered (meta attribute)"
 
     @patch("sentry.api.endpoints.organization_trace_item_attributes_ranked.compare_distributions")
-    @patch("sentry.api.endpoints.organization_trace_item_attributes_ranked.keyed_rrf_score")
     @patch(
         "sentry.api.endpoints.organization_trace_item_attributes_ranked.translate_internal_to_public_alias"
     )
     def test_includes_user_defined_attributes_when_translate_returns_none(
-        self, mock_translate, mock_keyed_rrf_score, mock_compare_distributions
+        self, mock_translate, mock_compare_distributions
     ) -> None:
         """Test that user-defined attributes are included when translate_internal_to_public_alias returns None.
 
@@ -316,14 +309,7 @@ def mock_translate_func(attr, *_):
 
         mock_translate.side_effect = mock_translate_func
 
-        # Mock primary scoring (keyed_rrf_score) to include our test attributes
-        mock_keyed_rrf_score.return_value = [
-            ("custom_user_attr", 0.9),
-            ("tags[filtered_tag]", 0.8),
-            ("regular_attr", 0.7),
-        ]
-
-        # Mock secondary scoring for RRR ordering
+        # Mock compare_distributions to return our test attributes (now the primary scoring)
         mock_compare_distributions.return_value = {
             "results": [
                 ("custom_user_attr", 0.9),