Skip to content

Commit ee1f6cd

Browse files
committed
remove unnecessary change; fix in default org settings
1 parent f1ffd2b commit ee1f6cd

File tree

2 files changed

+7
-13
lines changed

2 files changed

+7
-13
lines changed

static/gsApp/views/seerAutomation/components/repoDetails/repoDetailsForm.tsx

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,6 @@ interface Props {
1818
export default function RepoDetailsForm({organization, repoWithSettings}: Props) {
1919
const canWrite = useCanWriteSettings();
2020

21-
const initialTriggers =
22-
repoWithSettings?.settings?.codeReviewTriggers ??
23-
organization.defaultCodeReviewTriggers ??
24-
DEFAULT_CODE_REVIEW_TRIGGERS;
25-
26-
const modifiableInitialTriggers = initialTriggers.filter(
27-
trigger => trigger !== 'on_command_phrase'
28-
);
29-
3021
return (
3122
<Form
3223
allowUndo
@@ -39,7 +30,10 @@ export default function RepoDetailsForm({organization, repoWithSettings}: Props)
3930
repoWithSettings?.settings?.enabledCodeReview ??
4031
organization.autoEnableCodeReview ??
4132
true,
42-
codeReviewTriggers: modifiableInitialTriggers,
33+
codeReviewTriggers:
34+
repoWithSettings?.settings?.codeReviewTriggers ??
35+
organization.defaultCodeReviewTriggers ??
36+
DEFAULT_CODE_REVIEW_TRIGGERS,
4337
repositoryIds: [repoWithSettings.id],
4438
} satisfies RepositorySettings
4539
}

static/gsApp/views/seerAutomation/settings.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,13 +98,13 @@ export default function SeerAutomationSettings() {
9898
{
9999
name: 'defaultCodeReviewTriggers',
100100
label: t('Code Review Triggers'),
101-
help: t(
102-
'Reviews can run on demand, whenever a PR is opened, or after each commit is pushed to a PR.'
101+
help: tct(
102+
'Reviews can always run on demand by calling [code:@sentry review], whenever a PR is opened, or after each commit is pushed to a PR.',
103+
{code: <code />}
103104
),
104105
type: 'choice',
105106
multiple: true,
106107
choices: [
107-
['on_command_phrase', t('On Command Phrase')],
108108
['on_ready_for_review', t('On Ready for Review')],
109109
['on_new_commit', t('On New Commit')],
110110
],

0 commit comments

Comments
 (0)