options: move to memcached instead of default redis cache

I don't think I consciously made a decision to use Redis or not, but
it's more favorable to use Memcached for this for sure.

Author: mattrobenolt

src/sentry/options/store.py

@@ -101,9 +101,10 @@ def get_cache(self, key, silent=False):
             if not silent:
                 logger.warn(CACHE_FETCH_ERR, key.name, exc_info=True)
             value = None
-        else:
-            if key.ttl > 0:
-                self._local_cache[cache_key] = _make_cache_value(key, value)
+
+        if value is not None and key.ttl > 0:
+            self._local_cache[cache_key] = _make_cache_value(key, value)
+
         return value
 
     def get_local_cache(self, key, force_grace=False):

src/sentry/runner/initializer.py

@@ -362,7 +362,7 @@ def bind_cache_to_option_store():
     # settings and/or configuration values. Those options should have been
     # loaded at this point, so we can plug in the cache backend before
     # continuing to initialize the remainder of the application.
-    from sentry.cache import default_cache
+    from django.core.cache import cache as default_cache
     from sentry.options import default_store
 
     default_store.cache = default_cache

tests/sentry/options/test_manager.py

@@ -5,8 +5,8 @@
 from exam import fixture, around
 from mock import patch
 from django.conf import settings
+from django.core.cache.backends.locmem import LocMemCache
 
-from sentry.cache.redis import RedisCache
 from sentry.models import Option
 from sentry.options.store import OptionsStore
 from sentry.options.manager import (
@@ -19,9 +19,9 @@
 class OptionsManagerTest(TestCase):
     @fixture
     def store(self):
-        return OptionsStore(
-            cache=RedisCache()
-        )
+        c = LocMemCache('test', {})
+        c.clear()
+        return OptionsStore(cache=c)
 
     @fixture
     def manager(self):

tests/sentry/options/test_store.py

@@ -7,8 +7,8 @@
 import pytest
 from exam import before, fixture
 from mock import patch
+from django.core.cache.backends.locmem import LocMemCache
 
-from sentry.cache.redis import RedisCache
 from sentry.models import Option
 from sentry.options.store import OptionsStore
 from sentry.testutils import TestCase
@@ -17,9 +17,9 @@
 class OptionsStoreTest(TestCase):
     @fixture
     def store(self):
-        return OptionsStore(
-            cache=RedisCache()
-        )
+        c = LocMemCache('test', {})
+        c.clear()
+        return OptionsStore(cache=c)
 
     @fixture
     def key(self):