fix(autofix): Identify profiles by transaction name instead of span id (#97528)

Use a looser matching condition to find profiles. I think the spans
dataset does not include error spans, breaking the old logic.

Also refactor the profile fetching RPC tool to use the shared util and
support continuous profiles.

Author: roaga

src/sentry/seer/autofix/autofix.py

@@ -488,6 +488,7 @@ def find_transaction_parent(span_id: str) -> str | None:
             event_node.update(
                 {
                     "title": f"{op} - {transaction_title}" if op else transaction_title,
+                    "transaction": transaction_title,
                     "duration": duration_str,
                     "profile_id": profile_id,
                     "span_ids": span_ids,  # Store for later use
@@ -629,9 +630,9 @@ def _get_profile_from_trace_tree(
         return None
 
     events = trace_tree.get("events", [])
-    event_span_id = event.data.get("contexts", {}).get("trace", {}).get("span_id")
+    event_transaction_name = event.transaction
 
-    if not event_span_id:
+    if not event_transaction_name:
         return None
 
     # Flatten all events in the tree for easier traversal
@@ -645,18 +646,11 @@ def collect_all_events(node):
     for root_node in events:
         collect_all_events(root_node)
 
-    # Find the first transaction that contains the event's span ID
-    # or has a span_id matching the event's span_id
+    # Find the first transaction that matches the event's transaction name and has a profile
     matching_transaction = None
     for node in all_events:
         if node.get("is_transaction", False):
-            # Check if this transaction's span_id matches the event_span_id
-            if node.get("span_id") == event_span_id:
-                matching_transaction = node
-                break
-
-            # Check if this transaction contains the event_span_id in its span_ids
-            if event_span_id in node.get("span_ids", []):
+            if node.get("transaction") == event_transaction_name and node.get("profile_id"):
                 matching_transaction = node
                 break
 
@@ -665,6 +659,7 @@ def collect_all_events(node):
             "[Autofix] No matching transaction with profile_id found for event",
             extra={
                 "trace_to_search_id": event.trace_id,
+                "event_transaction_name": event_transaction_name,
                 "matching_transaction": matching_transaction,
                 "project_slug": project.slug,
                 "organization_slug": project.organization.slug,
@@ -688,7 +683,6 @@ def collect_all_events(node):
     start_ts = matching_transaction.get("precise_start_ts")
     end_ts = matching_transaction.get("precise_finish_ts")
 
-    # Fetch the profile data using the shared utility
     profile = fetch_profile_data(
         profile_id=profile_id,
         organization_id=project.organization_id,

src/sentry/seer/autofix/autofix_tools.py

@@ -1,30 +1,35 @@
-import orjson
-
 from sentry import eventstore
 from sentry.api.serializers import EventSerializer, serialize
-from sentry.profiles.utils import get_from_profiling_service
-from sentry.seer.explorer.utils import _convert_profile_to_execution_tree
+from sentry.seer.explorer.utils import _convert_profile_to_execution_tree, fetch_profile_data
 
 
-def get_profile_details(organization_id: int, project_id: int, profile_id: str):
-    response = get_from_profiling_service(
-        "GET",
-        f"/organizations/{organization_id}/projects/{project_id}/profiles/{profile_id}",
-        params={"format": "sample"},
+def get_profile_details(
+    organization_id: int,
+    project_id: int,
+    profile_id: str,
+    is_continuous: bool = False,
+    precise_start_ts: float | None = None,
+    precise_finish_ts: float | None = None,
+):
+    profile = fetch_profile_data(
+        profile_id=profile_id,
+        organization_id=organization_id,
+        project_id=project_id,
+        start_ts=precise_start_ts,
+        end_ts=precise_finish_ts,
+        is_continuous=is_continuous,
     )
 
-    if response.status == 200:
-        profile = orjson.loads(response.data)
+    if profile:
         execution_tree = _convert_profile_to_execution_tree(profile)
-        output = (
+        return (
             None
             if not execution_tree
             else {
                 "profile_matches_issue": True,
                 "execution_tree": execution_tree,
             }
         )
-        return output
 
 
 def get_error_event_details(project_id: int, event_id: str):

tests/sentry/seer/autofix/test_autofix.py

@@ -981,21 +981,16 @@ class TestGetProfileFromTraceTree(APITestCase, SnubaTestCase):
     def test_get_profile_from_trace_tree(self, mock_get_from_profiling_service) -> None:
         """
         Test the _get_profile_from_trace_tree method which finds a transaction
-        that contains the event's span_id or has a matching span_id.
+        that matches the event's transaction name and has a profile.
         """
-        # Setup mock event with span_id
+        # Setup mock event with transaction name
         event = Mock()
         event.event_id = "error-event-id"
         event.trace_id = "1234567890abcdef1234567890abcdef"
-        event.data = {
-            "contexts": {
-                "trace": {
-                    "span_id": "event-span-id",
-                }
-            }
-        }
+        event.transaction = "/api/users"
+        event.data = {"transaction": "/api/users"}
 
-        # Create a mock trace tree with a transaction that includes the event span_id in its span_ids
+        # Create a mock trace tree with a transaction that matches the event's transaction name
         profile_id = "profile123456789"
         trace_tree = {
             "trace_id": "1234567890abcdef1234567890abcdef",
@@ -1005,8 +1000,8 @@ def test_get_profile_from_trace_tree(self, mock_get_from_profiling_service) -> N
                     "span_id": "root-span-id",
                     "is_transaction": True,
                     "is_error": False,
+                    "transaction": "/api/users",
                     "profile_id": profile_id,
-                    "span_ids": ["some-span", "event-span-id", "another-span"],
                     "children": [
                         {
                             "event_id": "error-event-id",
@@ -1060,35 +1055,31 @@ def test_get_profile_from_trace_tree(self, mock_get_from_profiling_service) -> N
         )
 
     @patch("sentry.seer.explorer.utils.get_from_profiling_service")
-    def test_get_profile_from_trace_tree_matching_span_id(
+    def test_get_profile_from_trace_tree_matching_transaction_name(
         self, mock_get_from_profiling_service
     ) -> None:
         """
-        Test _get_profile_from_trace_tree with a transaction whose own span_id
-        matches the event's span_id.
+        Test _get_profile_from_trace_tree with a transaction whose name
+        matches the event's transaction name.
         """
-        # Setup mock event with span_id
+        # Setup mock event with transaction name
         event = Mock()
         event.event_id = "error-event-id"
         event.trace_id = "1234567890abcdef1234567890abcdef"
-        event.data = {
-            "contexts": {
-                "trace": {
-                    "span_id": "tx-span-id",
-                }
-            }
-        }
+        event.transaction = "/api/orders"
+        event.data = {"transaction": "/api/orders"}
 
-        # Create a mock trace tree with a transaction whose span_id matches event span_id
+        # Create a mock trace tree with a transaction whose name matches event transaction name
         profile_id = "profile123456789"
         trace_tree = {
             "trace_id": "1234567890abcdef1234567890abcdef",
             "events": [
                 {
                     "event_id": "tx-id",
-                    "span_id": "tx-span-id",  # This matches the event's span_id
+                    "span_id": "tx-span-id",
                     "is_transaction": True,
                     "is_error": False,
+                    "transaction": "/api/orders",  # This matches the event's transaction name
                     "profile_id": profile_id,
                     "children": [
                         {
@@ -1149,11 +1140,13 @@ def test_get_profile_from_trace_tree_continuous_e2e(
         End-to-end: build a trace tree from span query results where the transaction has only
         profiler.id (continuous profile). Then verify we fetch a continuous profile and return an execution tree.
         """
-        # Base error event whose span_id should be found within the transaction's spans
+        # Base error event whose transaction name should match the transaction in the trace
         trace_id = "1234567890abcdef1234567890abcdef"
         error_span_id = "bbbbbbbbbbbbbbbb"  # 16-hex span id
         tx_span_id = "aaaaaaaaaaaaaaaa"  # 16-hex transaction span id
         data = load_data("python")
+        # Set transaction to match what we'll have in the trace tree
+        data["transaction"] = "/api/test"
         data.update({"contexts": {"trace": {"trace_id": trace_id, "span_id": error_span_id}}})
         event = self.store_event(data=data, project_id=self.project.id)
 
@@ -1172,7 +1165,7 @@ def test_get_profile_from_trace_tree_continuous_e2e(
                     "precise.start_ts": tx_start,
                     "precise.finish_ts": tx_end,
                     "is_transaction": True,
-                    "transaction": "Root",
+                    "transaction": "/api/test",
                     "project.id": self.project.id,
                     "platform": "python",
                     "profile.id": None,
@@ -1267,19 +1260,14 @@ def test_get_profile_from_trace_tree_api_error(self, mock_get_from_profiling_ser
         """
         Test the behavior when the profiling service API returns an error.
         """
-        # Setup mock event with span_id
+        # Setup mock event with transaction name
         event = Mock()
         event.event_id = "error-event-id"
         event.trace_id = "1234567890abcdef1234567890abcdef"
-        event.data = {
-            "contexts": {
-                "trace": {
-                    "span_id": "event-span-id",
-                }
-            }
-        }
+        event.transaction = "/api/test"
+        event.data = {"transaction": "/api/test"}
 
-        # Create a mock trace tree with a transaction that includes the event span_id
+        # Create a mock trace tree with a transaction that matches the event transaction name
         profile_id = "profile123456789"
         trace_tree = {
             "trace_id": "1234567890abcdef1234567890abcdef",
@@ -1289,8 +1277,8 @@ def test_get_profile_from_trace_tree_api_error(self, mock_get_from_profiling_ser
                     "span_id": "root-span-id",
                     "is_transaction": True,
                     "is_error": False,
+                    "transaction": "/api/test",
                     "profile_id": profile_id,
-                    "span_ids": ["event-span-id"],
                     "children": [
                         {
                             "event_id": "error-event-id",
@@ -1327,19 +1315,14 @@ def test_get_profile_from_trace_tree_no_matching_transaction(
         """
         Test that the function returns None when no matching transaction is found.
         """
-        # Setup mock event with span_id
+        # Setup mock event with transaction name
         event = Mock()
         event.event_id = "error-event-id"
         event.trace_id = "1234567890abcdef1234567890abcdef"
-        event.data = {
-            "contexts": {
-                "trace": {
-                    "span_id": "event-span-id",
-                }
-            }
-        }
+        event.transaction = "/api/different"
+        event.data = {"transaction": "/api/different"}
 
-        # Create a mock trace tree with a transaction that DOESN'T include the event span_id
+        # Create a mock trace tree with a transaction that DOESN'T match the event transaction name
         trace_tree = {
             "trace_id": "1234567890abcdef1234567890abcdef",
             "events": [
@@ -1348,8 +1331,8 @@ def test_get_profile_from_trace_tree_no_matching_transaction(
                     "span_id": "root-span-id",
                     "is_transaction": True,
                     "is_error": False,
+                    "transaction": "/api/other",  # Doesn't match event's transaction name
                     "profile_id": "profile123456789",
-                    "span_ids": ["different-span-id"],  # Doesn't include event's span_id
                     "children": [
                         {
                             "event_id": "error-event-id",
@@ -1371,15 +1354,18 @@ def test_get_profile_from_trace_tree_no_matching_transaction(
         mock_get_from_profiling_service.assert_not_called()
 
     @patch("sentry.seer.explorer.utils.get_from_profiling_service")
-    def test_get_profile_from_trace_tree_no_span_id(self, mock_get_from_profiling_service) -> None:
+    def test_get_profile_from_trace_tree_no_transaction_name(
+        self, mock_get_from_profiling_service
+    ) -> None:
         """
-        Test the behavior when the event doesn't have a span_id.
+        Test the behavior when the event doesn't have a transaction name.
         """
-        # Setup mock event WITHOUT span_id
+        # Setup mock event WITHOUT transaction name
         event = Mock()
         event.event_id = "error-event-id"
         event.trace_id = "1234567890abcdef1234567890abcdef"
-        event.data = {"contexts": {"trace": {}}}  # No span_id
+        event.transaction = None
+        event.data = {}  # No transaction
 
         # Create a mock trace tree
         trace_tree = {
@@ -1390,6 +1376,7 @@ def test_get_profile_from_trace_tree_no_span_id(self, mock_get_from_profiling_se
                     "span_id": "tx-span-id",
                     "is_transaction": True,
                     "is_error": False,
+                    "transaction": "/api/test",
                     "profile_id": "profile123456789",
                     "children": [],
                 }
@@ -1400,7 +1387,7 @@ def test_get_profile_from_trace_tree_no_span_id(self, mock_get_from_profiling_se
         profile_result = _get_profile_from_trace_tree(trace_tree, event, self.project)
 
         assert profile_result is None
-        # API should not be called if event has no span_id
+        # API should not be called if event has no transaction name
         mock_get_from_profiling_service.assert_not_called()