Skip to content

Commit f39e324

Browse files
authored
Fix(ui): Fix issue details warnings (#8745)
* Fix issue details warnings * Remove warning on componentToString
1 parent f813cef commit f39e324

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

src/sentry/static/sentry/app/components/group/seenInfo.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import TimeSince from 'app/components/timeSince';
66
import Version from 'app/components/version';
77
import VersionHoverCard from 'app/components/versionHoverCard';
88
import Tooltip from 'app/components/tooltip';
9+
import {componentToString} from 'app/utils/componentToString';
910
import {defined, toTitleCase} from 'app/utils';
10-
import componentToString from 'app/utils/componentToString';
1111
import {t} from 'app/locale';
1212

1313
const SeenInfo = createReactClass({
@@ -74,7 +74,7 @@ const SeenInfo = createReactClass({
7474
<dt key={0}>{t('When')}:</dt>
7575
{date ? (
7676
<dd key={1}>
77-
<Tooltip title={this.getTooltipTitle} tooltipOptions={{html: true}}>
77+
<Tooltip title={this.getTooltipTitle()} tooltipOptions={{html: true}}>
7878
<span>
7979
<TimeSince className="dotted-underline" date={date} />
8080
</span>

src/sentry/static/sentry/app/components/group/tagDistributionMeter.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ const TagDistributionMeter = createReactClass({
115115
'%';
116116

117117
return (
118-
<Tooltip key={value.id} title={tooltipHtml} tooltipOptions={{html: true}}>
118+
<Tooltip key={value.key} title={tooltipHtml} tooltipOptions={{html: true}}>
119119
<Link
120120
className={className}
121121
style={{width: pct + '%'}}
Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
import ReactDOM from 'react-dom';
1+
import ReactDOMServer from 'react-dom/server';
22

3-
export default function(node) {
4-
let el = document.createElement('div');
5-
ReactDOM.render(node, el);
6-
return el.innerHTML;
3+
export function componentToString(node) {
4+
return ReactDOMServer.renderToStaticMarkup(node);
75
}

0 commit comments

Comments
 (0)