Skip to content

Commit f81814e

Browse files
authored
test(javascript): Fixup test with correct values (#97156)
Follow-up to #97069. The test now correctly asserts that two frames are unmapped.
1 parent f8ce885 commit f81814e

File tree

1 file changed

+10
-16
lines changed

1 file changed

+10
-16
lines changed

tests/relay_integration/lang/javascript/test_plugin.py

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1302,29 +1302,23 @@ def assert_abs_path(abs_path):
13021302
assert frame_list[2].function == "App"
13031303
assert frame_list[2].lineno == 2
13041304

1305-
# TODO: 1:1014 in the minified source file is _unmapped_.
1305+
# 1:1014 in the minified source file is _unmapped_.
13061306
# There are no tokens in the sourcemap for line 1.
1307-
# Previous versions of JS symbolication erroneously returned
1308-
# wrong values here. This needs to be enabled once Symbolicator
1309-
# is updated.
1310-
# assert frame_list[3].abs_path == "app:///dist.bundle.js"
1311-
# assert frame_list[3].function == "Object.<anonymous>"
1312-
# assert frame_list[3].lineno == 1
1313-
# assert frame_list[3].colno == 1014
1307+
assert frame_list[3].abs_path == "app:///dist.bundle.js"
1308+
assert frame_list[3].function == "Object.<anonymous>"
1309+
assert frame_list[3].lineno == 1
1310+
assert frame_list[3].colno == 1014
13141311

13151312
assert_abs_path(frame_list[4].abs_path)
13161313
assert frame_list[4].function == "__webpack_require__"
13171314
assert frame_list[4].lineno == 19
13181315

1319-
# TODO: 18:63 in the minified source file is _unmapped_.
1316+
# 18:63 in the minified source file is _unmapped_.
13201317
# There are no tokens in the sourcemap for line 18.
1321-
# Previous versions of JS symbolication erroneously returned
1322-
# wrong values here. This needs to be enabled once Symbolicator
1323-
# is updated.
1324-
# assert frame_list[5].abs_path == "app:///dist.bundle.js"
1325-
# assert frame_list[5].function == "Object.<anonymous>"
1326-
# assert frame_list[5].lineno == 18
1327-
# assert frame_list[5].colno == 63
1318+
assert frame_list[5].abs_path == "app:///dist.bundle.js"
1319+
assert frame_list[5].function == "<unknown>"
1320+
assert frame_list[5].lineno == 18
1321+
assert frame_list[5].colno == 63
13281322

13291323
@responses.activate
13301324
def test_no_fetch_from_http(self) -> None:

0 commit comments

Comments
 (0)