Skip to content

Commit fa37ebc

Browse files
committed
Specify no-op onChange handler on select to avoid react warning
1 parent 8da609b commit fa37ebc

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/sentry/static/sentry/app/views/stream/tagFilter.jsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,14 +104,17 @@ var StreamTagFilter = React.createClass({
104104
},
105105

106106
render() {
107+
// NOTE: need to specify empty onChange handler on <select> - even though this
108+
// will get overridden by select2 - because React will complain with
109+
// a warning
107110
let tag = this.props.tag;
108111
return (
109112
<div className="stream-tag-filter">
110113
<h6 className="nav-header">{tag.name}</h6>
111114

112115
{this.props.tag.predefined ?
113116

114-
<select ref="select" value={this.props.value}>
117+
<select ref="select" value={this.props.value} onChange={function(){}}>
115118
<option key="empty"></option>
116119
{this.props.tag.values.map((val) => {
117120
return (

0 commit comments

Comments
 (0)