[DO NOT MERGE] - for demo only #101198
[DO NOT MERGE] - for demo only #101198
Conversation
github-actions
bot
added
the
Scope: Frontend
suejung-sentry
changed the title
|
@sentry generate-test |
|
@sentry review |
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
| const sensitivityOptions: SensitivityOption[] = [ | ||
| {value: 'low', label: 'Low', details: 'Post all potential issues for maximum breadth.'}, | ||
| { | ||
| value: 'medium', | ||
| label: 'Medium', | ||
| details: 'Post likely issues for a balance of thoroughness and noise.', | ||
| }, | ||
| { | ||
| value: 'high', | ||
| label: 'High', | ||
| details: 'Post only major issues to highlight most impactful findings.', | ||
| }, | ||
| { | ||
| value: 'critical', | ||
| label: 'Critical', | ||
| details: 'Post only high-impact, high-sensitivity issues for maximum focus.', | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
The sensitivityOptions array contains hardcoded English strings for labels and details. Consider using the t() function for internationalization to ensure these strings can be translated. This is especially important for user-facing text that explains feature behavior.
Did we get this right? 👍 / 👎 to inform future reviews.
|
@suejung-sentry Looks like you don't intend to merge this. In that case, using a draft PR won't send notifications to folks for review :) |
@JonasBa, ah oops sorry is it spamming you? & don't worry I'll close any dummy PRs after the demo next week! |
|
Ah no worries :) I wonder if you could explicitly trigger the review workflow by tagging the agent then 🤔 Might be a good feature request for the team otherwise, as it sounds like something that you should be able to do |
Good input - thank you! The tagging ( |
suejung-sentry
changed the title
[DO NOT MERGE] - for demo only