From 0b76a485112ed484efa7db31133162045ca744fb Mon Sep 17 00:00:00 2001 From: Matej Minar Date: Mon, 16 Dec 2024 17:07:43 +0100 Subject: [PATCH 1/2] feat(user-feedback): Add loader getting started --- .../feedback/feedbackOnboarding/sidebar.tsx | 4 +- .../onboarding/gettingStartedDoc/types.ts | 2 + static/app/gettingStartedDocs/bun/bun.tsx | 6 +- static/app/gettingStartedDocs/deno/deno.tsx | 6 +- .../app/gettingStartedDocs/dotnet/aspnet.tsx | 6 +- .../gettingStartedDocs/dotnet/aspnetcore.tsx | 6 +- .../app/gettingStartedDocs/elixir/elixir.tsx | 6 +- static/app/gettingStartedDocs/go/echo.tsx | 6 +- static/app/gettingStartedDocs/go/fasthttp.tsx | 6 +- static/app/gettingStartedDocs/go/fiber.tsx | 6 +- static/app/gettingStartedDocs/go/gin.tsx | 6 +- static/app/gettingStartedDocs/go/go.tsx | 6 +- static/app/gettingStartedDocs/go/http.tsx | 6 +- static/app/gettingStartedDocs/go/iris.tsx | 6 +- static/app/gettingStartedDocs/go/martini.tsx | 6 +- static/app/gettingStartedDocs/go/negroni.tsx | 6 +- .../gettingStartedDocs/java/spring-boot.tsx | 6 +- static/app/gettingStartedDocs/java/spring.tsx | 6 +- .../javascript/javascript.tsx | 6 +- .../javascript/jsLoader/jsLoader.tsx | 67 ++++++++++++++++++- .../app/gettingStartedDocs/node/express.tsx | 6 +- .../app/gettingStartedDocs/node/fastify.tsx | 6 +- static/app/gettingStartedDocs/node/node.tsx | 6 +- static/app/gettingStartedDocs/php/laravel.tsx | 6 +- static/app/gettingStartedDocs/php/php.tsx | 6 +- static/app/gettingStartedDocs/php/symfony.tsx | 6 +- .../app/gettingStartedDocs/python/aiohttp.tsx | 6 +- .../app/gettingStartedDocs/python/bottle.tsx | 6 +- .../app/gettingStartedDocs/python/django.tsx | 6 +- .../app/gettingStartedDocs/python/falcon.tsx | 6 +- .../app/gettingStartedDocs/python/fastapi.tsx | 6 +- .../app/gettingStartedDocs/python/flask.tsx | 6 +- .../app/gettingStartedDocs/python/pyramid.tsx | 6 +- .../app/gettingStartedDocs/python/quart.tsx | 6 +- .../app/gettingStartedDocs/python/sanic.tsx | 6 +- .../gettingStartedDocs/python/starlette.tsx | 6 +- .../app/gettingStartedDocs/python/tornado.tsx | 6 +- static/app/gettingStartedDocs/ruby/rails.tsx | 6 +- 38 files changed, 244 insertions(+), 39 deletions(-) diff --git a/static/app/components/feedback/feedbackOnboarding/sidebar.tsx b/static/app/components/feedback/feedbackOnboarding/sidebar.tsx index 921adbf3424630..d2171d9a7d1ad7 100644 --- a/static/app/components/feedback/feedbackOnboarding/sidebar.tsx +++ b/static/app/components/feedback/feedbackOnboarding/sidebar.tsx @@ -261,7 +261,6 @@ function OnboardingContent({currentProject}: {currentProject: Project}) { ]} value={setupMode()} onChange={setSetupMode} - disabledChoices={[['jsLoader', t('Coming soon!')]]} tooltipPosition={'top-start'} /> ) : ( @@ -333,8 +332,7 @@ function OnboardingContent({currentProject}: {currentProject: Project}) { ) { return 'feedbackOnboardingNpm'; } - // TODO: update this when we add feedback to the loader - return 'replayOnboardingJsLoader'; + return 'feedbackOnboardingJsLoader'; } return ( diff --git a/static/app/components/onboarding/gettingStartedDoc/types.ts b/static/app/components/onboarding/gettingStartedDoc/types.ts index 54e05444dd473f..852b6c0f21f222 100644 --- a/static/app/components/onboarding/gettingStartedDoc/types.ts +++ b/static/app/components/onboarding/gettingStartedDoc/types.ts @@ -111,6 +111,7 @@ export interface Docs; featureFlagOnboarding?: OnboardingConfig; feedbackOnboardingCrashApi?: OnboardingConfig; + feedbackOnboardingJsLoader?: OnboardingConfig; feedbackOnboardingNpm?: OnboardingConfig; performanceOnboarding?: OnboardingConfig; platformOptions?: PlatformOptions; @@ -123,6 +124,7 @@ export type ConfigType = | 'onboarding' | 'feedbackOnboardingNpm' | 'feedbackOnboardingCrashApi' + | 'feedbackOnboardingJsLoader' | 'crashReportOnboarding' | 'replayOnboarding' | 'replayOnboardingJsLoader' diff --git a/static/app/gettingStartedDocs/bun/bun.tsx b/static/app/gettingStartedDocs/bun/bun.tsx index 57e8a22dc10e1c..11987a8a0bdde4 100644 --- a/static/app/gettingStartedDocs/bun/bun.tsx +++ b/static/app/gettingStartedDocs/bun/bun.tsx @@ -13,7 +13,10 @@ import { } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding'; import exampleSnippets from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsExampleSnippets'; import {metricTagsExplanation} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; type Params = DocsParams; @@ -207,6 +210,7 @@ const docs: Docs = { replayOnboardingJsLoader, customMetricsOnboarding, crashReportOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/deno/deno.tsx b/static/app/gettingStartedDocs/deno/deno.tsx index 2303cf885e5a75..640f952f9d9c0f 100644 --- a/static/app/gettingStartedDocs/deno/deno.tsx +++ b/static/app/gettingStartedDocs/deno/deno.tsx @@ -5,7 +5,10 @@ import type { DocsParams, OnboardingConfig, } from 'sentry/components/onboarding/gettingStartedDoc/types'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; type Params = DocsParams; @@ -175,6 +178,7 @@ const docs: Docs = { onboarding, replayOnboardingJsLoader, customMetricsOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/dotnet/aspnet.tsx b/static/app/gettingStartedDocs/dotnet/aspnet.tsx index 394a6781c2be19..6f2f40ef588a7c 100644 --- a/static/app/gettingStartedDocs/dotnet/aspnet.tsx +++ b/static/app/gettingStartedDocs/dotnet/aspnet.tsx @@ -15,7 +15,10 @@ import { getCrashReportSDKInstallFirstStep, } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding'; import {getDotnetMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; import {getPackageVersion} from 'sentry/utils/gettingStartedDocs/getPackageVersion'; @@ -228,6 +231,7 @@ const docs: Docs = { replayOnboardingJsLoader, customMetricsOnboarding: getDotnetMetricsOnboarding({packageName: 'Sentry.AspNet'}), crashReportOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/dotnet/aspnetcore.tsx b/static/app/gettingStartedDocs/dotnet/aspnetcore.tsx index 963e25db4e37c6..b8ce77f4697d40 100644 --- a/static/app/gettingStartedDocs/dotnet/aspnetcore.tsx +++ b/static/app/gettingStartedDocs/dotnet/aspnetcore.tsx @@ -15,7 +15,10 @@ import { getCrashReportSDKInstallFirstStep, } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding'; import {getDotnetMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; import {getPackageVersion} from 'sentry/utils/gettingStartedDocs/getPackageVersion'; @@ -313,6 +316,7 @@ const docs: Docs = { replayOnboardingJsLoader, customMetricsOnboarding: getDotnetMetricsOnboarding({packageName: 'Sentry.AspNetCore'}), crashReportOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/elixir/elixir.tsx b/static/app/gettingStartedDocs/elixir/elixir.tsx index 689819e8801ca3..edea378891329e 100644 --- a/static/app/gettingStartedDocs/elixir/elixir.tsx +++ b/static/app/gettingStartedDocs/elixir/elixir.tsx @@ -11,7 +11,10 @@ import { getCrashReportModalConfigDescription, getCrashReportModalIntroduction, } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; type Params = DocsParams; @@ -179,6 +182,7 @@ const docs: Docs = { onboarding, replayOnboardingJsLoader, crashReportOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/go/echo.tsx b/static/app/gettingStartedDocs/go/echo.tsx index 173b604def9756..6a975ce40400b5 100644 --- a/static/app/gettingStartedDocs/go/echo.tsx +++ b/static/app/gettingStartedDocs/go/echo.tsx @@ -14,7 +14,10 @@ import { getCrashReportModalConfigDescription, getCrashReportModalIntroduction, } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; type Params = DocsParams; @@ -232,6 +235,7 @@ const docs: Docs = { onboarding, replayOnboardingJsLoader, crashReportOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/go/fasthttp.tsx b/static/app/gettingStartedDocs/go/fasthttp.tsx index 1c66d8fa9e4cb8..0d70c509a8ea99 100644 --- a/static/app/gettingStartedDocs/go/fasthttp.tsx +++ b/static/app/gettingStartedDocs/go/fasthttp.tsx @@ -14,7 +14,10 @@ import { getCrashReportModalConfigDescription, getCrashReportModalIntroduction, } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; type Params = DocsParams; @@ -237,6 +240,7 @@ const docs: Docs = { onboarding, replayOnboardingJsLoader, crashReportOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/go/fiber.tsx b/static/app/gettingStartedDocs/go/fiber.tsx index e2a48887e3700e..8e2a5ba4571483 100644 --- a/static/app/gettingStartedDocs/go/fiber.tsx +++ b/static/app/gettingStartedDocs/go/fiber.tsx @@ -14,7 +14,10 @@ import { getCrashReportModalConfigDescription, getCrashReportModalIntroduction, } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; type Params = DocsParams; @@ -242,6 +245,7 @@ const docs: Docs = { onboarding, replayOnboardingJsLoader, crashReportOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/go/gin.tsx b/static/app/gettingStartedDocs/go/gin.tsx index 3fc2d7edbfc015..7fde4071eb71d4 100644 --- a/static/app/gettingStartedDocs/go/gin.tsx +++ b/static/app/gettingStartedDocs/go/gin.tsx @@ -14,7 +14,10 @@ import { getCrashReportModalConfigDescription, getCrashReportModalIntroduction, } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; type Params = DocsParams; @@ -224,6 +227,7 @@ const docs: Docs = { onboarding, replayOnboardingJsLoader, crashReportOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/go/go.tsx b/static/app/gettingStartedDocs/go/go.tsx index ccc25a4e4ccdaf..7c879a69e43f31 100644 --- a/static/app/gettingStartedDocs/go/go.tsx +++ b/static/app/gettingStartedDocs/go/go.tsx @@ -9,7 +9,10 @@ import { getCrashReportModalConfigDescription, getCrashReportModalIntroduction, } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; type Params = DocsParams; @@ -135,6 +138,7 @@ const docs: Docs = { onboarding, replayOnboardingJsLoader, crashReportOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/go/http.tsx b/static/app/gettingStartedDocs/go/http.tsx index dba8624e4517ea..1b13d957898a89 100644 --- a/static/app/gettingStartedDocs/go/http.tsx +++ b/static/app/gettingStartedDocs/go/http.tsx @@ -14,7 +14,10 @@ import { getCrashReportModalConfigDescription, getCrashReportModalIntroduction, } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; type Params = DocsParams; @@ -232,6 +235,7 @@ const docs: Docs = { onboarding, replayOnboardingJsLoader, crashReportOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/go/iris.tsx b/static/app/gettingStartedDocs/go/iris.tsx index 0e6a34e74b9fe1..255fb375812e91 100644 --- a/static/app/gettingStartedDocs/go/iris.tsx +++ b/static/app/gettingStartedDocs/go/iris.tsx @@ -14,7 +14,10 @@ import { getCrashReportModalConfigDescription, getCrashReportModalIntroduction, } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; type Params = DocsParams; @@ -221,6 +224,7 @@ const docs: Docs = { onboarding, replayOnboardingJsLoader, crashReportOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/go/martini.tsx b/static/app/gettingStartedDocs/go/martini.tsx index 63b00ea361dd74..845137d78a5ce6 100644 --- a/static/app/gettingStartedDocs/go/martini.tsx +++ b/static/app/gettingStartedDocs/go/martini.tsx @@ -14,7 +14,10 @@ import { getCrashReportModalConfigDescription, getCrashReportModalIntroduction, } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; type Params = DocsParams; @@ -219,6 +222,7 @@ const docs: Docs = { onboarding, replayOnboardingJsLoader, crashReportOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/go/negroni.tsx b/static/app/gettingStartedDocs/go/negroni.tsx index ac3c384214311f..163f8c9b11625f 100644 --- a/static/app/gettingStartedDocs/go/negroni.tsx +++ b/static/app/gettingStartedDocs/go/negroni.tsx @@ -14,7 +14,10 @@ import { getCrashReportModalConfigDescription, getCrashReportModalIntroduction, } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; type Params = DocsParams; @@ -283,6 +286,7 @@ const docs: Docs = { onboarding, replayOnboardingJsLoader, crashReportOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/java/spring-boot.tsx b/static/app/gettingStartedDocs/java/spring-boot.tsx index 7acd0784ea000b..5787e0a0cff4d1 100644 --- a/static/app/gettingStartedDocs/java/spring-boot.tsx +++ b/static/app/gettingStartedDocs/java/spring-boot.tsx @@ -11,7 +11,10 @@ import type { } from 'sentry/components/onboarding/gettingStartedDoc/types'; import {getJavaMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; import {feedbackOnboardingCrashApiJava} from 'sentry/gettingStartedDocs/java/java'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; import {getPackageVersion} from 'sentry/utils/gettingStartedDocs/getPackageVersion'; @@ -297,6 +300,7 @@ const docs: Docs = { replayOnboardingJsLoader, crashReportOnboarding: feedbackOnboardingCrashApiJava, customMetricsOnboarding: getJavaMetricsOnboarding(), + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/java/spring.tsx b/static/app/gettingStartedDocs/java/spring.tsx index 024aab936db9d8..32641237815a69 100644 --- a/static/app/gettingStartedDocs/java/spring.tsx +++ b/static/app/gettingStartedDocs/java/spring.tsx @@ -11,7 +11,10 @@ import type { } from 'sentry/components/onboarding/gettingStartedDoc/types'; import {getJavaMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; import {feedbackOnboardingCrashApiJava} from 'sentry/gettingStartedDocs/java/java'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; import {getPackageVersion} from 'sentry/utils/gettingStartedDocs/getPackageVersion'; @@ -370,6 +373,7 @@ const docs: Docs = { crashReportOnboarding: feedbackOnboardingCrashApiJava, replayOnboardingJsLoader, customMetricsOnboarding: getJavaMetricsOnboarding(), + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/javascript/javascript.tsx b/static/app/gettingStartedDocs/javascript/javascript.tsx index 12894d782401e0..2391e9228fe8eb 100644 --- a/static/app/gettingStartedDocs/javascript/javascript.tsx +++ b/static/app/gettingStartedDocs/javascript/javascript.tsx @@ -30,7 +30,10 @@ import { getReplayConfigureDescription, getReplayVerifyStep, } from 'sentry/components/onboarding/gettingStartedDoc/utils/replayOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; import {space} from 'sentry/styles/space'; import {trackAnalytics} from 'sentry/utils/analytics'; @@ -683,6 +686,7 @@ ${FLAG_OPTIONS[featureFlagOptions.integration].sdkInit} const docs: Docs = { onboarding, feedbackOnboardingNpm: feedbackOnboarding, + feedbackOnboardingJsLoader, replayOnboarding, replayOnboardingJsLoader, performanceOnboarding, diff --git a/static/app/gettingStartedDocs/javascript/jsLoader/jsLoader.tsx b/static/app/gettingStartedDocs/javascript/jsLoader/jsLoader.tsx index 02259ed121e7bf..0133cd0b537811 100644 --- a/static/app/gettingStartedDocs/javascript/jsLoader/jsLoader.tsx +++ b/static/app/gettingStartedDocs/javascript/jsLoader/jsLoader.tsx @@ -60,6 +60,71 @@ const getVerifySnippet = () => ` }); `; +const feedbackOnboardingJsLoader: OnboardingConfig = { + install: (params: Params) => [ + { + type: StepType.INSTALL, + configurations: [ + { + description: t('Add this script tag to the top of the page:'), + language: 'html', + code: beautify.html( + ``, + {indent_size: 2, wrap_attributes: 'force-expand-multiline'} + ), + }, + ], + }, + ], + configure: _params => [ + { + type: StepType.CONFIGURE, + description: t( + 'When using the Loader Script, you can lazy load the User Feedback integration like this:' + ), + configurations: [ + { + code: [ + { + label: 'JavaScript', + value: 'javascript', + language: 'javascript', + code: ` +window.sentryOnLoad = function () { + Sentry.init({ + // add other configuration here + }); + + Sentry.lazyLoadIntegration("feedbackIntegration") + .then((feedbackIntegration) => { + Sentry.addIntegration(feedbackIntegration({ + // User Feedback configuration options + })); + }) + .catch(() => { + // this can happen if e.g. a network error occurs, + // in this case User Feedback will not be enabled + }); +}; + `, + }, + ], + }, + ], + additionalInfo: tct( + `For a full list of User Feedback configuration options, [link:read the docs].`, + { + link: ( + + ), + } + ), + }, + ], + verify: () => [], + nextSteps: () => [], +}; + const replayOnboardingJsLoader: OnboardingConfig = { install: (params: Params) => getInstallConfig(params), configure: (params: Params) => [ @@ -103,4 +168,4 @@ const StyledAlert = styled(Alert)` margin: 0; `; -export default replayOnboardingJsLoader; +export {feedbackOnboardingJsLoader, replayOnboardingJsLoader}; diff --git a/static/app/gettingStartedDocs/node/express.tsx b/static/app/gettingStartedDocs/node/express.tsx index e3a9c10cf926d3..1b6e474ccb868a 100644 --- a/static/app/gettingStartedDocs/node/express.tsx +++ b/static/app/gettingStartedDocs/node/express.tsx @@ -12,7 +12,10 @@ import { getCrashReportModalIntroduction, } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding'; import {getJSServerMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; import { getImportInstrumentSnippet, @@ -156,6 +159,7 @@ const docs: Docs = { replayOnboardingJsLoader, customMetricsOnboarding: getJSServerMetricsOnboarding(), crashReportOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/node/fastify.tsx b/static/app/gettingStartedDocs/node/fastify.tsx index 088042b1e0ebb9..5bc407a89aa40a 100644 --- a/static/app/gettingStartedDocs/node/fastify.tsx +++ b/static/app/gettingStartedDocs/node/fastify.tsx @@ -12,7 +12,10 @@ import { getCrashReportModalIntroduction, } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding'; import {getJSServerMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; import { getImportInstrumentSnippet, @@ -142,6 +145,7 @@ const docs: Docs = { replayOnboardingJsLoader, customMetricsOnboarding: getJSServerMetricsOnboarding(), crashReportOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/node/node.tsx b/static/app/gettingStartedDocs/node/node.tsx index 63f6538f2f35e8..3a0d77609d97a2 100644 --- a/static/app/gettingStartedDocs/node/node.tsx +++ b/static/app/gettingStartedDocs/node/node.tsx @@ -12,7 +12,10 @@ import { getCrashReportModalIntroduction, } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding'; import {getJSServerMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; import { getImportInstrumentSnippet, @@ -252,6 +255,7 @@ const docs: Docs = { performanceOnboarding, crashReportOnboarding, profilingOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/php/laravel.tsx b/static/app/gettingStartedDocs/php/laravel.tsx index 2896cbf29538c7..609eb5303e3ee9 100644 --- a/static/app/gettingStartedDocs/php/laravel.tsx +++ b/static/app/gettingStartedDocs/php/laravel.tsx @@ -13,7 +13,10 @@ import { } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding'; import exampleSnippets from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsExampleSnippets'; import {metricTagsExplanation} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; type Params = DocsParams; @@ -368,6 +371,7 @@ const docs: Docs = { replayOnboardingJsLoader, customMetricsOnboarding, crashReportOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/php/php.tsx b/static/app/gettingStartedDocs/php/php.tsx index a4ebd8dd35cf46..7e8195dffe1b4c 100644 --- a/static/app/gettingStartedDocs/php/php.tsx +++ b/static/app/gettingStartedDocs/php/php.tsx @@ -13,7 +13,10 @@ import { } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding'; import exampleSnippets from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsExampleSnippets'; import {metricTagsExplanation} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; type Params = DocsParams; @@ -332,6 +335,7 @@ const docs: Docs = { customMetricsOnboarding, performanceOnboarding, crashReportOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/php/symfony.tsx b/static/app/gettingStartedDocs/php/symfony.tsx index 084e7703a3c774..f9f4c7632894b2 100644 --- a/static/app/gettingStartedDocs/php/symfony.tsx +++ b/static/app/gettingStartedDocs/php/symfony.tsx @@ -11,7 +11,10 @@ import { getCrashReportModalIntroduction, getCrashReportPHPInstallStep, } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; type Params = DocsParams; @@ -186,6 +189,7 @@ const docs: Docs = { onboarding, replayOnboardingJsLoader, crashReportOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/python/aiohttp.tsx b/static/app/gettingStartedDocs/python/aiohttp.tsx index a64fcd7874bef4..e37985dcb6fedd 100644 --- a/static/app/gettingStartedDocs/python/aiohttp.tsx +++ b/static/app/gettingStartedDocs/python/aiohttp.tsx @@ -7,7 +7,10 @@ import { type OnboardingConfig, } from 'sentry/components/onboarding/gettingStartedDoc/types'; import {getPythonMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import { AlternativeConfiguration, crashReportOnboardingPython, @@ -169,6 +172,7 @@ const docs: Docs = { }), crashReportOnboarding: crashReportOnboardingPython, featureFlagOnboarding: featureFlagOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/python/bottle.tsx b/static/app/gettingStartedDocs/python/bottle.tsx index 3d9e0eefd04a27..52c87a10327a50 100644 --- a/static/app/gettingStartedDocs/python/bottle.tsx +++ b/static/app/gettingStartedDocs/python/bottle.tsx @@ -7,7 +7,10 @@ import { type OnboardingConfig, } from 'sentry/components/onboarding/gettingStartedDoc/types'; import {getPythonMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import { AlternativeConfiguration, crashReportOnboardingPython, @@ -161,6 +164,7 @@ const docs: Docs = { }), crashReportOnboarding: crashReportOnboardingPython, featureFlagOnboarding: featureFlagOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/python/django.tsx b/static/app/gettingStartedDocs/python/django.tsx index fd17c37fd4bcf2..ac68b7a234fd6b 100644 --- a/static/app/gettingStartedDocs/python/django.tsx +++ b/static/app/gettingStartedDocs/python/django.tsx @@ -7,7 +7,10 @@ import { type OnboardingConfig, } from 'sentry/components/onboarding/gettingStartedDoc/types'; import {getPythonMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import { AlternativeConfiguration, crashReportOnboardingPython, @@ -231,6 +234,7 @@ const docs: Docs = { performanceOnboarding, crashReportOnboarding: crashReportOnboardingPython, featureFlagOnboarding: featureFlagOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/python/falcon.tsx b/static/app/gettingStartedDocs/python/falcon.tsx index 8e83c85db10bf5..01569edf9964a0 100644 --- a/static/app/gettingStartedDocs/python/falcon.tsx +++ b/static/app/gettingStartedDocs/python/falcon.tsx @@ -7,7 +7,10 @@ import { type OnboardingConfig, } from 'sentry/components/onboarding/gettingStartedDoc/types'; import {getPythonMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import { AlternativeConfiguration, crashReportOnboardingPython, @@ -161,6 +164,7 @@ const docs: Docs = { }), crashReportOnboarding: crashReportOnboardingPython, featureFlagOnboarding: featureFlagOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/python/fastapi.tsx b/static/app/gettingStartedDocs/python/fastapi.tsx index 6097b8ab64781e..60f1151c3a7e13 100644 --- a/static/app/gettingStartedDocs/python/fastapi.tsx +++ b/static/app/gettingStartedDocs/python/fastapi.tsx @@ -9,7 +9,10 @@ import { type OnboardingConfig, } from 'sentry/components/onboarding/gettingStartedDoc/types'; import {getPythonMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import { AlternativeConfiguration, crashReportOnboardingPython, @@ -171,6 +174,7 @@ const docs: Docs = { }), crashReportOnboarding: crashReportOnboardingPython, featureFlagOnboarding: featureFlagOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/python/flask.tsx b/static/app/gettingStartedDocs/python/flask.tsx index 45165f5adf5b8f..c111d817a71f1a 100644 --- a/static/app/gettingStartedDocs/python/flask.tsx +++ b/static/app/gettingStartedDocs/python/flask.tsx @@ -9,7 +9,10 @@ import { type OnboardingConfig, } from 'sentry/components/onboarding/gettingStartedDoc/types'; import {getPythonMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import { AlternativeConfiguration, crashReportOnboardingPython, @@ -242,6 +245,7 @@ const docs: Docs = { performanceOnboarding, crashReportOnboarding: crashReportOnboardingPython, featureFlagOnboarding: featureFlagOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/python/pyramid.tsx b/static/app/gettingStartedDocs/python/pyramid.tsx index 12a7503f3d0bd4..6c0178d793fd24 100644 --- a/static/app/gettingStartedDocs/python/pyramid.tsx +++ b/static/app/gettingStartedDocs/python/pyramid.tsx @@ -6,7 +6,10 @@ import type { OnboardingConfig, } from 'sentry/components/onboarding/gettingStartedDoc/types'; import {getPythonMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import { crashReportOnboardingPython, featureFlagOnboarding, @@ -110,6 +113,7 @@ const docs: Docs = { }), crashReportOnboarding: crashReportOnboardingPython, featureFlagOnboarding: featureFlagOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/python/quart.tsx b/static/app/gettingStartedDocs/python/quart.tsx index 8dd51d2648eff1..0aa271f1f4343c 100644 --- a/static/app/gettingStartedDocs/python/quart.tsx +++ b/static/app/gettingStartedDocs/python/quart.tsx @@ -7,7 +7,10 @@ import { type OnboardingConfig, } from 'sentry/components/onboarding/gettingStartedDoc/types'; import {getPythonMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import { AlternativeConfiguration, crashReportOnboardingPython, @@ -158,6 +161,7 @@ const docs: Docs = { }), crashReportOnboarding: crashReportOnboardingPython, featureFlagOnboarding: featureFlagOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/python/sanic.tsx b/static/app/gettingStartedDocs/python/sanic.tsx index 349c78cc984e8c..9efbfdfb0b172b 100644 --- a/static/app/gettingStartedDocs/python/sanic.tsx +++ b/static/app/gettingStartedDocs/python/sanic.tsx @@ -6,7 +6,10 @@ import type { OnboardingConfig, } from 'sentry/components/onboarding/gettingStartedDoc/types'; import {getPythonMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import { crashReportOnboardingPython, featureFlagOnboarding, @@ -120,6 +123,7 @@ const docs: Docs = { }), crashReportOnboarding: crashReportOnboardingPython, featureFlagOnboarding: featureFlagOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/python/starlette.tsx b/static/app/gettingStartedDocs/python/starlette.tsx index 6d274e8851e602..611c3d0af55fa2 100644 --- a/static/app/gettingStartedDocs/python/starlette.tsx +++ b/static/app/gettingStartedDocs/python/starlette.tsx @@ -7,7 +7,10 @@ import { type OnboardingConfig, } from 'sentry/components/onboarding/gettingStartedDoc/types'; import {getPythonMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import { AlternativeConfiguration, crashReportOnboardingPython, @@ -158,6 +161,7 @@ const docs: Docs = { }), crashReportOnboarding: crashReportOnboardingPython, featureFlagOnboarding: featureFlagOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/python/tornado.tsx b/static/app/gettingStartedDocs/python/tornado.tsx index 77caab3e6b849f..fa7322f5945976 100644 --- a/static/app/gettingStartedDocs/python/tornado.tsx +++ b/static/app/gettingStartedDocs/python/tornado.tsx @@ -7,7 +7,10 @@ import { type OnboardingConfig, } from 'sentry/components/onboarding/gettingStartedDoc/types'; import {getPythonMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import { AlternativeConfiguration, crashReportOnboardingPython, @@ -179,6 +182,7 @@ const docs: Docs = { }), crashReportOnboarding: crashReportOnboardingPython, featureFlagOnboarding: featureFlagOnboarding, + feedbackOnboardingJsLoader, }; export default docs; diff --git a/static/app/gettingStartedDocs/ruby/rails.tsx b/static/app/gettingStartedDocs/ruby/rails.tsx index f88b218e408469..0de89fa880e56e 100644 --- a/static/app/gettingStartedDocs/ruby/rails.tsx +++ b/static/app/gettingStartedDocs/ruby/rails.tsx @@ -11,7 +11,10 @@ import { getCrashReportSDKInstallFirstStepRails, } from 'sentry/components/onboarding/gettingStartedDoc/utils/feedbackOnboarding'; import {getRubyMetricsOnboarding} from 'sentry/components/onboarding/gettingStartedDoc/utils/metricsOnboarding'; -import replayOnboardingJsLoader from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; +import { + feedbackOnboardingJsLoader, + replayOnboardingJsLoader, +} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader'; import {t, tct} from 'sentry/locale'; type Params = DocsParams; @@ -199,6 +202,7 @@ const docs: Docs = { customMetricsOnboarding: getRubyMetricsOnboarding(), replayOnboardingJsLoader, crashReportOnboarding, + feedbackOnboardingJsLoader, }; export default docs; From 67967826735c925a7b828d8fbf4917f62ef5a52a Mon Sep 17 00:00:00 2001 From: Matej Minar Date: Tue, 17 Dec 2024 10:27:30 +0100 Subject: [PATCH 2/2] Update static/app/gettingStartedDocs/javascript/jsLoader/jsLoader.tsx Co-authored-by: Michelle Zhang <56095982+michellewzhang@users.noreply.github.com> --- static/app/gettingStartedDocs/javascript/jsLoader/jsLoader.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/static/app/gettingStartedDocs/javascript/jsLoader/jsLoader.tsx b/static/app/gettingStartedDocs/javascript/jsLoader/jsLoader.tsx index 0133cd0b537811..7b42028576fa01 100644 --- a/static/app/gettingStartedDocs/javascript/jsLoader/jsLoader.tsx +++ b/static/app/gettingStartedDocs/javascript/jsLoader/jsLoader.tsx @@ -76,7 +76,7 @@ const feedbackOnboardingJsLoader: OnboardingConfig = { ], }, ], - configure: _params => [ + configure: () => [ { type: StepType.CONFIGURE, description: t(