Skip to content

chore: upgrade sentry_sdk for logging fix #91900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2025
Merged

chore: upgrade sentry_sdk for logging fix #91900

merged 2 commits into from
May 20, 2025

Conversation

@JoshFerge
Copy link
Member

@JoshFerge JoshFerge commented May 19, 2025

upgrade the sentry python sdk so we get some fixes for logging functionality. https://sentry.slack.com/archives/C081M1KEQ0L/p1747042396547599?thread_ts=1746721086.279279&cid=C081M1KEQ0L

@JoshFerge JoshFerge requested a review from a team as a code owner May 19, 2025 21:32
@JoshFerge JoshFerge requested a review from Dhrumil-Sentry May 19, 2025 21:33
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 19, 2025
@JoshFerge JoshFerge requested a review from a team May 19, 2025 21:33
@JoshFerge JoshFerge enabled auto-merge (squash) May 19, 2025 21:33
@asottile-sentry
Copy link
Contributor

asottile-sentry commented May 19, 2025

I assume you'll run into the same issues as #91717 -- not sure if those got resolved

@codecov
Copy link

codecov bot commented May 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.07143% with 5 lines in your changes missing coverage. Please review.

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:157341 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Files with missing lines Patch % Lines
src/sentry/search/events/fields.py 25.00% 3 Missing ⚠️
.../sentry/api/endpoints/organization_events_trace.py 85.71% 1 Missing ⚠️
src/sentry/ingest/transaction_clusterer/rules.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #91900      +/-   ##
==========================================
- Coverage   87.62%   77.64%   -9.99%     
==========================================
  Files       10356    10360       +4     
  Lines      586960   587507     +547     
  Branches    22585    22585              
==========================================
- Hits       514329   456173   -58156     
- Misses      72203   130906   +58703     
  Partials      428      428

@JoshFerge JoshFerge requested review from a team as code owners May 20, 2025 14:02
@JoshFerge JoshFerge merged commit bba930f into master May 20, 2025
60 of 61 checks passed
@JoshFerge JoshFerge deleted the jferg/upgrade-python-sentry-sdk branch May 20, 2025 14:20
andrewshie-sentry pushed a commit that referenced this pull request May 20, 2025
@JoshFerge @andrewshie-sentry
chore: upgrade sentry_sdk for logging fix (#91900)
d6e4136 
upgrade the sentry python sdk so we get some fixes for logging
functionality.
https://sentry.slack.com/archives/C081M1KEQ0L/p1747042396547599?thread_ts=1746721086.279279&cid=C081M1KEQ0L
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@roggenkemper roggenkemper roggenkemper approved these changes

@Dhrumil-Sentry Dhrumil-Sentry Awaiting requested review from Dhrumil-Sentry

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JoshFerge @asottile-sentry @roggenkemper