Skip to content

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Aug 8, 2025

  • fixes fetching historical data for EAP datasets
  • Loads both current and historical series of data

empty
Screenshot 2025-08-08 at 3 44 35 PM

loading
Screenshot 2025-08-08 at 2 51 12 PM

found
Screenshot 2025-08-08 at 2 49 39 PM

Instead of waiting until all data is ready, displays the chart and a spinner separately for anomalies

fixes an issue where it was querying too many datapoints
@scttcper scttcper requested a review from a team as a code owner August 8, 2025 22:46
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 8, 2025
# Conflicts:
#	static/app/views/detectors/components/forms/metric/metricDetectorChart.tsx
#	static/app/views/detectors/components/forms/metric/useIntervalChoices.tsx
#	static/app/views/detectors/hooks/useMetricDetectorAnomalyPeriods.tsx
Copy link
Member

@malwilley malwilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job spelling anomaly right every time

@scttcper scttcper enabled auto-merge (squash) August 12, 2025 17:18
@scttcper scttcper disabled auto-merge August 12, 2025 17:18
@scttcper scttcper merged commit 65062c8 into master Aug 12, 2025
45 checks passed
@scttcper scttcper deleted the scttcper/anomaly-loading-state branch August 12, 2025 17:18
andrewshie-sentry pushed a commit that referenced this pull request Aug 12, 2025
- fixes fetching historical data for EAP datasets
- Loads both current and historical series of data

empty
<img width="1036" height="335" alt="Screenshot 2025-08-08 at 3 44 35 PM"
src="https://github.com/user-attachments/assets/8a80c0c8-a61a-418c-bad2-69f5b18f7281"
/>

loading
<img width="1027" height="348" alt="Screenshot 2025-08-08 at 2 51 12 PM"
src="https://github.com/user-attachments/assets/ce9cbb0d-d0e6-4584-a37c-08bb75a0d05f"
/>

found
<img width="1040" height="348" alt="Screenshot 2025-08-08 at 2 49 39 PM"
src="https://github.com/user-attachments/assets/2762168b-b7a1-46d3-a767-7fd3f0b62237"
/>
priscilawebdev pushed a commit that referenced this pull request Aug 25, 2025
- fixes fetching historical data for EAP datasets
- Loads both current and historical series of data

empty
<img width="1036" height="335" alt="Screenshot 2025-08-08 at 3 44 35 PM"
src="https://github.com/user-attachments/assets/8a80c0c8-a61a-418c-bad2-69f5b18f7281"
/>

loading
<img width="1027" height="348" alt="Screenshot 2025-08-08 at 2 51 12 PM"
src="https://github.com/user-attachments/assets/ce9cbb0d-d0e6-4584-a37c-08bb75a0d05f"
/>

found
<img width="1040" height="348" alt="Screenshot 2025-08-08 at 2 49 39 PM"
src="https://github.com/user-attachments/assets/2762168b-b7a1-46d3-a767-7fd3f0b62237"
/>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants