-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(autofix): Handle missing state in get_autofix_state
#97556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_autofix_state
get_autofix_state
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #97556 +/- ##
==========================================
- Coverage 80.73% 80.62% -0.11%
==========================================
Files 8566 8560 -6
Lines 378963 376892 -2071
Branches 24538 24538
==========================================
- Hits 305948 303876 -2072
- Misses 72645 72646 +1
Partials 370 370 |
roaga
approved these changes
Aug 11, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 12, 2025
Fixes [SENTRY-43FP](https://sentry.io/organizations/sentry/issues/6709226854/). The issue was that: GitHub webhook for non-Autofix PR caused Seer to return null state, leading to `DictError` during validation. - Explicitly check for a missing `state` key in the result of `get_autofix_state`. - Return `None` if the `state` key is missing to avoid errors when validating. This fix was generated by Seer in Sentry, triggered by Rohan Agarwal. 👁️ Run ID: 734775 Not quite right? [Click here to continue debugging with Seer.](https://sentry.io/organizations/sentry/issues/6709226854/?seerDrawer=true) <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. Co-authored-by: seer-by-sentry[bot] <157164994+seer-by-sentry[bot]@users.noreply.github.com>
priscilawebdev
pushed a commit
that referenced
this pull request
Aug 25, 2025
Fixes [SENTRY-43FP](https://sentry.io/organizations/sentry/issues/6709226854/). The issue was that: GitHub webhook for non-Autofix PR caused Seer to return null state, leading to `DictError` during validation. - Explicitly check for a missing `state` key in the result of `get_autofix_state`. - Return `None` if the `state` key is missing to avoid errors when validating. This fix was generated by Seer in Sentry, triggered by Rohan Agarwal. 👁️ Run ID: 734775 Not quite right? [Click here to continue debugging with Seer.](https://sentry.io/organizations/sentry/issues/6709226854/?seerDrawer=true) <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. Co-authored-by: seer-by-sentry[bot] <157164994+seer-by-sentry[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Scope: Backend
Automatically applied to PRs that change backend components
Trigger: getsentry tests
Once code is reviewed: apply label to PR to trigger getsentry tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SENTRY-43FP. The issue was that: GitHub webhook for non-Autofix PR caused Seer to return null state, leading to
DictError
during validation.state
key in the result ofget_autofix_state
.None
if thestate
key is missing to avoid errors when validating.This fix was generated by Seer in Sentry, triggered by Rohan Agarwal. 👁️ Run ID: 734775
Not quite right? Click here to continue debugging with Seer.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.