feat(eap): add not filter implementation (#6858)

Separating not filters into a separate PR instead of doing it in [this
one](#6837) to allow product to
use it before we merge that one

Author: davidtsuk

snuba/web/rpc/common/common.py

@@ -285,6 +285,18 @@ def trace_item_filters_to_expression(item_filter: TraceItemFilter) -> Expression
             return trace_item_filters_to_expression(filters[0])
         return or_cond(*(trace_item_filters_to_expression(x) for x in filters))
 
+    if item_filter.HasField("not_filter"):
+        filters = item_filter.not_filter.filters
+        if len(filters) == 0:
+            raise BadSnubaRPCRequestException(
+                "Invalid trace item filter, empty 'not' clause"
+            )
+        elif len(filters) == 1:
+            return not_cond(trace_item_filters_to_expression(filters[0]))
+        return not_cond(
+            and_cond(*(trace_item_filters_to_expression(x) for x in filters))
+        )
+
     if item_filter.HasField("comparison_filter"):
         k = item_filter.comparison_filter.key
         k_expression = attribute_key_to_expression(k)

tests/web/rpc/v1/test_endpoint_trace_item_table/test_endpoint_trace_item_table.py

@@ -36,6 +36,7 @@
 from sentry_protos.snuba.v1.trace_item_filter_pb2 import (
     ComparisonFilter,
     ExistsFilter,
+    NotFilter,
     OrFilter,
     TraceItemFilter,
 )
@@ -2512,6 +2513,48 @@ def test_non_agg_formula(self, setup_teardown: Any) -> None:
             ),
         ]
 
+    def test_not_filter(setup_teardown: Any) -> None:
+        span_ts = BASE_TIME - timedelta(minutes=1)
+        write_eap_span(span_ts, {"attr1": "value1"}, 10)
+        write_eap_span(span_ts, {"attr1": "value1", "attr2": "value2"}, 10)
+        ts = Timestamp(seconds=int(BASE_TIME.timestamp()))
+        hour_ago = int((BASE_TIME - timedelta(hours=1)).timestamp())
+        message = TraceItemTableRequest(
+            meta=RequestMeta(
+                project_ids=[1, 2, 3],
+                organization_id=1,
+                cogs_category="something",
+                referrer="something",
+                start_timestamp=Timestamp(seconds=hour_ago),
+                end_timestamp=ts,
+                trace_item_type=TraceItemType.TRACE_ITEM_TYPE_SPAN,
+            ),
+            columns=[
+                Column(key=AttributeKey(type=AttributeKey.TYPE_STRING, name="attr1")),
+            ],
+            filter=TraceItemFilter(
+                not_filter=NotFilter(
+                    filters=[
+                        TraceItemFilter(
+                            exists_filter=ExistsFilter(
+                                key=AttributeKey(
+                                    type=AttributeKey.TYPE_STRING, name="attr2"
+                                )
+                            )
+                        )
+                    ]
+                )
+            ),
+            limit=50,
+        )
+        response = EndpointTraceItemTable().execute(message)
+        assert response.column_values == [
+            TraceItemColumnValues(
+                attribute_name="attr1",
+                results=[AttributeValue(val_str="value1") for _ in range(10)],
+            ),
+        ]
+
 
 class TestUtils:
     def test_apply_labels_to_columns_backward_compat(self) -> None: