ref(EAP): uptime doesnt downsample at 30d (#7657)

Not all item types are going to have 30d as the max fidelity retention,
so I added `ITEM_TYPE_FULL_RETENTION` which represents item types that
should allow for more than 30days for `TIER_1` data.

Also updated tests to the the `eap` marker since these tests are pretty
slow otherwise

Author: MeredithAnya

snuba/web/rpc/storage_routing/routing_strategies/common.py

@@ -12,3 +12,7 @@ class Outcome:
     TraceItemType.TRACE_ITEM_TYPE_LOG: DataCategory.LOG_ITEM,
     TraceItemType.TRACE_ITEM_TYPE_METRIC: DataCategory.TRACE_METRIC,
 }
+
+ITEM_TYPE_FULL_RETENTION = {
+    TraceItemType.TRACE_ITEM_TYPE_UPTIME_RESULT,
+}

snuba/web/rpc/storage_routing/routing_strategies/outcomes_based.py

@@ -29,6 +29,7 @@
 )
 from snuba.web.rpc.storage_routing.common import extract_message_meta
 from snuba.web.rpc.storage_routing.routing_strategies.common import (
+    ITEM_TYPE_FULL_RETENTION,
     ITEM_TYPE_TO_OUTCOME_CATEGORY,
     Outcome,
 )
@@ -164,6 +165,7 @@ def _update_routing_decision(
         if (
             state.get_int_config("enable_long_term_retention_downsampling", 0)
             and older_than_thirty_days
+            and in_msg_meta.trace_item_type not in ITEM_TYPE_FULL_RETENTION
         ):
             routing_decision.tier = Tier.TIER_8
 

tests/web/rpc/v1/routing_strategies/test_outcomes_based.py

@@ -32,24 +32,26 @@ def _get_request_meta(
     end: datetime | None = None,
     hour_interval: int | None = None,
     downsampled_storage_config: DownsampledStorageConfig | None = None,
+    trace_item_type: TraceItemType.ValueType | None = None,
 ) -> RequestMeta:
     hour_interval = hour_interval or 24
     start = start or BASE_TIME - timedelta(hours=hour_interval)
     end = end or BASE_TIME
+    trace_item_type = trace_item_type or TraceItemType.TRACE_ITEM_TYPE_SPAN
     return RequestMeta(
         project_ids=[_PROJECT_ID],
         organization_id=_ORG_ID,
         cogs_category="something",
         referrer="something",
         start_timestamp=Timestamp(seconds=int(start.timestamp())),
         end_timestamp=Timestamp(seconds=int(end.timestamp())),
-        trace_item_type=TraceItemType.TRACE_ITEM_TYPE_SPAN,
+        trace_item_type=trace_item_type,
         downsampled_storage_config=downsampled_storage_config,
     )
 
 
 @pytest.fixture
-def store_outcomes_fixture(clickhouse_db: Any) -> None:
+def store_outcomes_fixture(eap: Any) -> None:
     # Generate 24 hours of outcomes data with 1M outcomes per hour
     outcome_data = []
     for hour in range(24):
@@ -59,8 +61,8 @@ def store_outcomes_fixture(clickhouse_db: Any) -> None:
     store_outcomes_data(outcome_data)
 
 
-@pytest.mark.clickhouse_db
 @pytest.mark.redis_db
+@pytest.mark.eap
 def test_outcomes_based_routing_queries_daily_table() -> None:
     strategy = OutcomesBasedRoutingStrategy()
 
@@ -82,7 +84,42 @@ def test_outcomes_based_routing_queries_daily_table() -> None:
     assert routing_decision.can_run
 
 
-@pytest.mark.clickhouse_db
+@pytest.mark.eap
+@pytest.mark.redis_db
+def test_item_type_full_retention() -> None:
+    """
+    Certain item types will not use the long term retention downsampling,
+    find them in ITEM_TYPE_FULL_RETENTION routing_strategies/common.py
+    """
+    state.set_config(
+        "enable_long_term_retention_downsampling",
+        1,
+    )
+    strategy = OutcomesBasedRoutingStrategy()
+
+    # request that queries last 50 days of data
+    end_time = datetime.now(UTC).replace(hour=0, minute=0, second=0, microsecond=0)
+    start_time = end_time - timedelta(hours=1200)  # 50 days
+    request = TraceItemTableRequest(
+        meta=_get_request_meta(
+            start=start_time,
+            end=end_time,
+            trace_item_type=TraceItemType.TRACE_ITEM_TYPE_UPTIME_RESULT,
+        )
+    )
+    request.meta.downsampled_storage_config.mode = DownsampledStorageConfig.MODE_NORMAL
+    context = RoutingContext(
+        in_msg=request,
+        timer=Timer("test"),
+        query_id=uuid.uuid4().hex,
+    )
+    routing_decision = strategy.get_routing_decision(context)
+    assert routing_decision.tier == Tier.TIER_1
+    assert routing_decision.clickhouse_settings == {"max_threads": 10}
+    assert routing_decision.can_run
+
+
+@pytest.mark.eap
 @pytest.mark.redis_db
 def test_outcomes_based_routing_sampled_data_past_thirty_days() -> None:
     state.set_config(
@@ -156,7 +193,7 @@ def test_outcomes_based_routing_sampled_data_past_thirty_days() -> None:
     assert routing_decision.can_run
 
 
-@pytest.mark.clickhouse_db
+@pytest.mark.eap
 @pytest.mark.redis_db
 def test_outcomes_based_routing_normal_mode(store_outcomes_fixture: Any) -> None:
     strategy = OutcomesBasedRoutingStrategy()
@@ -176,7 +213,7 @@ def test_outcomes_based_routing_normal_mode(store_outcomes_fixture: Any) -> None
     assert routing_decision.can_run
 
 
-@pytest.mark.clickhouse_db
+@pytest.mark.eap
 @pytest.mark.redis_db
 def test_outcomes_based_routing_downsample(store_outcomes_fixture: Any) -> None:
     state.set_config("OutcomesBasedRoutingStrategy.max_items_before_downsampling", 5_000_000)
@@ -220,7 +257,7 @@ def test_outcomes_based_routing_downsample(store_outcomes_fixture: Any) -> None:
     assert routing_decision.can_run
 
 
-@pytest.mark.clickhouse_db
+@pytest.mark.eap
 @pytest.mark.redis_db
 def test_outcomes_based_routing_highest_accuracy_mode(store_outcomes_fixture: Any) -> None:
     strategy = OutcomesBasedRoutingStrategy()
@@ -240,7 +277,7 @@ def test_outcomes_based_routing_highest_accuracy_mode(store_outcomes_fixture: An
     assert routing_decision.can_run
 
 
-@pytest.mark.clickhouse_db
+@pytest.mark.eap
 @pytest.mark.redis_db
 def test_outcomes_based_routing_defaults_to_tier1_for_unspecified_item_type(
     store_outcomes_fixture: Any,