fix(TraceItemsDetails): dedupe int,bool and float attrs (#7260)

Addresses
[EAP-121](https://linear.app/getsentry/issue/EAP-121/traceitemdetails-endpoint-should-merge-attributes-without-leaving)

For `bool` and `int` attributes, we also store a `float` version in the
database to simplify aggregations. When returning data to the user we
should only return the original type, and ignore the float duplicate.

Waiting on getsentry/sentry#94553 to be merged
before I can merge this PR

Author: MeredithAnya

snuba/web/rpc/v1/endpoint_trace_item_details.py

@@ -174,17 +174,28 @@ def _convert_results(
 
     for k, v in row["attributes_string"].items():
         attrs.append(TraceItemDetailsAttribute(name=k, value=AttributeValue(val_str=v)))
-    for k, v in row["attributes_float"].items():
-        attrs.append(
-            TraceItemDetailsAttribute(name=k, value=AttributeValue(val_double=v))
-        )
+
+    int_attr_names = set()
     for k, v in row["attributes_int"].items():
+        int_attr_names.add(k)
         attrs.append(TraceItemDetailsAttribute(name=k, value=AttributeValue(val_int=v)))
+
+    bool_attr_names = set()
     for k, v in row["attributes_bool"].items():
+        bool_attr_names.add(k)
         attrs.append(
             TraceItemDetailsAttribute(name=k, value=AttributeValue(val_bool=v))
         )
 
+    for k, v in row["attributes_float"].items():
+        if k in int_attr_names or k in bool_attr_names:
+            # for bool & int attributes, we also store a float version in the database
+            # to simplfy aggregations. when returning data to the user we should only return
+            # the original type, and ignore the float duplicate
+            continue
+        attrs.append(
+            TraceItemDetailsAttribute(name=k, value=AttributeValue(val_double=v))
+        )
     return item_id, timestamp, attrs
 
 

tests/web/rpc/v1/test_endpoint_trace_item_details.py

@@ -18,7 +18,10 @@
 
 from snuba.datasets.storages.factory import get_storage
 from snuba.datasets.storages.storage_key import StorageKey
-from snuba.web.rpc.v1.endpoint_trace_item_details import EndpointTraceItemDetails
+from snuba.web.rpc.v1.endpoint_trace_item_details import (
+    EndpointTraceItemDetails,
+    _convert_results,
+)
 from snuba.web.rpc.v1.endpoint_trace_item_table import EndpointTraceItemTable
 from tests.base import BaseApiTest
 from tests.helpers import write_raw_unprocessed_events
@@ -325,3 +328,36 @@ def test_endpoint_on_spans(self, setup_spans_in_db: Any) -> None:
             "str_tag",
         }:
             assert k in attributes_returned, k
+
+
+def test_convert_results_dedupes() -> None:
+    """
+    Makes sure that _convert_results dedupes int/bool and float
+    attributes. We store float versions of int and bool attributes
+    for computational reasons but we don't want to return the
+    duplicate float attrs to the user.
+    """
+    data = [
+        {
+            "timestamp": 1750964400,
+            "hex_item_id": "e70ef5b1b5bc4611840eff9964b7a767",
+            "trace_id": "cb190d6e7d5743d5bc1494c650592cd2",
+            "organization_id": 1,
+            "project_id": 1,
+            "item_type": 1,
+            "attributes_string": {
+                "relay_protocol_version": "3",
+                "sentry.segment_id": "30c64b1f21b54799",
+            },
+            "attributes_int": {"sentry.duration_ms": 152},
+            "attributes_float": {"sentry.is_segment": 1.0, "num_of_spans": 50.0},
+            "attributes_bool": {
+                "my.true.bool.field": True,
+                "sentry.is_segment": True,
+                "my.false.bool.field": False,
+            },
+        }
+    ]
+    _, _, attrs = _convert_results(data)
+    is_segment_attrs = list(filter(lambda x: x.name == "sentry.is_segment", attrs))
+    assert len(is_segment_attrs) == 1