chore: bump rust-toolchain to 1.88.0 (#7835)

Required to get https://github.com/getsentry/sentry-options working for
snuba

Author: MeredithAnya

rust_snuba/rust-toolchain.toml

@@ -1,2 +1,2 @@
 [toolchain]
-channel = "1.85.0"
+channel = "1.88.0"

rust_snuba/src/consumer.rs

@@ -324,7 +324,7 @@ pub fn process_message(
     // XXX: Currently only takes the message payload and metadata. This assumes
     // key and headers are not used for message processing
     let func = processors::get_processing_function(name).ok_or(SnubaRustError::new_err(
-        format!("processor '{}' not found", name),
+        format!("processor '{name}' not found"),
     ))?;
 
     let payload = KafkaPayload::new(None, None, Some(value));
@@ -338,15 +338,15 @@ pub fn process_message(
     match func {
         processors::ProcessingFunctionType::ProcessingFunction(f) => {
             let res = f(payload, meta, &config::ProcessorConfig::default())
-                .map_err(|e| SnubaRustError::new_err(format!("invalid message: {:?}", e)))?;
+                .map_err(|e| SnubaRustError::new_err(format!("invalid message: {e:?}")))?;
 
             let payload = PyBytes::new(py, &res.rows.into_encoded_rows()).into();
 
             Ok((Some(payload), None))
         }
         processors::ProcessingFunctionType::ProcessingFunctionWithReplacements(f) => {
             let res = f(payload, meta, &config::ProcessorConfig::default())
-                .map_err(|e| SnubaRustError::new_err(format!("invalid message: {:?}", e)))?;
+                .map_err(|e| SnubaRustError::new_err(format!("invalid message: {e:?}")))?;
 
             match res {
                 InsertOrReplacement::Insert(r) => {

rust_snuba/src/metrics/statsd.rs

@@ -29,7 +29,7 @@ impl MetricSink for Wrapper {
 
 impl StatsDBackend {
     pub fn new(host: &str, port: u16, prefix: &str) -> Self {
-        let upstream_addr = format!("{}:{}", host, port);
+        let upstream_addr = format!("{host}:{port}");
         let aggregator_sink = StatsdProxyMetricSink::new(move || {
             let upstream = Upstream::new(upstream_addr.clone()).unwrap();
 

rust_snuba/src/processors/eap_items.rs

@@ -1007,7 +1007,7 @@ mod tests {
         // Verify bucketed string attributes have the same content
         // "str_attr" should be in one of the string buckets
         let str_bucket = (fnv_1a("str_attr".as_bytes()) as usize) % 40;
-        let json_field = format!("attributes_string_{}", str_bucket);
+        let json_field = format!("attributes_string_{str_bucket}");
         let json_str_map: HashMap<String, String> = json_row
             .get(&json_field)
             .map(|v| serde_json::from_value(v.clone()).unwrap())
@@ -1070,8 +1070,7 @@ mod tests {
         assert_eq!(
             rb_str_val,
             Some(&"hello".to_string()),
-            "str_attr not found in RowBinary output bucket {}",
-            str_bucket
+            "str_attr not found in RowBinary output bucket {str_bucket}"
         );
         assert_eq!(
             json_str_map.get("str_attr"),
@@ -1082,7 +1081,7 @@ mod tests {
         // Verify float attribute is in the correct bucket (int_attr and bool_attr are
         // double-written as floats)
         let float_bucket = (fnv_1a("float_attr".as_bytes()) as usize) % 40;
-        let json_float_field = format!("attributes_float_{}", float_bucket);
+        let json_float_field = format!("attributes_float_{float_bucket}");
         let json_float_map: HashMap<String, f64> = json_row
             .get(&json_float_field)
             .map(|v| serde_json::from_value(v.clone()).unwrap())
@@ -1127,7 +1126,7 @@ mod tests {
         let database = std::env::var("CLICKHOUSE_DATABASE").unwrap_or("default".to_string());
 
         let client = clickhouse::Client::default()
-            .with_url(format!("http://{}:{}", host, http_port))
+            .with_url(format!("http://{host}:{http_port}"))
             .with_database(&database)
             .with_option("input_format_binary_read_json_as_string", "1")
             .with_option("insert_deduplicate", "0");
@@ -1193,8 +1192,7 @@ mod tests {
         // Read it back using organization_id (primary key prefix) for reliable lookup
         let count: u64 = client
             .query(&format!(
-                "SELECT count() FROM eap_items_1_local WHERE organization_id = {}",
-                unique_org_id
+                "SELECT count() FROM eap_items_1_local WHERE organization_id = {unique_org_id}"
             ))
             .fetch_one()
             .await
@@ -1208,9 +1206,8 @@ mod tests {
             .query(&format!(
                 "SELECT organization_id, project_id, item_type, sampling_weight \
                  FROM eap_items_1_local \
-                 WHERE organization_id = {} \
-                 LIMIT 1",
-                unique_org_id
+                 WHERE organization_id = {unique_org_id} \
+                 LIMIT 1"
             ))
             .fetch_one::<(u64, u64, u8, u64)>()
             .await
@@ -1224,8 +1221,7 @@ mod tests {
         // Clean up
         client
             .query(&format!(
-                "ALTER TABLE eap_items_1_local DELETE WHERE organization_id = {}",
-                unique_org_id
+                "ALTER TABLE eap_items_1_local DELETE WHERE organization_id = {unique_org_id}"
             ))
             .execute()
             .await

rust_snuba/src/processors/errors.rs

@@ -90,6 +90,7 @@ pub fn process_message_with_replacement(
 
 #[derive(Debug, Deserialize, JsonSchema)]
 #[serde(untagged)]
+#[allow(clippy::large_enum_variant)]
 enum Message {
     FourTrain(FourTrain),
     ThreeTrain(ThreeTrain),
@@ -548,7 +549,7 @@ impl ErrorRow {
             for (key, value) in container.unwrap_or_default() {
                 if let Some(v) = value.0 {
                     if key != "type" {
-                        contexts_keys.push(format!("{}.{}", container_name, key));
+                        contexts_keys.push(format!("{container_name}.{key}"));
                         contexts_values.push(v);
                     }
                 }

rust_snuba/src/rebalancing.rs

@@ -30,11 +30,7 @@ pub fn delay_kafka_rebalance(configured_delay_secs: u64) {
 
 pub fn get_rebalance_delay_secs(consumer_group: &str) -> Option<u64> {
     runtime_config::get_str_config(
-        format!(
-            "quantized_rebalance_consumer_group_delay_secs__{}",
-            consumer_group
-        )
-        .as_str(),
+        format!("quantized_rebalance_consumer_group_delay_secs__{consumer_group}").as_str(),
     )
     .ok()??
     .parse()

rust_snuba/src/strategies/clickhouse/writer_v2.rs

@@ -318,7 +318,7 @@ mod tests {
     async fn it_works() -> Result<(), reqwest::Error> {
         crate::testutils::initialize_python();
         let config = make_test_config();
-        println!("config: {:?}", config);
+        println!("config: {config:?}");
         let client = ClickhouseClient::new(&config, "querylog_local", "test_storage".to_string());
 
         let url = client.build_url();

rust_snuba/src/strategies/processor.rs

@@ -535,8 +535,7 @@ mod tests {
             assert_eq!(
                 IP_REGEX.is_match(address),
                 is_ipv4,
-                "{} failed IPv4 validation",
-                address
+                "{address} failed IPv4 validation"
             );
         }
     }