Skip to content

Commit beabc91

Browse files
Revert "feat(eap): Allow to coalesce specific attributes (#7269)"
This reverts commit 69a8b3f. Co-authored-by: volokluev <[email protected]>
1 parent 69a8b3f commit beabc91

File tree

10 files changed

+359
-290
lines changed

10 files changed

+359
-290
lines changed

snuba/web/rpc/v1/endpoint_get_trace.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
)
3838
from snuba.web.rpc.common.exceptions import BadSnubaRPCRequestException
3939
from snuba.web.rpc.v1.resolvers.R_eap_items.common.common import (
40-
attribute_key_to_expression,
40+
attribute_key_to_expression_eap_items,
4141
)
4242

4343
NORMALIZED_COLUMNS_TO_INCLUDE_EAP_ITEMS = [
@@ -53,7 +53,7 @@ def _build_query(request: GetTraceRequest, item: GetTraceRequest.TraceItem) -> Q
5353
SelectedExpression(
5454
name="id",
5555
expression=(
56-
attribute_key_to_expression(
56+
attribute_key_to_expression_eap_items(
5757
AttributeKey(
5858
name="sentry.item_id", type=AttributeKey.Type.TYPE_STRING
5959
)
@@ -64,7 +64,7 @@ def _build_query(request: GetTraceRequest, item: GetTraceRequest.TraceItem) -> Q
6464
name="timestamp",
6565
expression=f.cast(
6666
(
67-
attribute_key_to_expression(
67+
attribute_key_to_expression_eap_items(
6868
AttributeKey(
6969
name="sentry.start_timestamp_precise",
7070
type=AttributeKey.Type.TYPE_DOUBLE,
@@ -82,7 +82,7 @@ def _build_query(request: GetTraceRequest, item: GetTraceRequest.TraceItem) -> Q
8282
selected_columns.append(
8383
SelectedExpression(
8484
name=attribute_key.name,
85-
expression=(attribute_key_to_expression(attribute_key)),
85+
expression=(attribute_key_to_expression_eap_items(attribute_key)),
8686
)
8787
)
8888
else:

snuba/web/rpc/v1/endpoint_get_traces.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
)
4646
from snuba.web.rpc.common.exceptions import BadSnubaRPCRequestException
4747
from snuba.web.rpc.v1.resolvers.R_eap_items.common.common import (
48-
attribute_key_to_expression,
48+
attribute_key_to_expression_eap_items,
4949
)
5050

5151
_DEFAULT_ROW_LIMIT = 10_000
@@ -143,7 +143,7 @@ def _get_attribute_expression(
143143
attribute_type: AttributeKey.Type.ValueType,
144144
request_meta: RequestMeta,
145145
) -> Expression:
146-
return attribute_key_to_expression(
146+
return attribute_key_to_expression_eap_items(
147147
AttributeKey(name=attribute_name, type=attribute_type)
148148
)
149149

@@ -427,7 +427,7 @@ def _list_trace_ids(
427427
) -> list[str]:
428428
trace_item_filters_expression = trace_item_filters_to_expression(
429429
_select_supported_filters(request.filters),
430-
(attribute_key_to_expression),
430+
(attribute_key_to_expression_eap_items),
431431
)
432432
selected_columns: list[SelectedExpression] = [
433433
SelectedExpression(
@@ -491,7 +491,7 @@ def _get_metadata_for_traces(
491491
) -> list[GetTracesResponse.Trace]:
492492
trace_item_filters_expression = trace_item_filters_to_expression(
493493
_select_supported_filters(request.filters),
494-
(attribute_key_to_expression),
494+
(attribute_key_to_expression_eap_items),
495495
)
496496

497497
selected_columns: list[SelectedExpression] = []

0 commit comments

Comments
 (0)