ref(consumer): change BytesInsertBatch to support builder pattern #7479
+103
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phacops
approved these changes
Nov 19, 2025
volokluev
approved these changes
Nov 19, 2025
onewland
added a commit
that referenced
this pull request
Nov 25, 2025
Emit how many events by type are being processed by the EAP consumer. This is being split into 3 changes: - change how we build BytesInsertBatch to support a builder pattern (so it's more simple to omit dataset-specific fields): #7479 (merged) - (this change) start keeping track of how many items by type are being processed in the EAPItems processor - emit the actual metric at the end of a batch write
onewland
added a commit
that referenced
this pull request
Dec 2, 2025
Emit how many events by type are being processed by the EAP consumer. This is being split into 3 changes: - change how we build BytesInsertBatch to support a builder pattern (so it's more simple to omit dataset-specific fields): #7479 (merged) - start keeping track of how many items by type are being processed in the EAPItems processor: #7481 - (this change) emit the actual metric at the end of a batch write
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to start emitting how many events by type are being processed by the EAP consumer. I'm dividing that up into 3 changes: