From 020767f4b47a7c9ba1ac68ab7f5672538b02fcb6 Mon Sep 17 00:00:00 2001 From: Volo Kluev Date: Mon, 5 Jan 2026 15:15:56 -0800 Subject: [PATCH] don't write the histogram timing metrics --- snuba/utils/metrics/backends/dualwrite.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/snuba/utils/metrics/backends/dualwrite.py b/snuba/utils/metrics/backends/dualwrite.py index 3bdb49af2d5..2c797808747 100644 --- a/snuba/utils/metrics/backends/dualwrite.py +++ b/snuba/utils/metrics/backends/dualwrite.py @@ -29,10 +29,10 @@ def _use_sentry(self) -> bool: return bool(random.random() < settings.DDM_METRICS_SAMPLE_RATE) return False - def _write_timings_as_distributions(self) -> bool: + def _write_timings_as_histograms(self) -> bool: from snuba import state - return str(state.get_config("write_timings_as_distributions", "0")) == "1" + return str(state.get_config("write_timings_as_histograms", "1")) == "1" def increment( self, @@ -67,11 +67,11 @@ def timing( # would then calculate percentiles. datadog now supports direct aggregations of percentiles # we keep the veneur timing metric to maintain historical data, this should be removed by # 02/15/2026 once we have enough historical data already - self.datadog.timing(name, value, tags, unit) + self.datadog.distribution(f"{name}.distribution", value, tags, unit) + if self._write_timings_as_histograms(): + self.datadog.timing(name, value, tags, unit) if self._use_sentry(): self.sentry.timing(name, value, tags, unit) - if self._write_timings_as_distributions(): - self.datadog.distribution(f"{name}.distribution", value, tags, unit) def distribution( self,