Skip to content

Commit 1d265d9

Browse files
authored
fix(overlay): Don't crash on missing stracktrace.frames (#858)
Fixes SPOTLIGHT-CLI-1J
1 parent 66eb0ea commit 1d265d9

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

.changeset/quiet-sides-sink.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@spotlightjs/overlay": patch
3+
---
4+
5+
Fix crash on the rare case when an exception has a stacktrace property but not frames under it

packages/overlay/src/integrations/sentry/store/slices/sharedSlice.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,12 @@ export const createSharedSlice: StateCreator<SentryStore, [], [], SharedSliceAct
2323

2424
await Promise.all(
2525
(errorEvent.exception.values ?? []).map(async exception => {
26-
if (!exception.stacktrace) {
26+
if (!exception.stacktrace || !exception.stacktrace.frames) {
2727
return;
2828
}
2929
exception.stacktrace.frames.reverse();
3030

31-
if (
32-
exception.stacktrace.frames?.every(frame => frame.post_context && frame.pre_context && frame.context_line)
33-
) {
31+
if (exception.stacktrace.frames.every(frame => frame.post_context && frame.pre_context && frame.context_line)) {
3432
log("Skipping contextlines request as we have full context for", exception);
3533
return;
3634
}

0 commit comments

Comments
 (0)