Skip to content

Commit 334c620

Browse files
committed
fix: Show something to account for empty strings (#656)
1 parent 2640a14 commit 334c620

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

.changeset/three-geckos-look.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
---
2+
'@spotlightjs/spotlight': major
3+
'@spotlightjs/electron': major
4+
'@spotlightjs/tsconfig': major
5+
'@spotlightjs/overlay': major
6+
'@spotlightjs/sidecar': major
7+
'@spotlightjs/astro': major
8+
---
9+
10+
Render placeholders when missing known attributes in Sentry events

packages/overlay/src/integrations/sentry/components/events/Event.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export function EventTitle({ event }: { event: SentryEvent }) {
1818
return <ErrorTitle event={event} />;
1919
}
2020

21-
return <strong className="font-bold">{getEventMessage(event)}</strong>;
21+
return <strong className="font-bold">{getEventMessage(event) || <em>Unknown Event</em>}</strong>;
2222
}
2323

2424
export function EventSummary({ event }: { event: SentryEvent }) {
@@ -28,7 +28,7 @@ export function EventSummary({ event }: { event: SentryEvent }) {
2828
return (
2929
<div className="space-y-4 font-mono">
3030
<h3 className="flex flex-col">
31-
<strong className="text-xl">{getEventMessage(event)}</strong>
31+
<strong className="text-xl">{getEventMessage(event) || <em>Unknown Event</em>}</strong>
3232
</h3>
3333
</div>
3434
);
@@ -43,7 +43,7 @@ export default function Event({ event }: { event: SentryEvent }) {
4343
<div className="flex-1 px-6 py-4">
4444
<h3 className="bg-primary-950 flex flex-col">
4545
<strong className="text-xl">Message:</strong>
46-
<pre>{getEventMessage(event)}</pre>
46+
<pre>{getEventMessage(event) || <em>No message</em>}</pre>
4747
</h3>
4848
</div>
4949
);

0 commit comments

Comments
 (0)