Skip to content

Commit 8363843

Browse files
BYKcursoragent
andauthored
Qs security vulnerability fix (#1226)
Fix: Upgrade `qs` to 6.14.1 to address DoS vulnerability This PR addresses a security vulnerability in the `qs` package where its `arrayLimit` bypass in bracket notation (`a[]=1&a[]=2`) allows Denial-of-Service (DoS) via memory exhaustion. The `qs` package was a transitive dependency at version `6.14.0`, which is vulnerable. Dependabot could not automatically update it to the patched version `6.14.1`. To mitigate this, `qs` has been explicitly added to the `resolutions` section in `package.json` (and `overrides` in `pnpm-lock.yaml`), forcing the installation of version `6.14.1` or higher. **Verification:** - `qs` updated from 6.14.0 to 6.14.1. - Linting and build processes completed successfully. <!-- Tick these boxes if they're applicable to your PR. - Changesets are only required for PRs to Spotlight library packages (e.g. @spotlightjs/overlay). Not for the website/docs or demo app contributions. - Typo correction or small bugfix PRs don't require an issue. If you're making a bigger change, please open an issue first. --> Before opening this PR: - [ ] I added a [Changeset Entry](https://spotlightjs.com/contribute/changesets/) with `pnpm changeset:add` - [ ] I referenced issues that this PR addresses --- <a href="https://cursor.com/background-agent?bcId=bc-229a24b1-d070-4f0a-8e75-5ad147de75d0"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-229a24b1-d070-4f0a-8e75-5ad147de75d0"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a> Co-authored-by: Cursor Agent <cursoragent@cursor.com>
1 parent 8986f33 commit 8363843

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@
3737
"tmp": ">=0.2.4",
3838
"js-yaml": ">=4.1.1",
3939
"body-parser": ">=2.2.1",
40-
"mdast-util-to-hast": ">=13.2.1"
40+
"mdast-util-to-hast": ">=13.2.1",
41+
"qs": ">=6.14.1"
4142
},
4243
"pnpm": {
4344
"overrides": {

pnpm-lock.yaml

Lines changed: 6 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)