feat(symsorter): Allow + in bundle IDs (#1772)

Author: donalmacc

CHANGELOG.md

@@ -8,6 +8,9 @@
   - [changelog](https://github.com/getsentry/sentry-native/blob/master/CHANGELOG.md#0100)
   - [diff](https://github.com/getsentry/sentry-native/compare/0.9.1...0.10.0)
 
+### Various fixes & improvements
+- Added support for + in SymSorter Bundle ID's. ([#1772](https://github.com/getsentry/symbolicator/pull/1772))
+
 ## 25.8.0
 
 ### Dependencies
@@ -93,7 +96,7 @@
 ### Various fixes & improvements
 
 - Speed up large file downloads, by using multiple concurrent http range requests. ([#1670](https://github.com/getsentry/symbolicator/pull/1670))
-- Validate stack scanned candidate frames against available CFI unwind information. 
+- Validate stack scanned candidate frames against available CFI unwind information.
   This reduces hallucinated frames when relying on stack scanning. ([#1651](https://github.com/getsentry/symbolicator/pull/1651))
 - Logic for setting the in-app property on frames has been removed from JavaScript symbolication. ([#1656](https://github.com/getsentry/symbolicator/pull/1656))
 - Added support for indexes for symbol sources.

crates/symsorter/src/utils.rs

@@ -10,7 +10,7 @@ use symbolic::common::ByteView;
 use symbolic::debuginfo::sourcebundle::{SourceBundleWriter, SourceFileDescriptor};
 use symbolic::debuginfo::{Archive, FileEntry, FileFormat, Object, ObjectKind};
 
-static BAD_CHARS_RE: LazyLock<Regex> = LazyLock::new(|| Regex::new(r"[^a-zA-Z0-9.,-]+").unwrap());
+static BAD_CHARS_RE: LazyLock<Regex> = LazyLock::new(|| Regex::new(r"[^a-zA-Z0-9.,+-]+").unwrap());
 
 /// Console logging for the symsorter app.
 #[macro_export]
@@ -120,3 +120,20 @@ pub fn create_source_bundle(path: &Path, unified_id: &str) -> Result<Option<Byte
     }
     Ok(None)
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn is_bundle_id_checks() {
+        let good_input_id = "10.3_ABCD";
+        assert!(is_bundle_id(good_input_id));
+
+        let bad_input_id = "10.3.*";
+        assert!(!is_bundle_id(bad_input_id));
+
+        let unreal_bundle_id = "++lyra+main-CL-12345";
+        assert!(is_bundle_id(unreal_bundle_id));
+    }
+}