feat: devenv, uv, pre-commit #1770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
joshuarli
force-pushed
the
feat-devenv-pre-commit-devservices
branch
from
01cba11 to
503daa7
Compare
This reverts commit d08cbec.
joshuarli
commented
Aug 21, 2025
Merged
Contributor
|
I honestly question the utility of |
Member
Author
Yeah, I just realized clippy/clippy-driver is a wrapper around rustc - rust linting inherently requires compilation, making it too slow for pre-commit anyways. |
joshuarli
added a commit
that referenced
this pull request
Sep 4, 2025
prerequisite to #1770 we need python >= 3.11 since that's what our internal pypi supports (getsentry/pypi#1610)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces devenv, uv and pre-commit in accordance with these repo standards:
https://www.notion.so/sentry/Standard-Spec-devenv-2238b10e4b5d8072a992d8b67d94be22
https://www.notion.so/sentry/Standard-Spec-python-uv-2248b10e4b5d8045b8fff30f8b8b67ca
https://www.notion.so/sentry/Standard-Spec-pre-commit-2238b10e4b5d8019aa1fe1158e39c38e
The ability to run
devenv syncand get a dev environment in any repo is the DX i'm aiming for,and these standards provide a foundation from which later we can easily push updates to all repos.
You should be able to checkout this branch, run
direnv allowanddevenv sync(might be prompted to run~/.local/share/sentry-devenv/bin/devenv updatefirst), which will set up everything needed for development (other than cargo).Notes:
rustfmtas a local pre-commit hook (need to keep the rust edition in sync with cargo.toml it seems) but it seems like clippy doesn't work on individual files (perhaps clippy-driver?) - anyway, decided not to touch these parts for now to keep things simple.