Skip to content

Commit c564359

Browse files
authored
fix(uptime): don't report monitor_task_ended as an error (#492)
This isn't an error for canary checkers, as they are in readonly mode and aren't supposed to monitor tasks, and so exit immediately. For the regular checkers, this is okay too (since the monitor task is looking at the shutdown signal as well.)
1 parent 90274ed commit c564359

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/check_config_provider/redis_config_provider.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,6 +321,8 @@ pub fn run_config_provider(
321321
.await
322322
});
323323

324+
// The monitor task also responds to the shutdown event, but it's possible it could be
325+
// stuck doing other things, so we race it here, too.
324326
tokio::select! {
325327
_ = shutdown.cancelled() => {
326328
tracing::info!("redis_config_provider.shutdown_requested");
@@ -329,7 +331,7 @@ pub fn run_config_provider(
329331
manager.update_partitions(&HashSet::default());
330332
}
331333
_ = monitor_task => {
332-
tracing::error!("redis_config_provider.monitor_task_ended");
334+
tracing::info!("redis_config_provider.monitor_task_ended");
333335
}
334336
}
335337
})

0 commit comments

Comments
 (0)