Skip to content

Commit 69cd3a1

Browse files
committed
backends/eopkg: Remove network checks in C wrapper
These checks actually break more than they fix, for example it is legitimate to only work with local repos and, importantly it breaks offline updates.
1 parent 3d12493 commit 69cd3a1

File tree

1 file changed

+0
-21
lines changed

1 file changed

+0
-21
lines changed

backends/eopkg/pk-backend-eopkg.c

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -242,13 +242,6 @@ pk_backend_install_packages (PkBackend *backend, PkBackendJob *job, PkBitfield t
242242
gchar *package_ids_temp;
243243
gchar *transaction_flags_temp;
244244

245-
/* check network state */
246-
if (!pk_backend_is_online (backend)) {
247-
pk_backend_job_error_code (job, PK_ERROR_ENUM_NO_NETWORK, "Cannot install when offline");
248-
pk_backend_job_finished (job);
249-
return;
250-
}
251-
252245
/* send the complete list as stdin */
253246
package_ids_temp = pk_package_ids_to_string (package_ids);
254247
transaction_flags_temp = pk_transaction_flag_bitfield_to_string (transaction_flags);
@@ -280,13 +273,6 @@ void
280273
pk_backend_refresh_cache (PkBackend *backend, PkBackendJob *job, gboolean force)
281274
{
282275
const gchar *backend_filename = NULL;
283-
/* check network state */
284-
if (!pk_backend_is_online (backend)) {
285-
pk_backend_job_error_code (job, PK_ERROR_ENUM_NO_NETWORK, "Cannot refresh cache whilst offline");
286-
pk_backend_job_finished (job);
287-
return;
288-
}
289-
290276
backend_filename = eopkg_get_backend_filename ();
291277

292278
pk_backend_spawn_helper (spawn, job, backend_filename, "refresh-cache", pk_backend_bool_to_string (force), NULL);
@@ -392,13 +378,6 @@ pk_backend_update_packages (PkBackend *backend, PkBackendJob *job, PkBitfield tr
392378
gchar *package_ids_temp;
393379
gchar *transaction_flags_temp;
394380

395-
/* check network state */
396-
if (!pk_backend_is_online (backend)) {
397-
pk_backend_job_error_code (job, PK_ERROR_ENUM_NO_NETWORK, "Cannot install when offline");
398-
pk_backend_job_finished (job);
399-
return;
400-
}
401-
402381
/* send the complete list as stdin */
403382
package_ids_temp = pk_package_ids_to_string (package_ids);
404383
transaction_flags_temp = pk_transaction_flag_bitfield_to_string (transaction_flags);

0 commit comments

Comments
 (0)