Skip to content

Commit 90c18b3

Browse files
committed
backends/eopkg: Remove network checks in C wrapper
These checks actually break more than they fix, for example it is legitimate to only work with local repos and, importantly it breaks offline updates.
1 parent 331506e commit 90c18b3

File tree

1 file changed

+0
-21
lines changed

1 file changed

+0
-21
lines changed

backends/eopkg/pk-backend-eopkg.c

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -233,13 +233,6 @@ pk_backend_install_packages (PkBackend *backend, PkBackendJob *job, PkBitfield t
233233
gchar *package_ids_temp;
234234
gchar *transaction_flags_temp;
235235

236-
/* check network state */
237-
if (!pk_backend_is_online (backend)) {
238-
pk_backend_job_error_code (job, PK_ERROR_ENUM_NO_NETWORK, "Cannot install when offline");
239-
pk_backend_job_finished (job);
240-
return;
241-
}
242-
243236
/* send the complete list as stdin */
244237
package_ids_temp = pk_package_ids_to_string (package_ids);
245238
transaction_flags_temp = pk_transaction_flag_bitfield_to_string (transaction_flags);
@@ -271,13 +264,6 @@ void
271264
pk_backend_refresh_cache (PkBackend *backend, PkBackendJob *job, gboolean force)
272265
{
273266
const gchar *backend_filename = NULL;
274-
/* check network state */
275-
if (!pk_backend_is_online (backend)) {
276-
pk_backend_job_error_code (job, PK_ERROR_ENUM_NO_NETWORK, "Cannot refresh cache whilst offline");
277-
pk_backend_job_finished (job);
278-
return;
279-
}
280-
281267
backend_filename = eopkg_get_backend_filename ();
282268

283269
pk_backend_spawn_helper (spawn, job, backend_filename, "refresh-cache", pk_backend_bool_to_string (force), NULL);
@@ -383,13 +369,6 @@ pk_backend_update_packages (PkBackend *backend, PkBackendJob *job, PkBitfield tr
383369
gchar *package_ids_temp;
384370
gchar *transaction_flags_temp;
385371

386-
/* check network state */
387-
if (!pk_backend_is_online (backend)) {
388-
pk_backend_job_error_code (job, PK_ERROR_ENUM_NO_NETWORK, "Cannot install when offline");
389-
pk_backend_job_finished (job);
390-
return;
391-
}
392-
393372
/* send the complete list as stdin */
394373
package_ids_temp = pk_package_ids_to_string (package_ids);
395374
transaction_flags_temp = pk_transaction_flag_bitfield_to_string (transaction_flags);

0 commit comments

Comments
 (0)