Skip to content

Commit f2e817c

Browse files
committed
backends/eopkg: Make repo_set_data() use privileged decorator
We need to ensure the dbs get reinitalized after a repo change. Also, fix a small python2 -> python3 syntax issue.
1 parent db1a9a9 commit f2e817c

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

backends/eopkg/eopkgBackend.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -834,30 +834,31 @@ def progress_cb(**kw):
834834
self.error(ERROR_CANNOT_REMOVE_SYSTEM_PACKAGE, e)
835835
pisi.api.set_userinterface(self.saved_ui)
836836

837-
def repo_set_data(self, repo_id, parameter, value):
837+
@privileged
838+
def repo_set_data(self, repoid, parameter, value):
838839
""" Sets a parameter for the repository specified """
839840
self.allow_cancel(False)
840841
self.percentage(None)
841842

842843
if parameter == "add-repo":
843844
try:
844-
pisi.api.add_repo(repo_id, value, parameter)
845-
except pisi.Error, e:
845+
pisi.api.add_repo(repoid, value)
846+
except pisi.Error as e:
846847
self.error(ERROR_UNKNOWN, e)
847848

848849
try:
849-
pisi.api.update_repo(repo_id)
850+
pisi.api.update_repo(repoid)
850851
except pisi.fetcher.FetchError:
851-
pisi.api.remove_repo(repo_id)
852+
pisi.api.remove_repo(repoid)
852853
err = "Could not reach the repository, removing from system"
853854
self.error(ERROR_REPO_NOT_FOUND, err)
854855
elif parameter == "remove-repo":
855856
try:
856-
pisi.api.remove_repo(repo_id)
857+
pisi.api.remove_repo(repoid)
857858
except pisi.Error:
858859
self.error(ERROR_REPO_NOT_FOUND, "Repository does not exist")
859860
else:
860-
self.error(ERROR_NOT_SUPPORTED, "Parameter not supported")
861+
self.error(ERROR_NOT_SUPPORTED, "Valid parameters are add-repo and remove-repo")
861862

862863
def resolve(self, filters, values):
863864
""" Turns a single package name into a package_id

0 commit comments

Comments
 (0)