Merge pull request #175 from getsolus/fix-metadata-mess

Author: sheepman4267

pisi/operations/remove.py

@@ -136,7 +136,11 @@ def remove(
     finally:
         ctx.exec_usysconf()
 
-    return True
+    # Prior to 2c63650, this function had no return statement at all on the "complete" codepath.
+    # 2c63650 added a "return True". Unfortunately, it appears that "False" means "Ask the user for confirmation",
+    # "True" means "the operation failed", and "None" means "Success". Why? No idea! But removing the return statement
+    # or returning None fixes #173, so... do what works, I guess.
+    return None
 
 
 def remove_orphans(ignore_dep=False, ignore_safety=False):

pisi/operations/upgrade.py

@@ -252,7 +252,11 @@ def upgrade(packages = [], repo = None):
     finally:
         ctx.exec_usysconf()
 
-    return True
+    # Prior to 2c63650, this function had no return statement at all on the "complete" codepath.
+    # 2c63650 added a "return True". Unfortunately, it appears that "False" means "Ask the user for confirmation",
+    # "True" means "the operation failed", and "None" means "Success". Why? No idea! But removing the return statement
+    # or returning None fixes #173, so... do what works, I guess.
+    return None
 
 
 def plan_upgrade(A, force_replaced=True, replaces=None):